Received-SPF: pass (google.com: domain of linux-kernel+bounces-95971-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <ZeiNxaq3jzloO9l6@boxer> <20240307142402.906681-1-dgouarin@gmail.com>
 <ZenidKFF/gQefijz@boxer>
In-Reply-To: <ZenidKFF/gQefijz@boxer>
From: david gouarin <dgouarin@gmail.com>
Date: Thu, 7 Mar 2024 18:48:50 +0100
Message-ID: <CAH3uZAwOBeuV9FQpFJ5-S-j5HDWpxR5vvXKzUoq_UTOenz6=XQ@mail.gmail.com>
Subject: Re: [PATCH net v2] dpaa_eth: fix XDP queue index
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: david.gouarin@thalesgroup.com, Madalin Bucur <madalin.bucur@nxp.com>, 
	"David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, 
	Camelia Groza <camelia.groza@nxp.com>, netdev@vger.kernel.org, 
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Le jeu. 7 mars 2024 =C3=A0 16:51, Maciej Fijalkowski
<maciej.fijalkowski@intel.com> a =C3=A9crit :
>
> On Thu, Mar 07, 2024 at 03:24:02PM +0100, David Gouarin wrote:
> > Make it possible to bind a XDP socket to a queue id.
> > The DPAA FQ Id was passed to the XDP program in the XDP packet metadata
> > which made it unusable with bpf_map_redirect.
>
> I think that referring to a member from xdp_rxq_info struct as 'packet
> metadata' is confusing. I was trying to find a place where you are
> actually storing this id at xdp_buff::data_meta. This is not happening
> AFAICT. Thing is that xsk_rcv_check() picks xdp->rxq->queue_index which
> holds fqid which is not related to queue number, right?

Correct. I have used the term xdp metadata because that is the terminology
used in the xdp program (struct xdp_md).
I should have said instead :
The DPAA FQ Id was passed to the XDP program in the xdp_rxq_info->queue_ind=
ex
instead of the queue number [...]

Maciej please forgive me for the double send and formatting mistakes,
kernel mailing lists are new to me.

>
> > Instead of the DPAA FQ Id, initialise the XDP rx queue with the channel=
 id.
> >
> > Fixes: d57e57d0cd04 ("dpaa_eth: add XDP_TX support")
> >
> > Signed-off-by: David Gouarin <dgouarin@gmail.com>
> > ---
> > v2: add Fixes: in description
> > ---
> >  drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/n=
et/ethernet/freescale/dpaa/dpaa_eth.c
> > index dcbc598b11c6..988dc9237368 100644
> > --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> > +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> > @@ -1154,7 +1154,7 @@ static int dpaa_fq_init(struct dpaa_fq *dpaa_fq, =
bool td_enable)
> >       if (dpaa_fq->fq_type =3D=3D FQ_TYPE_RX_DEFAULT ||
> >           dpaa_fq->fq_type =3D=3D FQ_TYPE_RX_PCD) {
> >               err =3D xdp_rxq_info_reg(&dpaa_fq->xdp_rxq, dpaa_fq->net_=
dev,
> > -                                    dpaa_fq->fqid, 0);
> > +                                    dpaa_fq->channel, 0);
> >               if (err) {
> >                       dev_err(dev, "xdp_rxq_info_reg() =3D %d\n", err);
> >                       return err;
> > --
> > 2.34.1
> >