Received-SPF: pass (google.com: domain of linux-kernel+bounces-95974-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <3d9e47beeb08b3319651b49b81da4271cbbcad96.camel@perches.com>
Subject: Re: checkpatch.pl getting stuck on a macro in mm/kmsan/kmsan_test.c
From: Joe Perches <joe@perches.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>, Dan Carpenter
	 <dan.carpenter@linaro.org>
Cc: kernel-janitors <kernel-janitors@vger.kernel.org>, Linux Kernel
	Mailing List <linux-kernel@vger.kernel.org>
Date: Thu, 07 Mar 2024 09:13:32 -0800
In-Reply-To: <CAKXUXMwCdV466mRd4K0ePV73qDO9GRAph4KuC5nQ0JAp-ouemQ@mail.gmail.com>
References: 
	<CAKXUXMwCdV466mRd4K0ePV73qDO9GRAph4KuC5nQ0JAp-ouemQ@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-03-06 at 10:33 +0100, Lukas Bulwahn wrote:
> Dear Joe,
>=20
> while running checkpatch.pl -f on all files in the kernel repository
> (v6.8-rc1) for some experiment, I noticed that checkpatch.pl got stuck
> on mm/kmsan/kmsan_test.c, i.e., ./scripts/checkpatch.pl -f
> mm/kmsan/kmsan_test.c never terminates.
>=20
> I could already boil it down to checkpatch getting stuck on the macro
> #define DEFINE_TEST_MEMSETXX(size), see lines 541 to 554 in
> mm/kmsan/kmsan_test.c on v6.8-rc1.
>=20
> I do not know if it is worth fixing, but certainly I was surprised
> that reasonable code can put checkpatch into some stuck state.
>=20

I know why it hangs.  I'll give it a think for a bit.
I rather doubt Dan's suggestion is the appropriate one.

Code is:

		volatile uint##size##_t
uninit;			\

and in checkpatch line 2304:

			$possible =3D~ s/\s*$Type\s*//g;

where uint is a $Type it removes.