Received-SPF: pass (google.com: domain of linux-kernel+bounces-95965-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <159474e6-ef11-4769-a182-86483efcf2a6@intel.com>
Date: Thu, 7 Mar 2024 09:41:33 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages
Content-Language: en-US
To: "Luck, Tony" <tony.luck@intel.com>, "Wieczor-Retman, Maciej"
	<maciej.wieczor-retman@intel.com>
CC: "Yu, Fenghua" <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>,
	"james.morse@arm.com" <james.morse@arm.com>, "ilpo.jarvinen@linux.intel.com"
	<ilpo.jarvinen@linux.intel.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>
References: <cover.1709721159.git.maciej.wieczor-retman@intel.com>
 <8a158ada92f06b97a4679721e84e787e94b94647.1709721159.git.maciej.wieczor-retman@intel.com>
 <SJ1PR11MB608310C72D7189C139EA6302FC212@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <o6va7b7rc3q46olsbscav7pla4hxot2g6xhctflhmf64pj5hpx@56vtbg3yyquy>
 <SJ1PR11MB60830E546B3D575B01D37104FC202@SJ1PR11MB6083.namprd11.prod.outlook.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <SJ1PR11MB60830E546B3D575B01D37104FC202@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjV3M2lFcEVvdnhEZnl4a25KNkQ5N2VEV0xPeWprUkpPeDdiWjZEaVBzd0gz?=
 =?utf-8?B?UGtHM2t3UXpWQkEwdlk5Q2krVkNnTngvazNETHgrZE5xeWhEaGpVZnAvT0VL?=
 =?utf-8?B?WUlQdEZpaHhYSVFhZEhvMUFPTzk5MDFZOXVqOG10Nm5LSlhWTyt6U29kN2dr?=
 =?utf-8?B?a3A3WFhCSmVPYngvdHhUczc0cU8ycjVvR1F0NEpJVWtRRjVEd04rcmN5VFBj?=
 =?utf-8?B?QnBOWEk4djNEWHRaaEZ3YmVRblM5eUhlYVdDOVFrV0JHRG5ac3lqWjFnTlpz?=
 =?utf-8?B?eWdhaVA1SEhqTHNQbzE2R1dBdXFLYm5IRUEyNGxWcFJib1pMSDVKRGk5K2dh?=
 =?utf-8?B?QmJkRks5VlNHTVNPdFB5Vm43WlczY0dmbHNQNEJNbmtVS3lpT242N0g4OEhQ?=
 =?utf-8?B?cysyemlnNCtOeE5Wdm1XWUhHZ0Z4MHRGYVU5TU9tUGhBZXo3dUw2cmJTTHVN?=
 =?utf-8?B?NDNNTkZTYzNwaDIwczRGRFpOR3QvY3lDTjN0bDdYL2V3dUlhZ0ZzUnlSSWlI?=
 =?utf-8?B?bW1XV2ROa2NVUnBMbGJoNi8wNHB2c2dtUUQxZ2V1QlAxWGpaM3JEcENac2pO?=
 =?utf-8?B?U2tlekcxMzd6YzFZRDZNT1gySVhMMFAzZldlM2RvTi9pK0JESUw1bkJ2ZTYr?=
 =?utf-8?B?aDZlcktwUXBhOExBR3R0cjBQL3AvODhjdWpMYlh2TjBXTU1DWGlZb1dZUVlW?=
 =?utf-8?B?alNzYmo1R2tzdld5SkJCZTJuZXVLL1IrL0pTdjAxQ3htRHNLRW9DUjFZWDdO?=
 =?utf-8?B?N1R0WXlZWmhXKy83YUs4VGdsYUhKRm5ucmlVQ2NxdDVmeW41azBIcFAwRUQ2?=
 =?utf-8?B?eTZDc3I1cXdUbnlhQWFHalpYaVY5MU9ldWRJaWgxcGRJYzEzcFdxOW5WeW5t?=
 =?utf-8?B?Rk5rOE9vM3ZHa2RRaG1CQW9JVHRFWXJYaE9ZMklidUtNMG01cEdTM3BmS3lK?=
 =?utf-8?B?amNqRDZ5am1mcHdMNjdsak1WM2FESjREV0JxTU44aEhhUW1ScnFXVE8zdVpD?=
 =?utf-8?B?allJdzJnUGdkMkw2UmxuK3JjUzk3emxkSW50Q1lxMjhqSDgyQ2x4eDZBNzkw?=
 =?utf-8?B?WFUzNTNoeEdEN2lQZGlJUXZva1V6N2J2ZCt2LzdXd3hnbE5JVTB1M2hFOE5u?=
 =?utf-8?B?bUk3Q1Z4bUFWUWFSaWZPL2Z1Smd6NUZGT21VR3h6THhwVEx5TFRSbzgwdUNa?=
 =?utf-8?B?TnptSmlUcCtTQ1k1M3FiRUUwRHRWK01nVzdTd2IwUlZMM1VKaHhDRnNXZXlX?=
 =?utf-8?B?UVVjaC9WVUpTeFdPT0hXZmZoTkF0bEpmYVNUM1FkVElxZVlHUWNXSHlKWVR6?=
 =?utf-8?B?NkdWZEtNN2lSWkdYNnVIMzA2OGlSUXB4cW9JcXRRNjVYTitVQ0lCeGduOEVx?=
 =?utf-8?B?MnJLN1d1NmJVK1NVdXBLZWFMNXdWRjBKM1ozT0sxMXExWmN3eHpWcmw3TGFp?=
 =?utf-8?B?NmJmVTdzOWlPcGMydVA5T2ZueDY4U0NBRUF4VzYzUkhlSkwrcGQrZFJ6QXVZ?=
 =?utf-8?B?aitiS0V0M25ZdUVTVzZabE41aTJsczBkaG9ubXNrQXhRWXZJSW02bXpoUDhk?=
 =?utf-8?B?SDlHa1JTOWxrbXA1ZmhuVEppMG5BbjJQRXBHQzN2TWxiY3NEcDVwUDNlcDJZ?=
 =?utf-8?B?Sy9GbXIvbm5SMHlBajFENlFZay9FTSt2VFRiSDcrRGYwZjJFWFlqQVcrcFZU?=
 =?utf-8?B?RVRkZDlPWEhQYjJMeHoxS0hhcWNXU2MrT20rcGJOQjFvbFptNnZDMnN5QklY?=
 =?utf-8?B?K0lLZWJQazdUa016b2xBL05obGxDWEl3TWxjaDlLZFYrSEJ5MVVoVGR0OHZB?=
 =?utf-8?B?L0RidFMvZ2d3bmttUWtCbnNHN2pyL1laaEh0ZmZRcDJuSXZXNUpXT0Y2ZWhz?=
 =?utf-8?B?YTRPRFlIaVRzenpwaE9ZSGErUEtPWi9aQXJNMTdWTnVaTHUvYWFwWGlDcUxw?=
 =?utf-8?B?S3RLY2J4akNJZ29IY2VwTDQ1MXAzZ0dSMmw3cG9hTTB5M0l4ZlVxRlQzYS9n?=
 =?utf-8?B?RmNBYnM0SVd2aTJUM01LcEhBd3p0aGVNejQ1ajhMS1ZjeXFNekNnNGlpYjV3?=
 =?utf-8?B?WFBKWFdZUzYzLzg4NjZaN3JONWMrRHpuaVJ4THQ0V1VwN0dEVWlVZHV6aWhP?=
 =?utf-8?B?VGR3WGZ4TkIwTWhTOVBPMFVwRTJpTEhSWW9UY1ZKOGwyMmtnKzBRdzFvd1kw?=
 =?utf-8?B?aXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: db8190ff-f310-443e-a691-08dc3ecdd60e
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 17:41:36.1797
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XUVO+7ZFnYcjHaM/KeOnBAsA4WJR8il6Mdz54C2kaIJPeUMZLeQ814Ug4ExPoZV/AwlsAA2Aj77me3Zmqzy1pGOL5y6Gn9wQtQohjSQMF8Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5912
X-OriginatorOrg: intel.com

Hi Tony,

On 3/7/2024 9:18 AM, Luck, Tony wrote:
>>> If so, what should it be named? "snc_ways" as a kernel variable was
>>> later replaced by "snc_nodes_per_l3_cache". Is that a good filename?
>>
>> "snc_nodes_per_l3_cache" seems okay to me.
>>
>> And I understand that the file content would show SNC mode and the presence or
>> absence of this file would tell if kernel supports SNC?
> 
> Yes. The existence of the file indicates the kernel is SNC aware.
> 
> The value read from the file would give the number of nodes per L3 (obviously :-) )
> 
> SNC not supported by this platform or not enabled:
> 
> $ cat /sys/fs/resctrl/info/L3_mon/ snc_nodes_per_l3_cache
> 1
> 
> SNC2 enabled:
> 
> $ cat /sys/fs/resctrl/info/L3_mon/ snc_nodes_per_l3_cache
> 2
> 

This would be useful. I believe "SNC" is architecture specific?
What if the file always exists and is named "nodes_per_l3_cache"?

I assume that the internals of handling more nodes per L3 cache should
be hidden from user space and it should not be necessary for user space
to know if this is because of SNC or potentially some other mechanism on
another platform?

I think that may reduce fragmentation of resctrl .... not having
resctrl look so different on different architectures but maintains
the promise of a generic interface.

I am not sure if this is specific to monitoring though,
why not host file in /sys/fs/resctrl/info/L3 ? 

Reinette