Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp78832lqc; Thu, 7 Mar 2024 10:48:32 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXdP8WUBrOihhBFGoQ3cyyq4dGcuE/WPdc4qbzDSozhUhqbt11r3UpIU0S2a+56C3uAJq58JCkmYjkeoMJgzDYcltUQ4jFKkh4UDXrJnw== X-Google-Smtp-Source: AGHT+IFnepMSJ9ORjtX+BeV0y3u1ggkOQ2pddo3ezJ7lqO7Gk/8qXNATnKNZ6vTquu9q3IuxbbI8 X-Received: by 2002:a05:6a20:5490:b0:1a1:7f7f:32d9 with SMTP id i16-20020a056a20549000b001a17f7f32d9mr871871pzk.14.1709837312586; Thu, 07 Mar 2024 10:48:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709837312; cv=pass; d=google.com; s=arc-20160816; b=ZACR7wl+QgaC8ehPby8gRkSz7odWnqY6UVInEK5XVT7FRXtvUgU2us23l6LzFQbHpD 4ORSuzjBjKsPzI8nsQHrJaacsoL5eeMGlLzaiFwJYt4eGnkNxDVbEsWVTYIGG5XiRJsu CVpQSSEg7l6uRNYfusspbWEzBWtwk2qziCn89a2LKtX4rYhQSslOYlFMSXd43qPdohmE T5q7xBORJPBgYn/TReyf7auExCWZt+wnjAFHdxbWDupeRsyeSf+aAxT9BUf+wiYDzJFQ AFleboDPesB1Yf/4CEXKJOhw+gKoINV4ywo2NyTzQs+kp8RrxnA4JktxWKHllKm/QL/Y nCcQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=ErBHnKWtRFqvNw55T9rkkKbdxBMzIaYWMEOU702WcoQ=; fh=jGdaoZ9f8fxaZ4S3XMcGs4Y5Dr6Ro1lg3HBgLAvBHb8=; b=za53s8bliQFh4H2u9EbmYH9aUSL2OI8OhMFAQDm9785vWSiuWe48kKMW4XGIgvp3JT SSO1eIecjijYqh21rmB9Z1vZXMbuuYy19xsz4ChICTQMbQGWCRQUQrm+cSwH03algUsm WGlfKCyGBQtgQ1wkCXW3grh1rOsSB/Dcmt8Ysf3Yhh6jf80Rs0enoTN2fZwtL82uSy5G 50C0a+gRBv6ilka6IKDFBf6B7hrkf8rnMLkHW0Dm/59/pXIVZ/xtOTz3JL3ypkyb9wak EVbfjJeLgovdW6CA7TR3TDJFv0/MGXky0VGYPcDbnpX/qvddXB08Q/s53okOF4+XoCbd E7cg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=MrdGbSdY; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=MrdGbSdY; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-96031-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96031-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id j5-20020a056a00130500b006e63dc9173fsi5628970pfu.103.2024.03.07.10.48.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 10:48:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-96031-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=MrdGbSdY; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=MrdGbSdY; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-96031-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96031-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 44DE2281865 for ; Thu, 7 Mar 2024 18:48:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 52ED2135A6E; Thu, 7 Mar 2024 18:48:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="MrdGbSdY"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="8sNY0uT3"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="MrdGbSdY"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="8sNY0uT3" Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8851A12FF9D; Thu, 7 Mar 2024 18:48:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709837302; cv=none; b=kffx9FQ56oekNBUdqo4UHGNRynlXfoVTp32QNuPMQEbzWRmDK1FanOqUsvoyWJGKfa5DeDSCH8wGHKrMPQN01xbbJYd0KJk62UKhjsKGDXzqH9yw/xQsQ8VE+5S4aCGf6Dy7QmtbbN4tTQHL1d21ezuraoR6f98nGvS5/QD175Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709837302; c=relaxed/simple; bh=C2VOgxDNF3z54szP1T9vL+C7fWDnK2058X2DEohiKhU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=d9jm71gDUxON4WXL+zoFY+KyHZ+4wPF9HFHwoWecKwHb2Ogm0JeDMDTcSxFCy7axcHSaiO//+SrJSrf4G+wo61onx7yHYoUJXgqW/RHwBwmGCCfJYxo/rul3L2gcdCAvsEVx4wGvtjNQmfXj//AYjTsDSRBYkV9adAf1iD5CX3I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=MrdGbSdY; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=8sNY0uT3; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=MrdGbSdY; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=8sNY0uT3; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C0DCB4D8F9; Thu, 7 Mar 2024 16:02:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709827350; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ErBHnKWtRFqvNw55T9rkkKbdxBMzIaYWMEOU702WcoQ=; b=MrdGbSdY2GSUUSwxlyzK0gmdXBNHgWiGVODtKopkFRKuDc9hNu97IxwVo8foiDJf+vb5tV UXFcob7Vv84VC/sbdecp+uxYSKy6j9C0H1gAUBeOSMEH2bs3SZRl4gzBNaTOJbJdd3Z4ya rpK4i0QUmzHhPcoiqpA2C90fIPyIogg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709827350; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ErBHnKWtRFqvNw55T9rkkKbdxBMzIaYWMEOU702WcoQ=; b=8sNY0uT3kN45SMpk172hGSS+n5QRIhY8gYJ7uQx9kriStHmAhQ/UdAk9oBPlNuihuv0qA7 3AmTcOQ31f8th9Cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709827350; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ErBHnKWtRFqvNw55T9rkkKbdxBMzIaYWMEOU702WcoQ=; b=MrdGbSdY2GSUUSwxlyzK0gmdXBNHgWiGVODtKopkFRKuDc9hNu97IxwVo8foiDJf+vb5tV UXFcob7Vv84VC/sbdecp+uxYSKy6j9C0H1gAUBeOSMEH2bs3SZRl4gzBNaTOJbJdd3Z4ya rpK4i0QUmzHhPcoiqpA2C90fIPyIogg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709827350; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ErBHnKWtRFqvNw55T9rkkKbdxBMzIaYWMEOU702WcoQ=; b=8sNY0uT3kN45SMpk172hGSS+n5QRIhY8gYJ7uQx9kriStHmAhQ/UdAk9oBPlNuihuv0qA7 3AmTcOQ31f8th9Cg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F0E2712FC5; Thu, 7 Mar 2024 16:02:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qu2ENxXl6WXtcwAAD6G6ig (envelope-from ); Thu, 07 Mar 2024 16:02:29 +0000 Received: from localhost (brahms.olymp [local]) by brahms.olymp (OpenSMTPD) with ESMTPA id 90e11876; Thu, 7 Mar 2024 16:02:29 +0000 (UTC) From: Luis Henriques To: Theodore Ts'o , Andreas Dilger , Alexander Viro , Christian Brauner , Jan Kara , Miklos Szeredi , Amir Goldstein Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Henriques Subject: [PATCH v2 0/3] fs_parser: handle parameters that can be empty and don't have a value Date: Thu, 7 Mar 2024 16:02:22 +0000 Message-ID: <20240307160225.23841-1-lhenriques@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Level: **** Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [4.90 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; R_MISSING_CHARSET(2.50)[]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BROKEN_CONTENT_TYPE(1.50)[]; RCVD_COUNT_THREE(0.00)[4]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWELVE(0.00)[12]; MID_CONTAINS_FROM(1.00)[]; FREEMAIL_TO(0.00)[mit.edu,dilger.ca,zeniv.linux.org.uk,kernel.org,suse.cz,szeredi.hu,gmail.com]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; BAYES_HAM(-0.00)[18.80%] X-Spam-Score: 4.90 X-Spam-Flag: NO While investigating an ext4/053 fstest failure, I realised that there was an issue when the flag 'fs_param_can_be_empty' is set in a parameter and it doesn't have a value After an initial attempt to fix the issue, Christian suggested a different approach and the following patches are based in his suggestion. Another change that I'm introducing in this v2 is the change of parameter 'test_dummy_encryption' to also use the new helper introduced by the first patch in this series. Finally, I'd like to ask someone to look closer at the overlayfs patch as I don't think there were any fstests to validate the case where 'lowerdir' is empty. Luis Henriques (3): fs_parser: add helper to define parameters with string and flag types ext4: fix the parsing of empty string mount parameters ovl: fix the parsing of empty string mount parameters fs/ext4/super.c | 25 ++++++++++--------------- fs/overlayfs/params.c | 13 +++++-------- include/linux/fs_parser.h | 8 ++++++++ 3 files changed, 23 insertions(+), 23 deletions(-)