Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp79919lqc; Thu, 7 Mar 2024 10:50:33 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX5OYHbv5JoCnSlBBOey4Gl6H8m0e1Qoco4idM9E7rQliSHoUNUdO5tFTlUR5bbl1Kig0vTqcPtWX3ZwWk5uwYSmGXZpZpk7sKlY7ubrw== X-Google-Smtp-Source: AGHT+IEG615e0hD8cYfsBZcF2BKiu+OrAGiLAuFlc1CDsFZrBjU/0fToB/F7A6JoBfCaiD0ytZtI X-Received: by 2002:a05:622a:1182:b0:42f:205f:d20f with SMTP id m2-20020a05622a118200b0042f205fd20fmr2549455qtk.23.1709837433031; Thu, 07 Mar 2024 10:50:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709837433; cv=pass; d=google.com; s=arc-20160816; b=vwtR8A2qBp/Z3McCRMBMxQ+TPwix8eFCRVAB3M0CFzgkb3YETpYkCWdmgLt/dIDODD TJhRhvMo6lMMusHwnTwhSWlc2rGdzUZEOyN/dmpTr34Lj+hmPimn63mUdfMumxr+Q8Fo dm3NPKOAVeURqX17oATqi7yUmofKqwiRrTS1tmgxCK1ZYZUwh0i2pIZWrS3KO+6jcwZT MmUDjzdW30+btP5SRTsjuago72CdGnvgkbhlY8+Yasi4za2kfzYOlLvApUnRNPju3ZtF IY4+3JOZYM4SoEgNFa/Z+WNSp6MxGU422URcvsQMP504lVeAWRrO8ahE74oGGAiaF1ad pCQA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date; bh=Oui1MW119tBegORPmVHwUMz4AAtqfEqlY9x5E6G59XE=; fh=2thU4KanEeBonHED8vyqLSASzT4CsJKKy+7iKD/giH0=; b=u2dgej2GMpf+dg9NTW6ETZJOl6rWCagpPfaDrif18KxNYcHi1A4E8cphS5uoUh+/UW tauANYsi1b0rbAOCUOG0nzYOCvqu+08xVptMufhTJiiVKua102Wiq0VnEJ9YJiEZJ6sP PaQnucA7YAdpjsKDNSibNVdySTe0kINPbZGq9IskD2Q1IISU+fjepzvlrcxk1L9n8yES dTGdcHXF8fTZw+UaqDoDpyfGwMW/Q4aA91EIKxw1q9ze4nIZ+sSgLxSZg4U/ZukDAK6D gvXNlnVe8mnHfG/s8OWT1k3XaB1HkIo6q4Cd0D3j8Jdl7DPtfs4kua+pN/hYZPmzF7A7 leWA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-96035-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96035-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id t22-20020a05622a149600b0042f1597d045si2983570qtx.140.2024.03.07.10.50.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 10:50:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-96035-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-96035-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96035-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A53261C21456 for ; Thu, 7 Mar 2024 18:50:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1B617135A50; Thu, 7 Mar 2024 18:50:23 +0000 (UTC) Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82BEE1E4A2; Thu, 7 Mar 2024 18:50:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709837422; cv=none; b=KVdMceSq5R5Td1nUvUJ5qc4D4Qo/CbNSsNtCnvzoHIZa8ePv/8i7j1J0ZhsJopL+bBkwzC9+sK1YWAyOjAPYHizGHBTFbJu/GZdulC0uv0VbNdC/TUkez+B34ejHQFzqB0agq/wJDRaEXCcRWLA8iE+RLW3cc1Lrq6aOCO0fZ+Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709837422; c=relaxed/simple; bh=Oui1MW119tBegORPmVHwUMz4AAtqfEqlY9x5E6G59XE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lJ+hSeolhVGHq6hMPi71qNIxQLmOW2azwiTF39/zTf2m6+jdEhGLAym9ooC2e0AT4YWBe59PsylRM5K7gMG6MgzHHEiQfY2pqm+smqXWRhMQx4HSJbgWhbxZBpKliB49ETYIMQbbkbXMWK0kEtYqFnIJr2l162Cx6OnPXQ9QS04= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F7CBC433C7; Thu, 7 Mar 2024 18:50:20 +0000 (UTC) Date: Thu, 7 Mar 2024 13:52:15 -0500 From: Steven Rostedt To: Mark Rutland Cc: Joel Fernandes , paulmck@kernel.org, Network Development , LKML , rcu@vger.kernel.org, kernel-team Subject: Re: [PATCH] net: raise RCU qs after each threaded NAPI poll Message-ID: <20240307135215.7ba88d83@gandalf.local.home> In-Reply-To: References: <55900c6a-f181-4c5c-8de2-bca640c4af3e@paulmck-laptop> <10FC3F5F-AA33-4F81-9EB6-87EB2D41F3EE@joelfernandes.org> <99b2ccae-07f6-4350-9c55-25ec7ae065c0@paulmck-laptop> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 7 Mar 2024 16:57:33 +0000 Mark Rutland wrote: > * Use rcu_tasks_trace to synchronize updates? Yes. I think I wanted both. The above to make sure it covers all cases where something could be preempted, and a case for those covered when RCU isn't watching (which always has preemption disabled). My mistake was I thought synchronize_rcu_tasks_rude() did both. But I just found out recently that it is not a superset of synchronize_rcu_tasks(). But it really needs it in every location that synchronize_rcu_tasks_rude() is called. -- Steve