Received-SPF: pass (google.com: domain of linux-kernel+bounces-96094-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 7 Mar 2024 19:21:09 +0000
From: Conor Dooley <conor@kernel.org>
To: Julien Massot <julien.massot@collabora.com>
Cc: linux-media@vger.kernel.org, kernel@collabora.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	mchehab@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	sakari.ailus@iki.fi
Subject: Re: [PATCH v4 2/4] dt-bindings: media: add Maxim MAX96714 GMSL2
 Deserializer
Message-ID: <20240307-retract-aloof-9ff1fde79a82@spud>
References: <20240305152608.287527-1-julien.massot@collabora.com>
 <20240305152608.287527-3-julien.massot@collabora.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="YVK4XItZqyyKtGIy"
Content-Disposition: inline
In-Reply-To: <20240305152608.287527-3-julien.massot@collabora.com>


--YVK4XItZqyyKtGIy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 05, 2024 at 04:26:06PM +0100, Julien Massot wrote:
> Add DT bindings for Maxim MAX96714 GMSL2 Deserializer.
>=20
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
> ---
> Change since v3:
>  - Renamed file to maxim,max96714.yaml dropped the 'f' suffix

Why? The filename should match the compatible, which /does/ have an f.

>  - Removed mention to C-PHY since it's not supported by MAX96714 deserial=
izers
>  - Removed bus-type requirement on CSI endpoint since the device only sup=
port D-PHY
>  - Removed the clock-lanes property in the dt example
>=20
> Change since v2:
>  - remove reg description
>  - rename enable gpio to powerdown
>  - use generic node name: i2c, serializer, deserializer
> ---
> ---
>  .../bindings/media/i2c/maxim,max96714.yaml    | 169 ++++++++++++++++++
>  1 file changed, 169 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/maxim,max=
96714.yaml

> +properties:
> +  compatible:
> +    const: maxim,max96714f

> +  i2c-gate:
> +    $ref: /schemas/i2c/i2c-controller.yaml

There is an i2c-gate binding, you should reference it here instead.

> +    unevaluatedProperties: false
> +    description: |

This | is not needed, there's no formatting to preserve.

> +      The MAX96714 will pass through and forward the I2C requests from t=
he
> +      incoming I2C bus over the GMSL2 link. Therefore it supports an i2c=
-gate
> +      subnode to configure a serializer.

--YVK4XItZqyyKtGIy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZeoTpQAKCRB4tDGHoIJi
0qyuAQDRRcB5+1h8xQVfJkvmV80j6Spgx0pLBnQoqCdZVE8i6QEAzkbOrL2NcpjK
4jetePOWh2/qmjyMGvGJEz9K80bhuAI=
=Z4HV
-----END PGP SIGNATURE-----

--YVK4XItZqyyKtGIy--