Received-SPF: pass (google.com: domain of linux-kernel+bounces-96116-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Jens Axboe <axboe@kernel.dk>
To: Hannes Reinecke <hare@suse.de>, Christian Brauner <brauner@kernel.org>, 
 Jack Wang <jinpu.wang@ionos.com>, Phillip Potter <phil@philpotter.co.uk>, 
 =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc: Guenter Roeck <linux@roeck-us.net>, linux-kernel@vger.kernel.org, 
 kernel@pengutronix.de
In-Reply-To: <20240307180837.190626-2-u.kleine-koenig@pengutronix.de>
References: <20240307180837.190626-2-u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] cdrom: gdrom: Convert to platform remove callback
 returning void
Message-Id: <170984014091.501426.12348420904865022114.b4-ty@kernel.dk>
Date: Thu, 07 Mar 2024 12:35:40 -0700
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


On Thu, 07 Mar 2024 19:08:37 +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> [...]

Applied, thanks!

[1/1] cdrom: gdrom: Convert to platform remove callback returning void
      commit: 0dc31b98d7200a0046de5c760feb0aaff6c4b53c

Best regards,
-- 
Jens Axboe