Received-SPF: pass (google.com: domain of linux-kernel+bounces-96117-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <5487d52a-31de-4422-b5ed-a59390d23ca0@kernel.org>
Date: Thu, 7 Mar 2024 12:36:53 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net v5] ipv6: fib6_rules: flush route cache when rule is
 changed
Content-Language: en-US
To: Shiming Cheng <shiming.cheng@mediatek.com>, jiri@resnulli.us,
 kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
 Lena Wang <lena.wang@mediatek.com>
References: <20240307100157.29699-1-shiming.cheng@mediatek.com>
From: David Ahern <dsahern@kernel.org>
In-Reply-To: <20240307100157.29699-1-shiming.cheng@mediatek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 3/7/24 3:01 AM, Shiming Cheng wrote:
> When rule policy is changed, ipv6 socket cache is not refreshed.
> The sock's skb still uses a outdated route cache and was sent to
> a wrong interface.
> 
> To avoid this error we should update fib node's version when
> rule is changed. Then skb's route will be reroute checked as
> route cache version is already different with fib node version.
> The route cache is refreshed to match the latest rule.
> 
> Fixes: 101367c2f8c4 ("[IPV6]: Policy Routing Rules")
> Signed-off-by: Shiming Cheng <shiming.cheng@mediatek.com>
> Signed-off-by: Lena Wang <lena.wang@mediatek.com>
> ---
> v5:
>   - rebase on the top of latest net/main branch.
> v4:
>   - add "Fixes:" tag.
>   - update subject as requested.
> v3:
>   - update patch description and name format in commit message.
> v2:
>   - modify flush function same way as ipv4 flush cache.
>   - use tabs to aligh with existing code.
> ---
> ---
>  net/ipv6/fib6_rules.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Reviewed-by: David Ahern <dsahern@kernel.org>