Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp114608lqc; Thu, 7 Mar 2024 11:55:16 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUQq/u7u0GLIWSWKp6Gqcscsps0hjPgRjlH/7aPIzYb09UVpFRf6clSvytckIRuxPBH0pJKzft2Ma8OaxJt2epkPiBysXRVUOd/s3CY1w== X-Google-Smtp-Source: AGHT+IF/acv0T6aN1TV1Q/AYqWNGfvOKczf2sSjI2Ot0w6MuAdD+Ypuv4Bys58Y8N0slthtT/Jjt X-Received: by 2002:a05:6830:1117:b0:6e4:e54c:e583 with SMTP id w23-20020a056830111700b006e4e54ce583mr8826499otq.2.1709841316000; Thu, 07 Mar 2024 11:55:16 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709841315; cv=pass; d=google.com; s=arc-20160816; b=jPze3QsMuJR/rgCkSxq2EusRLzQHm5QXbLPrWqSvXRmrPo8sc401S+yYEbAJ/Z9pZ+ Q3oP/z1Apkis+pXm+X3XbsSbmF5g7aMLkmxWDeNVpbTPpUP/IdMRoYrCsjOLxTJf3aF9 yP4n5eeLumZm7yKlo7FR8/9gTCI8V+G2hZSrHtuY1YtDQd7EaROkh5olB0RFdOeoxBXA fFcwN4UrYm8HqLfcBf1EWbX6nL7axa/YbHYB/O2wYn5EteGfJIIVil/NLF5p96eM02R0 +nxUMfrO1dDZthvK3oPnQdxNhVU3yrsnQTULUByOrZvGaQz/DZAeIUpE/EHal7grZzV4 JF9A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=F44BRewb4PCChhhJvzrU/ROggreq9crZPj69H+9UMUs=; fh=JOMs4cCEiY9iuBNXOVa2RG+IujJg9SLSvDgQT2j+igk=; b=MYzqlPogMs4XVPFzw1x3dguITidffT0bsNq3PRvqW0XgWcrWLu85oUjnkBbt7jg/+I v/nifZrgyirY/deVhoLp1YsPf1p6yWeakF6Du9ErQrG9DQujx2SakQBsuJxeVmBuiQN3 0I1iXyMqE0HpWrUems912v+zMP6dhEmuUuVFBpE63v5iOOp6Vv3BTbofrop36XtJVI0l UDZFFhCk4+CMJJ7xW/2I73VNqWvROFh7DgeNfWQNcBPTjuYm9dn3XNg1IL3+UivNiPMZ KcRUSATPwRWwkJ+eb+212YpeHo3a/7LSNqx2qBD6dWe88vrdYShvvykLAe5tUVbwGNuL JtZw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kZm2YSwS; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-96142-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96142-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id h12-20020a63e14c000000b005dc89957de5si14534215pgk.497.2024.03.07.11.55.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 11:55:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-96142-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kZm2YSwS; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-96142-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96142-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E0BE0286F44 for ; Thu, 7 Mar 2024 19:53:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 30EF41369A4; Thu, 7 Mar 2024 19:52:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kZm2YSwS" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BCF6137C42; Thu, 7 Mar 2024 19:52:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709841162; cv=none; b=hb8hODoA+whsFIAgnMGa4gGnyMWtTeqNoJIEu9g7XvM9OXqoyx5l9mdXcz+JyW7A830HjC8/gwKsU9b5i1rZ2xp1+/q6si+embIMj+seHKzyBNF0ruQBuBajkrX1Dk5DLnoE85Ir0OvwV6/7F3Tq8aZTCz+9nqEtPEKNRWI+fxA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709841162; c=relaxed/simple; bh=abVM7Az8c+fwhJYNf8SjY0MPBlfozwtnuPRGUqiuFH0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ejbGhXuIsYrpA+6VzfyjocJNZUAKMGufA+5bdAEnnSm7W0aWbCFrVZBAkzTIqQGaVtl0aHJUOB0gAKl4KhYU4yugbUXtw2k/7AKIx8Kybsd5Tgei3VtlQylmEAxiTCujg9/gEn76mSIN9ZYu0QL4wivX6J1aqRXfyczFG8shlQA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kZm2YSwS; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE4C0C433F1; Thu, 7 Mar 2024 19:52:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709841161; bh=abVM7Az8c+fwhJYNf8SjY0MPBlfozwtnuPRGUqiuFH0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kZm2YSwSeAjDl/IxeY39+GMpbM8g/8yLdpNPzBh9Kp9OI7lIHdGVkI0W/SiXGXlVY 8Ye4MdEO3tCq/Rskx6KQb/6n0TYuz5hgFRUTqcPq5lMDRZ4e68xdlI+OtljF8BrAhW uU3G/XKfd2W+GAEpIvJOH8/VjiPRvy3xkmXqZ6ZJN16Jj5szHjOqM4WehX4qqAwgUo lK6yFgKRk4vAkGPgD4jvralrfWKvR87DyZ2a62ltCqD/q4ZXANAZfTOlh9cdeyaotn gMKzIMKEyAbzGgl9wgZHgDfKWgZnsBm8mLkobnvwBY2pLtH90c8M7zCL36b5O9cGzO 9MQH5Xf1EoKww== Date: Thu, 7 Mar 2024 20:52:30 +0100 From: Niklas Cassel To: Manivannan Sadhasivam Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com, Frank Li Subject: Re: [PATCH v9 01/10] PCI: dwc: ep: Remove deinit() callback from struct dw_pcie_ep_ops Message-ID: References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-1-29d433d99cda@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240304-pci-dbi-rework-v9-1-29d433d99cda@linaro.org> On Mon, Mar 04, 2024 at 02:52:13PM +0530, Manivannan Sadhasivam wrote: > deinit() callback was solely introduced for the pcie-rcar-gen4 driver where > it is used to do platform specific resource deallocation. And this callback > is called right at the end of the dw_pcie_ep_exit() API. So it doesn't > matter whether it is called within or outside of dw_pcie_ep_exit() API. > > So let's remove this callback and directly call rcar_gen4_pcie_ep_deinit() > in pcie-rcar-gen4 driver to do resource deallocation after the completion > of dw_pcie_ep_exit() API in rcar_gen4_remove_dw_pcie_ep(). > > This simplifies the DWC layer. > > Reviewed-by: Frank Li > Signed-off-by: Manivannan Sadhasivam > --- Reviewed-by: Niklas Cassel