Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp118487lqc; Thu, 7 Mar 2024 12:02:34 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUivXtiOnJ39O/7fmJci1UrkX5ySCo9ANcug9xk1C50MhzbfUstkBejWDDh+NwVhdcYzv8rjhbBZ5QBLmWT0UTXEDso6BiwmgXxdLSejQ== X-Google-Smtp-Source: AGHT+IF1e7RabzMIN3eIoMgISO0TE1h9FlfgAB2zF9if0n9b50iiRcmTTXXRxFqd0WIDt7WoyG3l X-Received: by 2002:a05:620a:1193:b0:788:363e:8d08 with SMTP id b19-20020a05620a119300b00788363e8d08mr3658349qkk.38.1709841753778; Thu, 07 Mar 2024 12:02:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709841753; cv=pass; d=google.com; s=arc-20160816; b=zHkb2+VmA5jHylBPYAwPLonyOoVniQVojd8+pfKrWNkdo3mb6otzfbeUuBMRMoxYOd 56fIztAbjLrJZ+q5eWiwWrr++WPW/UdSY4a5kvB4e55MSFS/qfqqSh947Ee750LR+q9J 2QFBQDOLCFn42GQydsuvoAun06pAiJLf8wYXr8NHTrRfcie6Z39GeoJUafyA2v+EUr8q fKvtnvn7tM8PXQLLpaPQtzrTxDdvyUEZc6etIKku3ZVQVocZsLVAXO5MPAFBtfk+FPi7 Bzdx6Xg4m1B0DRjRQ2R+NzbVeHVpJQMDqY+2SVJeBJejRYxgn7syYuCgVUtB7+wFftNj lNcA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=L17XNvtm+LiYlPtwYfs/WUz7kHzwagvb9jk0vVfGjME=; fh=uqlPtjLIChXyRWAPGcu4t5iRkGJvIMUrkNSnCGGyIZg=; b=DbZZozEbNKP3NY1BS9X67glPfL0L5HGEFaoNdp5IsMLtbwwHoCQ7tgZdlydYlfuYCc 4AKfV9gRDUfyDCR4ANvoe3H/Zwii62EphONSDt+AFyrpmVaZKMVxKunsggSrwQEEXG9S 3MfvE9+QKufM0DwTRpPVaQV0sFmq8W9+bP5MVIKdc/IDps6vFQcRxA4xYxzh64ibQFdO dQRYUToT51f6ITNGbtJKtNgx/46qxDbwEZWG0BQ6Y7lcj5f8ax0cOnEeD7KlY92hbLSs gAlU2+dOZXfDddSsplYLiIOp1hs26zanT4Zu0fagBqmmSurbeEQugAuM3JcfS1mEI7Pp H0iA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=wnsVQwjI; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-96155-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96155-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id ye9-20020a05620a3b8900b007883ba9303csi4974130qkn.644.2024.03.07.12.02.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 12:02:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-96155-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=wnsVQwjI; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-96155-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96155-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 6F8BD1C209AC for ; Thu, 7 Mar 2024 20:02:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0B776131733; Thu, 7 Mar 2024 20:02:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="wnsVQwjI" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DFC3137C40 for ; Thu, 7 Mar 2024 20:02:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709841746; cv=none; b=jTlOh0WcULfI2gHHkao5UNP/vUmWGBO9sI5IZV1BTfFFmtCO0Bw17HVVMD1NknKl1Rmldm73jaXfZigF8kOmNYjNJOKVi8/wg8143ye2tu3qI2VWWxJTjjwkwVXOrQCc3uNWQolyBvgZFlVBJ8hjWLD/rdkUAYGweh/c/XoixvU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709841746; c=relaxed/simple; bh=QbobZIm6vzGL9mxcMfH8aT0PgqTNhtb1r9nMruHiV+s=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=M8rx/GwBDrMNpRcj/QNbXjHwk3ySMnbXQvM0lNmG/sRB2hGO5zuZ6UBflzbpJ9aG2w6vOYzl9mIbzR9ldBQ+jMu4lDKoVT7A2kjsiRFnOqfxZkqSfEL5Eamb69fhKsh8kkRzT2luUD+Kw+3Tmbym87BoofuFGrLFaVZNw8ExSmI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=wnsVQwjI; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B6AFC433C7; Thu, 7 Mar 2024 20:02:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1709841745; bh=QbobZIm6vzGL9mxcMfH8aT0PgqTNhtb1r9nMruHiV+s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=wnsVQwjISTY26rsce3Mp51KQ9qVjmObeUi7hVcXKuWEu+cPGKv153v4mf+bBGr7qd knIISBKOVKQxMviHSCqE1UoUndxCJqzPDBfx7h3VuAMpmubswxI0u58JUi8tWPg1o2 mGb337V5oD3l6TjJNsWMcdYue0YK+Kis9Rht+Nlo= Date: Thu, 7 Mar 2024 12:02:24 -0800 From: Andrew Morton To: Zi Yan Cc: Zi Yan , linux-mm@kvack.org, Dan Carpenter , "Pankaj Raghav (Samsung)" , "Matthew Wilcox (Oracle)" , David Hildenbrand , Yang Shi , Yu Zhao , "Kirill A . Shutemov" , Ryan Roberts , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/huge_memory: check new folio order when split a folio Message-Id: <20240307120224.0e627784a13cff1121048ae4@linux-foundation.org> In-Reply-To: <20240307181854.138928-1-zi.yan@sent.com> References: <20240307181854.138928-1-zi.yan@sent.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 7 Mar 2024 13:18:53 -0500 Zi Yan wrote: > From: Zi Yan > > A folio can only be split into lower orders. Check new_order to make sure > it is smaller than input folio order. It isn't clear what's being fixed here. Presumably something is passing in such folios, but what and where and why and what are the effects? Might it be that these folios are being caused by the debugfs interface? Or something else? So I'll add it, but I do think more information and context would improve the patch, please. Suitable Reported-by:, Closes: and Link: tags, perhaps.