Received-SPF: pass (google.com: domain of linux-kernel+bounces-96143-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <0393c4ce-7e41-4dcc-940a-a6bea9437970@intel.com>
Date: Thu, 7 Mar 2024 11:52:41 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages
Content-Language: en-US
To: "Luck, Tony" <tony.luck@intel.com>, "Wieczor-Retman, Maciej"
	<maciej.wieczor-retman@intel.com>
CC: "Yu, Fenghua" <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>,
	"james.morse@arm.com" <james.morse@arm.com>, "ilpo.jarvinen@linux.intel.com"
	<ilpo.jarvinen@linux.intel.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>
References: <cover.1709721159.git.maciej.wieczor-retman@intel.com>
 <8a158ada92f06b97a4679721e84e787e94b94647.1709721159.git.maciej.wieczor-retman@intel.com>
 <SJ1PR11MB608310C72D7189C139EA6302FC212@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <o6va7b7rc3q46olsbscav7pla4hxot2g6xhctflhmf64pj5hpx@56vtbg3yyquy>
 <SJ1PR11MB60830E546B3D575B01D37104FC202@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <159474e6-ef11-4769-a182-86483efcf2a6@intel.com>
 <SJ1PR11MB60832DAD58E864F99A16FCC4FC202@SJ1PR11MB6083.namprd11.prod.outlook.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <SJ1PR11MB60832DAD58E864F99A16FCC4FC202@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVZOZDEvSjJxT3dyT2NQSG5ub2d2MEp6Q2VBeXZwcC9aL0RkM24xSGlaV1Uz?=
 =?utf-8?B?VHNZMGNHMk8zL3dKTmJJdnliUWYxUmJlYTJ3SHRpcTBMbzBOQWhHV3JxVTVz?=
 =?utf-8?B?S3huN21IdmQ2clNqNi84ZXB2S3ljbGRKMjJhRDhUdjZZeTJLWktZR2V4UXZt?=
 =?utf-8?B?SzZuRi8rZTJBd29XL0NNazQrcDRCZEZZVU93OFJzbzNHSHpyeWNNcE9seHdr?=
 =?utf-8?B?cUpiOTNUWFpCSUllYnRkQS82dlJqbHBQZ1FsNXZnWjA3cHl3ZkM1OXQ0L2Za?=
 =?utf-8?B?N2tWL3JZMkZvS0xXdENMWGcvN1htM3dFK2JMNDBUQlZibDVLWEt1TnI3dEJC?=
 =?utf-8?B?V2JUU2hMYU9DWXdMbnVDdnY5UmxvekdYUCtSa2NRMVhqY0JTb3c2dml4SHR6?=
 =?utf-8?B?NkU5L0ZzZmE2L240Wk9iUEhDY0tqVHJtWWpPb0Y5NkxnTWVnL3E2V3FvSGxZ?=
 =?utf-8?B?OWJNVDNnWWZSd2llMjNldFpmcDVGcWYzeGdrZjRjeHBQUHNLSVhvMmtjbTlR?=
 =?utf-8?B?ZVl4Qy9XWDY0Q2k3U2lRSTRkZlFlemhxNCs3MGh3NGNwVHVNdDBucVJHQkJp?=
 =?utf-8?B?WXF1OURvUWZtMlZVSWFUaEhGQi81b1hGTWtFR0J1anJZSkRXSzRZQlFDbDZT?=
 =?utf-8?B?aStHTGg5c3hTanl2QUVCZ1p3NVRRbjlkK3RpTXp0cFdUMFE1SHNzZ0pqalln?=
 =?utf-8?B?WDBtT0s0WCttNlFYRGhCM3V0c3NvNU5XblphcldRc1hCR3BEeHBLcmpFMzR4?=
 =?utf-8?B?UzBkN3RYdnhMdUtmWGFOb0I0T1FCOUFNZXZDUE9ibTRkWVRRMUNYY2tIZVJu?=
 =?utf-8?B?bVplMlhjY1Zna0ZycnlPKzRQTVRZdG9sSm95SDFPZDkzRXIwUTBnVmRQWUdx?=
 =?utf-8?B?OTVpYkw5UmduMllib2VsT25JV0M0L3kzWWJLcnlKcXUveHZyZkdqMkNQY0Y0?=
 =?utf-8?B?ZEJkZnpnd2xXSUVadjNRcm1TT0wzaWJjV2FBQnI2Nll5OEZFWi9lRnV3b1FZ?=
 =?utf-8?B?dXltdHJiZU1qemNMdmNtWlJveVJVMHRzUnlaZjRJRkNTSnFaNE5JNXVIcFd1?=
 =?utf-8?B?eXJGTjFxd1pGcDA3Nk4zUUxaTnp2UVNtNEdLMTViR09HcDErRitQRWxOZFdt?=
 =?utf-8?B?dVdHUzczVzZMSFU5ZEt1MjNwSHJ6SUR6UVhaWEhhYjhDc0VXeE5ESHk0amtI?=
 =?utf-8?B?N2dYRUI2TCtrbGhUTlduT0lZYTJyRlBpNHhuUlViQkg3VThLS0xzdFBnTHZw?=
 =?utf-8?B?dEYvTml3Wk1BK21yVWN2bmppekVVMHJ0d2UxOGpVMEljbEhQbFNTNjg1WXF2?=
 =?utf-8?B?VTVLYjB0R2JrVFVkWjFnTXFNMThoQ0tpT3RNd3QrN2M2L3ZKN3VjZDhsWTh3?=
 =?utf-8?B?ekpVa0NRSHFtZm5IbmdERjB6YUlDbWp6YjZhVVFoZEY4TnN5NVR3azNmemhL?=
 =?utf-8?B?SWdYVk1YWm5zQW5mc01BdUNQanV5enhXQ2FoNTh3WFVOWUtsWkp4QWZ4cWxK?=
 =?utf-8?B?dnlac0VzL3pKZWFQNmk1TkhqdGdiOTR3bkc0WHMxSFNRMy9JVUMwL2RLMnNH?=
 =?utf-8?B?S2txMnZxVzFTNmxZbnAwWnpKcklyVjhidkJkU1YrTWRLaElzVXk1dHpOM2FL?=
 =?utf-8?B?OFNDV0Q2ZVhwa2V4RGY5ZmVnT3FQYnRCd2ZDY1ZnVXBZVXBCdHNJUWxQYXU4?=
 =?utf-8?B?aHZKTmJyUGw1VGNDU1B0eS9qK2ZSbUhDM3VtWW00QVlkYTNJYS9FV0dablJj?=
 =?utf-8?B?THdGRVVuZmQ4UjZqSGY4NmZnWEVLS1pMbFhRb2FpWkViQmxVUDl1anUyZXYv?=
 =?utf-8?B?aUtpbDc2bVpZRnR3Nk5RREdtOE95YW50aFljR2o1bGtuZTMzVTdTUHJmNzQv?=
 =?utf-8?B?RXFJWDBkak5MMHpEMVluYmdPZkEyN1F0dFRXSUJPZ3dDRW1FWjJFN0ZWQm1Z?=
 =?utf-8?B?QndwTHpmVURTeE9CekFQcFJibGMrWmw3cG9EOGIrWnplYnBsOWZ2TkRsWTAv?=
 =?utf-8?B?d05ITFhTdlF6ZExrR1hFM1F2RVYzWDE2cjFKQ2tKMU5FN1VCWkRvOExGenQv?=
 =?utf-8?B?b3J2eFdBNHFRT1MwS3V3U3ZranFaLzU2czVyV2REM0IxM1FBN3kvMHNuWWRN?=
 =?utf-8?B?RStvMndzSWxyVGpBU1RIaDRKem1lVUF3VFRZK2ZCQ0t6aXA2cFdqZ2ZRcWhj?=
 =?utf-8?B?U3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a138e617-3d16-4993-24c5-08dc3ee027b6
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 19:52:44.0890
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AeqVyoG8RmF/wxUFGOvRbigyxWV2ZaSYKIybIV1I/EPW4K+TXhZ7IqhVtfYuaMdCxYZXNw70s/XHDw9P1f4nLmZ4LdBZGTs87DxNCLcbZYc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8479
X-OriginatorOrg: intel.com

Hi Tony,

On 3/7/2024 9:57 AM, Luck, Tony wrote:
>>> SNC2 enabled:
>>>
>>> $ cat /sys/fs/resctrl/info/L3_mon/ snc_nodes_per_l3_cache
>>> 2
>>>
>>
>> This would be useful. I believe "SNC" is architecture specific?
>> What if the file always exists and is named "nodes_per_l3_cache"?
>>
>> I assume that the internals of handling more nodes per L3 cache should
>> be hidden from user space and it should not be necessary for user space
>> to know if this is because of SNC or potentially some other mechanism on
>> another platform?
>>
>> I think that may reduce fragmentation of resctrl .... not having
>> resctrl look so different on different architectures but maintains
>> the promise of a generic interface.
>>
>> I am not sure if this is specific to monitoring though,
>> why not host file in /sys/fs/resctrl/info/L3 ?
> 
> Reinette,
> 
> On the name change - sure. It doesn't need the "snc_" prefix.
> 
> The Intel implementation of SNC has far more effect on monitoring
> than on control. The user can read separate cache occupancy and
> memory bandwidth values for each SNC node. But cache allocation
> bitmasks and memory throttling still have a single control point for
> each L3 cache instance, not for each node. There are still some
> impacts on control, e.g. each bit in a CAT bitmask represents
> less actual space in the L3 cache.

I understand the impact but I am trying to view this conceptually.
The info directory exists to "contain information about the enabled
resources" (as per documentation) and it seems appropriate to make
this a property of the L3 resource.

> 
> Maybe move it to the top level of the info/ directory:
> 
> $ cat /sys/fs/resctrl/info/nodes_per_l3_cache
> 3

Thinking about it even differently. The goal is to give information
to userspace so we need to think about what would help user space?
For example, what if there is a file in info that shows 
which CPUs are associated with each domain?

Reinette