Received-SPF: pass (google.com: domain of linux-kernel+bounces-96225-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <1709621888-3173-1-git-send-email-quic_mojha@quicinc.com>
In-Reply-To: <1709621888-3173-1-git-send-email-quic_mojha@quicinc.com>
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date: Thu, 7 Mar 2024 21:56:55 +0100
Message-ID: <CAFBinCC2n+Muu2qaAG0PWFj6f+bVFDtHnzm78jSpeodTD47TOg@mail.gmail.com>
Subject: Re: [PATCH] nvmem: meson-mx-efuse: Remove nvmem_device from efuse struct
To: Mukesh Ojha <quic_mojha@quicinc.com>
Cc: srinivas.kandagatla@linaro.org, neil.armstrong@linaro.org, 
	khilman@baylibre.com, jbrunet@baylibre.com, 
	linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello Mukesh,

On Tue, Mar 5, 2024 at 7:58=E2=80=AFAM Mukesh Ojha <quic_mojha@quicinc.com>=
 wrote:
>
> nvmem_device is used at one place while registering nvmem
> device and it is not required to be present in efuse struct
> for just this purpose.
>
> Drop nvmem_device and manage with nvmem device stack variable.
I'm generally fine with this approach

[...]
> @@ -223,9 +222,9 @@ static int meson_mx_efuse_probe(struct platform_devic=
e *pdev)
>                 return PTR_ERR(efuse->core_clk);
>         }
>
> -       efuse->nvmem =3D devm_nvmem_register(&pdev->dev, &efuse->config);
> +       nvmem =3D devm_nvmem_register(&pdev->dev, &efuse->config);
But this doesn't compile for me:
  CC      drivers/nvmem/meson-mx-efuse.o
./drivers/nvmem/meson-mx-efuse.c: In function 'meson_mx_efuse_probe':
./drivers/nvmem/meson-mx-efuse.c:252:9: error: 'nvmem' undeclared
(first use in this function)
 252 |         nvmem =3D devm_nvmem_register(&pdev->dev, &efuse->config);


Best regards,
Martin