Received-SPF: pass (google.com: domain of linux-kernel+bounces-96261-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 8 Mar 2024 08:34:15 +1100
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, Al Viro
 <viro@zeniv.linux.org.uk>, Alessio Balsini <balsini@android.com>, Amir
 Goldstein <amir73il@gmail.com>, Linux Kernel Mailing List
 <linux-kernel@vger.kernel.org>, Linux Next Mailing List
 <linux-next@vger.kernel.org>, Miklos Szeredi <mszeredi@redhat.com>
Subject: Re: linux-next: manual merge of the fuse tree with Linus' tree
Message-ID: <20240308083415.640fe691@canb.auug.org.au>
In-Reply-To: <CAJfpegstDJ6p42itTiL33tMTcbV8tUiMowpk8y9A-52_Oasvnw@mail.gmail.com>
References: <20240306103438.2c0a6f44@canb.auug.org.au>
	<CAJfpegstDJ6p42itTiL33tMTcbV8tUiMowpk8y9A-52_Oasvnw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/g9_.HsaUmrHgDCo/2OydX1z";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/g9_.HsaUmrHgDCo/2OydX1z
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Miklos,

On Thu, 7 Mar 2024 15:16:00 +0100 Miklos Szeredi <miklos@szeredi.hu> wrote:
>
> On Wed, 6 Mar 2024 at 00:34, Stephen Rothwell <sfr@canb.auug.org.au> wrot=
e:
>=20
> > diff --cc fs/fuse/inode.c
> > index 516ea2979a90,02869edf72f3..000000000000
> > --- a/fs/fuse/inode.c
> > +++ b/fs/fuse/inode.c
> > @@@ -930,14 -942,6 +942,16 @@@ void fuse_conn_init(struct fuse_conn *f
> >   }
> >   EXPORT_SYMBOL_GPL(fuse_conn_init);
> >
> >  +static void delayed_release(struct rcu_head *p)
> >  +{
> >  +      struct fuse_conn *fc =3D container_of(p, struct fuse_conn, rcu);
> >  +
> >  +      put_user_ns(fc->user_ns);
> > ++      if (IS_ENABLED(CONFIG_FUSE_PASSTHROUGH))
> > ++              fuse_backing_files_free(fc);
> >  +      fc->release(fc);
> >  +}
> >  + =20
>=20
> fuse_backing_files_free() doesn't need to be called after an RCU
> delay, so it should be resolved like this:
>=20
> diff --cc fs/fuse/inode.c
> index 516ea2979a90,02869edf72f3..000000000000
> --- a/fs/fuse/inode.c
> +++ b/fs/fuse/inode.c
> @@@ -954,7 -959,9 +966,9 @@@ void fuse_conn_put(struct fuse_conn *fc
>                         WARN_ON(atomic_read(&bucket->count) !=3D 1);
>                         kfree(bucket);
>                 }
> +               if (IS_ENABLED(CONFIG_FUSE_PASSTHROUGH))
> +                       fuse_backing_files_free(fc);
>  -              fc->release(fc);
>  +              call_rcu(&fc->rcu, delayed_release);
>         }
>   }
>   EXPORT_SYMBOL_GPL(fuse_conn_put);

Thanks, I will do that from today.

--=20
Cheers,
Stephen Rothwell

--Sig_/g9_.HsaUmrHgDCo/2OydX1z
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmXqMtcACgkQAVBC80lX
0GzA6gf/Vxq+7Mzj99etumHtukJua/4uk1o9kUr2YEea32sDW5UOT8gB2aFx8haf
b9GWfrfsPckpMaJbuM3BXO0NLE1ND0fYpDi2VEKxNTjxn13qQ6WNzDG4s25LnC75
h9pRCeuo9npau3B7Inw5TqdZxob5f1AKoFLBoP0eHjvXKjtdL0aSNCKp6UU2OG6Z
OWIdrc2Vk88bMnw+aqddZlUByVna+8VmxQXRXm8gF3it8twQepUgMR50+yemW9wv
l0JB98oXps//bGX8dKXc07PiusRFFNFbVQLCoxvOKb0yj0JDzFw/RqwKRqQsPZVQ
3CbvyoGUZk1rlgFb/fo1Zd9PvQBCMw==
=w0Ie
-----END PGP SIGNATURE-----

--Sig_/g9_.HsaUmrHgDCo/2OydX1z--