Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp168308lqc; Thu, 7 Mar 2024 13:39:45 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW7Ys/08+zugmGijHNXDsYDDNwIl5mZ8uOJ04w4P2L42PW8rxmM8YDqlZlgRMMnRPbbHlJ3YkifMouxQd7pjL7X4wiAzVyixWK2EqwR3A== X-Google-Smtp-Source: AGHT+IHHLTBR0V13kzIJlVbhGkcxjereznqDi7xEm08fTmIsPOqLoUWoW3HUoOLC4iMoLocOCWS/ X-Received: by 2002:a05:6214:180e:b0:690:a649:73b0 with SMTP id o14-20020a056214180e00b00690a64973b0mr2408613qvw.12.1709847585178; Thu, 07 Mar 2024 13:39:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709847585; cv=pass; d=google.com; s=arc-20160816; b=0jIEO6k5BcR7h3j2WmSC42YI40kK5m8attDSSziKh0GO0Hn32YGGZ0/f0hAlz1hXgI UgxoT5oOi6NymHimh/pLZjqvVV7XCkflgxG7E8UBFumeOKC40HnyN9qhyGP6F/zW6dgn e/0tqCjo1pDAV4TPfgc9t2JOv5Psx0CvB9w7biEI76dsPaH8h675xWcWYGkmHPirO18c FcQojMua2LL7nlEfOWFv0wRlkQVbd568/2wI22HIh4OWiGMaMngU6oXZwpg2qJNZnnKW Qhiz4pSMds/nRpGRpYYN9+6RfapiiWDfWU7uF+nhd5P8x3kOsvDblxnncXtdHGAZyfXh Iccw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=BDelgwvkGYVthFnRrgCIgoRm256CWezoNN1FPWb9kgE=; fh=M67O1s+bnrh20mgsqK0poc3ZsIH5EmsBq4aWtodaLWs=; b=jkeKt04GolcdSh2Y2QAxbsON4baEKrGHu1GVmJ2OgBQ4m2t0PtqRFjEMCrGleYXPhq 1B9TDVCsVR9LcKcmrj7RQmtlWefFZsjThB0O4SBxiKP1i1Z4D0VnU3BeHXQLSZykOOWL 8cJY+6NkRJPGia3JVXXl/6+TlF5k1rXNTwLFxt5QBGUUjK737C+fkBFwd8luLoVsYlJR fcp1QArtvRXdQBsMnh37CIc15Ov33UEbaHDqzk9IknISbyQOA/oOmFyORxMM2MzPHh8L +PJUJfBaikX7RKPlUclcmXlk+zQW4xFU7ppADyKg7gdNNLZSoNg4Vb3E4BfXmut26Rfk 17jg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EFElUopV; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-96264-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96264-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id pi18-20020a0562144a9200b0068ffe92039bsi17573039qvb.290.2024.03.07.13.39.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 13:39:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-96264-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EFElUopV; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-96264-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96264-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E5D1B1C216B2 for ; Thu, 7 Mar 2024 21:39:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B562413DB8A; Thu, 7 Mar 2024 21:39:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="EFElUopV" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE780634E4 for ; Thu, 7 Mar 2024 21:39:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709847570; cv=none; b=V2oJaEGBR7uCnYnfU8nVB3SsY24PErhZ1XjBD4dT1+mzhkj3uO9/A3S3Uw3qYVOvjYWHm+qwjvYjLSbZ1QiPxAF6Tc8NNmNlMgEMxVIaUmujvIJVIp6SfZHp93qSYtST71OquNpHDBPIX1Ep00wOyKGtRVZrW5FTdTB9HfwQaAk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709847570; c=relaxed/simple; bh=ZpdiJ/sHAU7UYJfeL4YOTYjxPWde8J9YeLVF9YbExFE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Phj2SA6/nVi/Dvni+1LYYmWy2qCoZhYIz3JUelbpyZXJlgkMCysuicF5Nu908nmicONP64NImQU5723CGlKwgnnhLTJfMDjhgBhBol/DGOl23CI5NJocYEDYL22dcUC6ccdU6p0AyL1K1q6XhsPUeRUmBsSqG7rKDvm8gKat4r4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=EFElUopV; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E92A9C433F1; Thu, 7 Mar 2024 21:39:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1709847570; bh=ZpdiJ/sHAU7UYJfeL4YOTYjxPWde8J9YeLVF9YbExFE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EFElUopVweKc9y+fagcMEr553mKX7cx26sPzJzpulDVemWcjZJ83VqbCwwm2ByNII NWufjEE0ZZZASBQAtxPbdbYnR4dXDn8RVT0m14xq7uut6BatBR0q8+or3SJp7Dz9LJ 8U0cYoBwzk3n1z6kYJEw9/OEWrKonFIBGLMRhiog= Date: Thu, 7 Mar 2024 21:39:27 +0000 From: Greg Kroah-Hartman To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, javier@dowhile0.org, Andrew Halaney , "Rafael J. Wysocki" Subject: Re: [PATCH v3] driver core: Don't set a deferred probe timeout if modules are disabled Message-ID: <2024030722-explicit-juror-9ba7@gregkh> References: <20240227231001.648698-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240227231001.648698-1-javierm@redhat.com> On Wed, Feb 28, 2024 at 12:09:02AM +0100, Javier Martinez Canillas wrote: > There is no point to schedule the workqueue to timeout the deferred probe, > if all the initcalls are done and modules are not enabled. The default for > this case is already 0 but can be overridden by the deferred_probe_timeout > parameter. Let's just skip this and avoid queuing work that is not needed. As the option is already there to set the timeout to 0, why confuse things by trying to tie this to if modules are enabled or not? And even if you do want to do that, where did you now document this new system behavior? thanks, greg k-h