Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp172409lqc; Thu, 7 Mar 2024 13:48:40 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWd+7l+vxwrrXknIIMvmo2j879thFwY4P3N1u2hcDVV23O82rrKt0n0VaaC/XnHPRMXclb07LwQ+pu3LvNUlgvNcdaMyE8z8Pr/IOyESA== X-Google-Smtp-Source: AGHT+IE99DvmOA6IfbCv3b28iFBugLfMC6Z2vb653lHs6IX6Iiz3hEmmBg0W7BNbewVWAspPXlHv X-Received: by 2002:a17:906:ad89:b0:a45:5109:5206 with SMTP id la9-20020a170906ad8900b00a4551095206mr8776119ejb.64.1709848120485; Thu, 07 Mar 2024 13:48:40 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709848120; cv=pass; d=google.com; s=arc-20160816; b=VGCcTGuPqA3YRvEr3xIXtj0vtK9P85ad3NvfI9iyo9lMLXvI7TJE4Dbh1jYzQOcK2P 8jwpim14iWUyF0teO1QbRqUUvhOtCeChljyBb7QpRR9M1ThKGGA30QvIal8vVO2d+WTl 2AYfTegKEJF1P1c6jVqtDLa7yxQYxm9eaS8rrd1TujiFPfqw1ClIbNQ2ABW13g+XYcMl ZqzSgzHCcZT2ZXSPGhrAiBC8UYVDkbwl8WdSNAkOZbhIuLr8/xyzTAzDloAV7D4kTaSS ZwwvNS8YIYwQJl2bEAPpUlnKrU9HRgS7Gs/YzDtdvQv4MvGw7zvq/fly1D/aI21iUM+G e/Xw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=kSc+0NWNenKNnnjKmdcMqJ+k1feaiVQn6i33PqyK5xQ=; fh=+xdt4pPlbuKG5W6lomlvr2pHkM9qi6fYtCUu/2/XUcQ=; b=Lwpj24nRA7RttMc6xZ3Szx8bYsvHjfK5oeRHIleIh1aD2D7GqLtN+PtcBoUij72dV2 AgShh2e+wjFcPxvIvL8Q6d9wvkvw0wvVeGN3Ks2MNtis3ldQM/tsyVdettZVrmEYt1Fv 6QO6ot/gPFgiiVqu9DiIzCzePL0lmCRwuZXdZEZyuoJMkS29OGifc4WLIx+YSwekDloz adt89klP9smIimmiQEx01kbPN3AAe0CSF+HxJTXRKnJJ1YSrxDNDGHAccop05MpGLvU9 8g3Kyp5LwQ3U4vayDy5/TXNbMWypodYGQR/yQ+504Ab5NSOaQ9rsSoOczXp6+Bt52RkJ 59fg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fE8La19P; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-96289-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96289-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id qw42-20020a1709066a2a00b00a413e285dadsi7171554ejc.334.2024.03.07.13.48.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 13:48:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-96289-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fE8La19P; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-96289-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96289-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 0AECE1F211E7 for ; Thu, 7 Mar 2024 21:48:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BDA2213B7A4; Thu, 7 Mar 2024 21:48:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fE8La19P" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88EF31CA8A for ; Thu, 7 Mar 2024 21:48:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709848111; cv=none; b=NHhEP1xmfjys94Pleh6T7Dsd5nByYawxXAfvgNlT+oEPliIjRbpUK/+ZRRTTr7oY/Gc1SofcW0FQolxFdpOTu7QFBdJ/1RID/BipZgTqraYgKWZ5f98BvaAXaTaFd8mDfqwgk1bRJIjWqsetZ3Ax+bGPJFttAk4tYsHT0VdSxv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709848111; c=relaxed/simple; bh=IT2dpYQ6uHucwWrvvg6K56c2aMW3hbQgLU4g02htMiM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nUyYKmoPp3XJOrbwTPyU6vi7bDUPCZLfBC3vRL9RT5jalrGrhLWiVratoXMTLAhsRPSAVnkhtQYQQdjzH8YouBMUJwLUYHsGJI7pNuBfYAvKfjnjEQZFYQsKqPun2g/V/G1XwCn6i9hQAaLs8U7QBevGj1yxAyGxvjg/icWoNhs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fE8La19P; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709848111; x=1741384111; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=IT2dpYQ6uHucwWrvvg6K56c2aMW3hbQgLU4g02htMiM=; b=fE8La19P6SKL2EiPo7LeeecT86V9BURVbcuqwaT/W7ft1skBItH8eGSS J+ywZq5i0IvNPb4DZwyEo6lmViNHceCvXdLWw7wqVjpc9k9VYm8dpjWDI IVe8A3LkOwpEmk3oZgVJHWQchtAjplrCiGY81Ge0qmdQD6xvWL59fb4MH 26wJyxWbD9s/z3qPX7pTSb7R1OlwKcT4YeE7c/BZc2/iURuAxW4khWAwf 0WD4vGJuGKVG4zNvbYOm6NPZDNF1yQb3Efqb1RrSKRyommYR3ZtzEceF6 7CIT9PaNqpCALimY3wzLnUqYT3b0c1CoFw9/U+dVOqwwNN34ohxvK29aa A==; X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="8306857" X-IronPort-AV: E=Sophos;i="6.07,107,1708416000"; d="scan'208";a="8306857" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2024 13:48:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,107,1708416000"; d="scan'208";a="33398194" Received: from yuqiangu-mobl.amr.corp.intel.com (HELO [10.209.57.176]) ([10.209.57.176]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2024 13:48:29 -0800 Message-ID: Date: Thu, 7 Mar 2024 13:48:28 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 2/3] x86/mm: make sure LAM is up-to-date during context switching Content-Language: en-US To: Yosry Ahmed Cc: "Kirill A. Shutemov" , Andrew Morton , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Peter Zijlstra , Andy Lutomirski , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240307133916.3782068-1-yosryahmed@google.com> <20240307133916.3782068-3-yosryahmed@google.com> <034466a4-0917-47c4-934b-9549c3076624@intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/7/24 13:08, Yosry Ahmed wrote: > CPU 1 CPU 2 > /* user thread running */ > context_switch() /* to kthread */ > /* user thread enables LAM */ > context_switch() > context_switch() /* to user thread */ > > In this case, there are no races, but the second context switch on CPU 1 > may not write CR3 (if TLB is up-to-date), in which case we will run the > user thread with CR3 having the wrong LAM mask. This could cause bigger > problems, right? Yes, but this is precisely the kind of thing that we should solve with mm generations. Its sole purpose is to thwart optimization where the mm_prev==mm_next and might not rewrite CR3.