Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp176211lqc; Thu, 7 Mar 2024 13:58:27 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW6OkpCw+5SMH+qc7mUaAp8a0dHjoyoVl0FL0KTfgA6bmINVeQyYEBxiDWnOvT/ZtvE1uwtmsmZ7Ub342EPNPldETgVIl9Uy9Oh5ij7aw== X-Google-Smtp-Source: AGHT+IFataDxQOVcqFEREiUKEnggD3GAYcstXqAXc+TINN9me9jD7ausLwBjpNNN80Q9rpAe9t3X X-Received: by 2002:a9d:6298:0:b0:6e5:3a9:2243 with SMTP id x24-20020a9d6298000000b006e503a92243mr5615151otk.14.1709848707701; Thu, 07 Mar 2024 13:58:27 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709848707; cv=pass; d=google.com; s=arc-20160816; b=CgOGXRKsYR0rtK+XZ285kjai+uUvFTdNeLWLOjAPtVcAcWnS7QIynnfN8r2TqQyWVW UJ0FiN1VZkjQbdtgnk/KO4955Qqh+bwLHN0azXZjt/HdJ975iugVB1ylrWhL2KCWMe0b mFP5UHA88bfyht4ya3ZoFXreRfycvVsXggT9AbE9WbBeimzoePouMD8jeQrmh0K/HOGr fIMFuNgdSr1wSy9ID3dQS2Ky51wCFIwdVTUtZ79clVIMGrVF6tjG+kMzIVW0W3Nhk1XR z/fyGxqFBCvs9FZzNwlvtX+O3e2tU+ZaA0+LtXqfyKtXB3cy6gDxpMnHDvCUrPk9GkpT boqg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=nve+txUCb6/p6BuRKeBqjuiMwi/fXHmUqeZkkBDQpcA=; fh=dmwsidUj6afV/yMQJW0Dr1L0Xk232DSaxtP3Wt+ASw8=; b=pWsIffbSvMhuMgqxeL5P2vByoeYx/JEYc6uG5sN/aL0sbhp+VsZEuR7dykkw7K8osi sSkiI5lGg5Vg6KMVuBJgl9DfFbXSFxZpkzHgvsqL59J9qYgpmGl4DAXI1TSipbh0+m8k 7odNkgFK2GkIadU55vD+zeNN8a5IAkSXSR82DZ3vunoMQCvTZotNsEvJyoKYREXMKaUn /NDTV8i8h4CKdGuEMFqYyG7I1S+Xnz9C9tVXp5Iwp5Fy/S/0wb4+bfqKja4L0i0i04vp CM5EGElGOAk8EdyIR0rQxiAzCAw0InsDPbT5O7fsut5fQK/OynKj6pp8D3XCkmKzD7/y Kyww==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IOHVjV8i; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-96290-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96290-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id k16-20020a63f010000000b005dc89485b21si14399907pgh.535.2024.03.07.13.58.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 13:58:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-96290-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IOHVjV8i; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-96290-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96290-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 0F8E2B21E7D for ; Thu, 7 Mar 2024 21:48:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 653811CAAD; Thu, 7 Mar 2024 21:48:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IOHVjV8i" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 787B71CA8A; Thu, 7 Mar 2024 21:48:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709848130; cv=none; b=aeg0B7ub9/VOargiu4N6lgCuVvE4f3CUE4rL+hFVE2S23DllWcNZCB8fb+AIObXn8PR6g8pbJ2jIp+deiiRXZeVBCAlDyIZ3ySTqx8wfwQN7k/gn8B18VGGbS84P88GOl43zRvDMzIDqWcxpbj0cXlMugi7K2GYMLMl8F8uZOVI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709848130; c=relaxed/simple; bh=vLs9m6gRf8Snl4inPBLyLLfxA3kwLZa12Mi7NvvO8R4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=W39CNklIORVvo2Qqtkf8fA3jGYR7F3jt3A7f/ADlI++gQjcCfJ1cgVKaiufV85rCl83pGWPnKPrwEDDfTGhgrNyIxuS6eY2LjL5SNFRuFtAZtGdGtG09P+jqsgIGLy2NVV3JkNmkAmMKq+TKQxeNfiuuR08nGqfn0xjyoJIkbik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IOHVjV8i; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A0F7C433C7; Thu, 7 Mar 2024 21:48:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709848129; bh=vLs9m6gRf8Snl4inPBLyLLfxA3kwLZa12Mi7NvvO8R4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IOHVjV8iznlznY2XzPlCiYQx9hT9NmkmBVnxipkHZ2zKbpIoNDIzRTfyHy5loCqf/ KEpYHru6GiLS9bbkwqx1G1TfNolMBN6qHiZ2UoIbyME351CN0CaFCbJw4wFaGZr+ua GclbUHC1WHuJ8AYppEyZWRPJnVOk0b2bK0upHeassP293vjnUkma4BoHl/jtSVDY6o LJ7JaMN/3xGzOf6zEIEBR3rpj97pd79imifmo1oaTbWEyy3Hqa5C5HuV7qsRxqvPX3 3hpKsRXNbawfmgDUBNk2kijSs0uBPjojS8+YMA+yy03vTO1i0RuS/YgCPiPET7qJJY VkjSEh+rLAPlw== From: Namhyung Kim To: Ian Rogers , Namhyung Kim , Arnaldo Carvalho de Melo Cc: Adrian Hunter , LKML , Andi Kleen , Peter Zijlstra , Jiri Olsa , Ingo Molnar , linux-perf-users@vger.kernel.org Subject: Re: [PATCH v2 0/4] perf annotate: Improve memory usage for symbol histogram Date: Thu, 7 Mar 2024 13:48:46 -0800 Message-ID: <170984809560.445746.8499697523973754680.b4-ty@kernel.org> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog In-Reply-To: <20240304230815.1440583-1-namhyung@kernel.org> References: <20240304230815.1440583-1-namhyung@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Mon, 4 Mar 2024 15:08:11 -0800, Namhyung Kim wrote: > This is another series of memory optimization in perf annotate. > > v2 changes: > * fix a bug when offset is bigger than 16 bits > > > When perf annotate (or perf report/top with TUI) processes samples, it > needs to save the sample period (overhead) at instruction level. For > now, it allocates an array to do that for the whole symbol when it > hits any new symbol. This comes with a lot of waste since samples can > be very few and instructions span to multiple bytes. > > [...] Applied to perf-tools-next, thanks! Best regards, -- Namhyung Kim