Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp204726lqc; Thu, 7 Mar 2024 15:04:38 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXAwMc5CnVnqvSI/vV+DaKlXK5PulW0hkFt7Y/afRVTtXrTgR4MEo4mL68ss/qasrf9saIU1zv2B2+7Eh5l2rJuEAtFgqGYrfjPfrhbEA== X-Google-Smtp-Source: AGHT+IGhvDC+7x2i9gcNCjlyugdGsMcoL6ZgNYx9u/9zie87HI6g33XsMVTQ+5oymDUeYhW9mmpR X-Received: by 2002:a05:6a20:9381:b0:1a0:f7d0:e651 with SMTP id x1-20020a056a20938100b001a0f7d0e651mr10808908pzh.26.1709852678694; Thu, 07 Mar 2024 15:04:38 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709852678; cv=pass; d=google.com; s=arc-20160816; b=M/gnHqvsL0R5BxYY3CTAtuVesHm9jf3GPxiORJt1aECzOD9NYVpcuWyxEo65/gHzl2 7R9ZImgbW+OEK4Bcg/zfyKwJ5P6VKWO9nY4gyJ33553Z0TDy/Wp69lRcLSx3VXWysa3K aiGKNVuWtQ7+BGWY0aNgnGH22I/zdl8Ol1DmHk6Hb45EfHfelWU6YAjFkcKNomW6c7Vf CXJZNWtjfclHP0uWlA0gf4bIC1z7Pkulg3Kfq/ics7bydbXVgCivrlOipd2/4QvtaSuY JVSGNJ0w+DJ3USQNAX31brqCvOYE4sLY15twy0z39S8MEqJa58pB7gSZQQRtOkBom1zO /4bA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=SyVFVWGeYOgZdt+w5Sk4N4IgvD9msdICZRuBNc48csQ=; fh=1q6TAyv4+uvoD05zXfUVZypl5VRTDyuHf/QdNJKZINs=; b=mtOqoNW//8HCGWoSiZ6NICfvb41hxXotzbgAcU/+DIwRm+e8Km8Wlc3aJ7ToeBvCF6 sGF0p0zogbeqQRDz2RbnSCzYjKorAKYr2FFLhZAFOoVBjwvYYlB8LGxDvNsFxzprlWVN K1vL6J7U9uxNWwWiF7Yeb5yGonfiA2OlQMLf7vUGFKL3Yth/9z1vnsqrN29UO0KUIdxp rpy/wjktpO7CV9ORIe9jLl8d4npX6VCphxJmi6cqoaC7IqJ39Hhtlq7fhxkFh/hH4s04 gZPodgEuD7SFtGxptNBVt58qXNK6VqINskZO5RsFQFjNwKOP+TXv9JM2GJ2JsdKs4+3H qSmw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QpEsJGHq; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-96345-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96345-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id q5-20020a056a00084500b006e4e39170a8si15330747pfk.129.2024.03.07.15.04.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 15:04:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-96345-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QpEsJGHq; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-96345-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96345-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id D4FFDB2269C for ; Thu, 7 Mar 2024 23:04:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 614FB3E480; Thu, 7 Mar 2024 23:04:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QpEsJGHq" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73423335C7; Thu, 7 Mar 2024 23:04:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709852665; cv=none; b=At4Fv/gSby+sT25P1jlIpDwBEv7EBItZHnHu6fz773XMCOCPxL2QeDulZMOkNXRiB3XnZFhAGwvBj9kUoIWJir6QZiOG2NORIe2/cIFjeaI2y6YL5l1bLB5fRYoR+7lI6sHVstzZpIp223YEF2BpVMo+kRWo8DxtLkquIOszTwg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709852665; c=relaxed/simple; bh=DbczkzaJ/zVwOH/cmYk5kfCegYn64EBBaWeS225JXyo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RqMEom6h20wE1TQZLtUoik3ne74NYlciZToTamG3OdDd/1ifZ00F1h8nl3aTaCoiCbPDKa62L/UsfmpXOdoicuykg2ARhyFp8YBcNSH/F29e5OC2n38AHgVIQN/wK9y6ge4IyU1VxGKIWaOpN3lb6UyoVW9AJ6kSKRwCptBIiXs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QpEsJGHq; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38828C433C7; Thu, 7 Mar 2024 23:04:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709852665; bh=DbczkzaJ/zVwOH/cmYk5kfCegYn64EBBaWeS225JXyo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QpEsJGHqAnxaZYLi2aIxnNiD/GovnhqIBT4sBgW3fjYxnD1poGQHNV8tyfilWxkys momRdp2cmFgTmMsEeDXVlGcbSFmRIawDyouF9mMm/uZZIPU15QCWlvHFYu+858FNyE 31LLmPXgSYMnvCTRo3q86qAxCC1NP+BbjNZJC/0GbHdOuHZAlhSfEATlHjMxMnv9rH 5rocXxA4u6nRiji+n0yqVRC/goIdrtEllmsU33HXt0dOj9xTrAZIZF82684iRd/43K lECfPybYr1KT6SZjNmxdgYBvip85ZReI87Fh9Dm3z/YVK+Nd+Yjmju6L5bFkpy3MnG xMdRaAHRL9z7Q== Date: Fri, 8 Mar 2024 00:04:21 +0100 From: Andi Shyti To: =?utf-8?B?VGjDqW8=?= Lebrun Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Gregory Clement , Vladimir Kondratiev , Thomas Petazzoni , Tawfik Bayouk Subject: Re: [PATCH v3 04/11] i2c: nomadik: use bitops helpers Message-ID: References: <20240306-mbly-i2c-v3-0-605f866aa4ec@bootlin.com> <20240306-mbly-i2c-v3-4-605f866aa4ec@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240306-mbly-i2c-v3-4-605f866aa4ec@bootlin.com> Hi Theo, On Wed, Mar 06, 2024 at 06:59:24PM +0100, Th?o Lebrun wrote: > Constant register bit fields are declared using hardcoded hex values; > replace them by calls to BIT() and GENMASK(). Replace custom GEN_MASK() > macro by the generic FIELD_PREP(). Replace manual bit manipulations by > the generic FIELD_GET() macro. > > Reviewed-by: Linus Walleij > Signed-off-by: Th?o Lebrun Thanks! Reviewed-by: Andi Shyti Andi