Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp206068lqc; Thu, 7 Mar 2024 15:07:19 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWUp9o4k9V+XuDMoOz/i7edz8dS/u1sHja05ocpo01BXrielD8mxNRXdEuNi2nnebkLkDVBwApJ9sjANDj14XgfRhtTW+KDPlt3iD9kmg== X-Google-Smtp-Source: AGHT+IGQ8rdVPHAB5TT3fa082efp2sA6ilxbnyWeY3FUKvRZaTp4XM9lqpsto1UZgMe1dZBgDUYO X-Received: by 2002:a17:902:e5cd:b0:1dc:c8b3:9376 with SMTP id u13-20020a170902e5cd00b001dcc8b39376mr4455461plf.7.1709852839522; Thu, 07 Mar 2024 15:07:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709852839; cv=pass; d=google.com; s=arc-20160816; b=t/nAdmgymzyAv/btHuJpVnBwR4tF4kuJXNTbxpj4aeXMN4vtn6hh7AC7U5yehUHsF5 ofkceo5VlFCu2ZU2gvHlZGhfuXakdLrEs2gWYq6F/V1vQSzaNpiX/Fv1YP+JwXDT9pdQ a9MhsNkQvjSd7DRRzqNk+a8a9MlUnFIODi6H9rjUwH5YO6I5v7blpeVKZI0iszK5THtD gxHxnhIIynWPbNeaIdu74Rmni2FeC4WE5aKfm++UvKqkOEPY7ZFi9RwKNCTA2IBBCxtV OGI4ak70xs+0D6G5UEpEPh/YLemf8WKmgFufGN17p/k33t+AhDc55Up6/m3nzi3adtDp I7Mw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=fIrQUN8C9fzYtTIw8RS3g9T/g51KHmtZ7730AB0M2YQ=; fh=1q6TAyv4+uvoD05zXfUVZypl5VRTDyuHf/QdNJKZINs=; b=qxLtQHvULr++JlNzeOmGtlWEYsRGqTxeEyv1QGoU/zbR5iZn4r9E+qsv2r5qquXAyJ pr0tCALBZ4pmx7cGjDAiIaYe99l3iIL1+IQAlUioAktxyDO83iA3Ns2fnmx6NAOpG1MN a3YNMib4DJQIJGBHoGd4aoQ7L3A3UBwUgkL/nMcnqUON9eIACezvcBAHGKelwHKt4mmJ kAs7Qt7WAKkfqzWEFpWio1S3ADX6PiOuqjW58TVFYhMRQSs5b9/mev+6gRYJkZnBtXqP vL1Xys0CKF06Pg6D/HifPGagxdNmmgipf5wPFnt548/d+7/sG+0sH4cKhd4WMg3AqDHn IuSQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=D7dWJ8Jt; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-96343-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96343-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id t20-20020a63eb14000000b005ce030a6460si14256276pgh.71.2024.03.07.15.07.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 15:07:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-96343-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=D7dWJ8Jt; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-96343-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96343-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3E26E285B06 for ; Thu, 7 Mar 2024 23:02:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 073D33D971; Thu, 7 Mar 2024 23:01:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="D7dWJ8Jt" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26EDE2E648; Thu, 7 Mar 2024 23:01:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709852513; cv=none; b=LwSsYurjFtpZkI4eLydg8n22IaYUGBy5ukGJJtekSqgnTSuRGErmQjJrMqjL9jXGComtYWbD1j5QWkyS9XWZycOv7AexmHRjGUXYmy+U7AmkhoOrggfF2p1zkKvurBaCfhLkz544F8gBLkrAgzcPYontB6V0nBeMb0JUV07hzcM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709852513; c=relaxed/simple; bh=0hqvHXQQQ1UnxgLlDX491LTxX6udHCE+N7qDRGzdko4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EBIwBXha7ayAbotjJDN0fLDaX/7EAf4ISyAkE+ORyLaooyIIYjUGUaZvVeaLdveNTmSkV+TzXsuFkedZ3wu5+32mkXduCk1EcN/aejqWXPgf3MUM5/MT+vEhSsiO9nUU0etJmukVEg+DFrOY4vs46PegqFCIchM5nWxmNLImC9U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=D7dWJ8Jt; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3E3AC433C7; Thu, 7 Mar 2024 23:01:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709852512; bh=0hqvHXQQQ1UnxgLlDX491LTxX6udHCE+N7qDRGzdko4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D7dWJ8JtvJ8KR5QUwO7a2OgaqrnQlT6HofqesfVT8+srYHJdjV0MUl52OZ9iZ5Fka ok+g+uVsnFzg1Xi3sqayWQoyBJkSlpl2ccxR7ag6rX13otSglmIchKZVxg5tiAPzYI YLYnoEAAyzVxj3K9/wcaCJoW2Q+xDQjC+4IHns8Omv/vXc4J4WHCv0CNG8vLNwDAsw 2cHwO5hIUoEV6LeCn/S9Gbu2zT9j9TFZHH2Iys37xcc4zQRVAZLazhmRDuf6+/lX4y zmVrw0Dg0tgGZA83h4yX6zBIgVl5So20xlV6T2VhLntm1J6e+iiTOOAiKlxRcmnAJe cLofJKwgiozrw== Date: Fri, 8 Mar 2024 00:01:48 +0100 From: Andi Shyti To: =?utf-8?B?VGjDqW8=?= Lebrun Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Gregory Clement , Vladimir Kondratiev , Thomas Petazzoni , Tawfik Bayouk Subject: Re: [PATCH v3 03/11] i2c: nomadik: simplify IRQ masking logic Message-ID: <422szb2dtgnq56xznfqsqtqs3dai2jipnntrp6yb2og353whs7@g4ia5ynnmqu6> References: <20240306-mbly-i2c-v3-0-605f866aa4ec@bootlin.com> <20240306-mbly-i2c-v3-3-605f866aa4ec@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240306-mbly-i2c-v3-3-605f866aa4ec@bootlin.com> Hi Theo, On Wed, Mar 06, 2024 at 06:59:23PM +0100, Th?o Lebrun wrote: > IRQ_MASK and I2C_CLEAR_ALL_INTS both mask available interrupts. IRQ_MASK > removes top options (bits 29-31). I2C_CLEAR_ALL_INTS removes reserved > options including top bits. Keep the latter. > > 31 29 27 25 23 21 19 17 15 13 11 09 07 05 03 01 > 30 28 26 24 22 20 18 16 14 12 10 08 06 04 02 00 > --- IRQ_MASK: -------------------------------------------------- > 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 > 0 0 0 > --- I2C_CLEAR_ALL_INTS: ---------------------------------------- > 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 > 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 > > Notice I2C_CLEAR_ALL_INTS is more restrictive than IRQ_MASK. > > Reviewed-by: Linus Walleij > Signed-off-by: Th?o Lebrun You did answer my question in v2, thanks, Theo! Reviewed-by: Andi Shyti Andi