Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp217726lqc; Thu, 7 Mar 2024 15:33:05 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVkbSeXp5KtpvEIXgih3PP5rvbUGt811W5e2rxxQNpLAme41a5ehgvruFIYX9xTEQsZNICAtPTUmRFrqja3aLlgP1XxYrl63CM1MLjYVg== X-Google-Smtp-Source: AGHT+IE1X4j2Itf9IYdQ2SQRrtuB8PZV5rIVpRgLONQT5QFuXBs/uTnRU9+H1iO9VEV/y4APbbJJ X-Received: by 2002:a05:6358:a08b:b0:178:f895:5978 with SMTP id u11-20020a056358a08b00b00178f8955978mr11837640rwn.10.1709854384704; Thu, 07 Mar 2024 15:33:04 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709854384; cv=pass; d=google.com; s=arc-20160816; b=Utc+FMue06Uhf6qth3OaxDBXdrZHIVegcWSmP0YzYjJQyoMgJMc1FMbWJDJ3Jlav7x rhaRhvzeSgf8ho14UKRA5lyfFqosfK0YKKyGxFqvQjZ2l8TRXCca6fdxixY2kr/vuEBi jRgQcpbrvk7eoJVSP5PT57uiLlOCRwJdsZ/3/CtmZpUTBrtrM54NzB54H1vmPysWQ6Ye Fb5jA07qonCSgtdUQ1WTWiW1RCrW4vPCOPS9kh0UWkgFSRyF0g9EyTJywtyTYCoYi/0E mieiLIQFVn1WsVRiJJmzOJSoOHPoi/LR/ydKJhh4VKhaxCvXc19x/X6GhWgJBcgYv63p U/Sg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=orF+Y6MVULpvTwTR0kycuhppErBSc05oAiIlRgNyDI8=; fh=HeZwqDCJVG7TajVbCDA3HYmILM39hjj2ewLAP/guWP4=; b=bkuuhmb0zKUtFHBmdiw/8t4caIVQQfttFxEdhj2nEFd1r5/rL1DVH0SvzNWZdoaqwW tUSftZxbpdhPnUgGFx0/99a5lcpP+Wf1uPbVXSscByPK7jMeZLPx+BXc87rNjlcB6Yyf QndJWRNp8uX5VJogQZIB2X8l9mafNoGRpDloIg+hAyDYnnqmMZJPivs4vycA23Ng3opp Map1tvn76fM4qdhjmX2Knpv/8AXqzb3RJAENL91ohkfYVA2ZHRV28Ymyj2sopuRoO3vt hJnm0Mce9kWZNosOg2vswStP28ipyP7KlQTgeireAhAVpNGb9Wj3wAK+5f/+C4BC1iCx JsNg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=J995aJjG; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-96365-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96365-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 7-20020a05621420e700b0068fcd9c3506si18198179qvk.151.2024.03.07.15.33.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 15:33:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-96365-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=J995aJjG; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-96365-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96365-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 263E21C21220 for ; Thu, 7 Mar 2024 23:33:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6034844369; Thu, 7 Mar 2024 23:33:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="J995aJjG" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68C541E86E for ; Thu, 7 Mar 2024 23:32:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709854377; cv=none; b=T2FYY2ozwGyDNJwO1oxNqzLmrxOM2c5wp2Fl0r4rF9fKlRUWFHu9TFJIK2NdAalJIUBa9nFxlOwdYYYcm7iXoN4rWKKvRxOIvxiCzNYaCm/gr11iAX3p5SMpFVVDXnCi2ntl5E6JknZyH/9IgNU3biiMwnH78F+wn1xSw68HqQk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709854377; c=relaxed/simple; bh=wH1fAGWkx3PuU6bIlC2l6H2WIIxDNfblOEri3RuZAOs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RxRcDQJn3PTWQrX4Piw89q1INORibAeM8Wq6IYCTv2OABASUCWuTvvaDCBKqcpMrVhLsL/5FHh0MPQf25+lEbiUXGTshE7dwWT0MHju7bY1kk0U1mUloYKaDfYyTMZWv5avRfT2Qv7P+CLTu3yhsYpLKkLP4lc6vIFFpMPeNlBM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=J995aJjG; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709854376; x=1741390376; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=wH1fAGWkx3PuU6bIlC2l6H2WIIxDNfblOEri3RuZAOs=; b=J995aJjGfZYD5KhqMy0OJB7zAB9+LZWRhX1Q7m/O+hn0dD9DKuzroabi AJ1WhZk6tf7vL7FsfFIZbGhY1HIaN5yyeh0ZbXxrsBgSfUqlEtv0vmSGl s/zBig2QYnTNNNrDIsaZtgD6R2CHK1YAaHW6Gb6gf+JovYtyJq2+JUb7a Z+fyAvcTteQiam+aISx9oGx6j1EkKpFOn7TdVP3gREwyACvVLWpsU9vR1 6wfAKntryf3/RUDThj1GPzz5kPZAhhQam5GDRqvB5gCCL9EwAe69kpmzh LWoA0VjKXtLsMDIHyONXYrxxwR8QXXi5UYNIdiX8Sk0pl3Y1uiHqST4mb g==; X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="4486041" X-IronPort-AV: E=Sophos;i="6.07,107,1708416000"; d="scan'208";a="4486041" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2024 15:32:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,107,1708416000"; d="scan'208";a="10373761" Received: from yuqiangu-mobl.amr.corp.intel.com (HELO [10.209.57.176]) ([10.209.57.176]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2024 15:32:54 -0800 Message-ID: <56ea29c2-8545-4689-a418-eb7784613650@intel.com> Date: Thu, 7 Mar 2024 15:32:53 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/3] x86/mm: fix LAM cr3 mask inconsistency during context switch Content-Language: en-US To: Yosry Ahmed Cc: Andrew Morton , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Peter Zijlstra , Andy Lutomirski , "Kirill A. Shutemov" , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240307133916.3782068-1-yosryahmed@google.com> <20240307133916.3782068-2-yosryahmed@google.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/7/24 15:21, Yosry Ahmed wrote: >>> The "set_" naming bugs me in both of the sites that get modified here. >>> I'd be with a new name that fits better, if we can think of one. >> Is it because it's not clear we are updating cpu_tlbstate (in which case >> I think update_cpu_tlbstate_lam() is an improvement), or is it because >> the function returns a value now? That's part of it. >> If the latter we can put "return" in the name somewhere, or keep >> the function void and pass in an output parameter. No, adding a "_return" won't make it better. > Or we can avoid returning a value from the helper and avoid passing an > mm. The callers would be more verbose, they'll have to call > mm_lam_cr3_mask() and mm_untag_mask() and pass the results into the > helper (set_tlbstate_lam_mode() or update_cpu_tlbstate_lam()). Another > advantage of this is that we can move the READ_ONCE to > switch_mm_irqs_off() and keep the comment here. One thing I don't like about set_tlbstate_lam_mode() is that it's not obvious that it's writing to "cpu_tlbstate" and its right smack in the middle of a bunch of other writers to the same thing. But I'm also not sure that open-coding it at its three call sites makes things better overall. I honestly don't have any brilliant suggestions.