Received-SPF: pass (google.com: domain of linux-kernel+bounces-96389-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 7 Mar 2024 16:20:15 -0800
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mathias Krause <minipli@grsecurity.net>
Cc: Torsten Hilbrich <torsten.hilbrich@secunet.com>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Nick Dyer <nick@shmanahar.org>,
	Brad Spengler <spender@grsecurity.net>,
	Sasha Levin <sashal@kernel.org>,
	Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: synaptics-rmi4 - fix UAF of IRQ domain on driver
 removal
Message-ID: <ZepZv98s4cHR24E1@google.com>
References: <20240222142654.856566-1-minipli@grsecurity.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240222142654.856566-1-minipli@grsecurity.net>

On Thu, Feb 22, 2024 at 03:26:54PM +0100, Mathias Krause wrote:
> Calling irq_domain_remove() will lead to freeing the IRQ domain
> prematurely. The domain is still referenced and will be attempted to get
> used via rmi_free_function_list() -> rmi_unregister_function() ->
> irq_dispose_mapping() -> irq_get_irq_data()'s ->domain pointer.
> 
> With PaX's MEMORY_SANITIZE this will lead to an access fault when
> attempting to dereference embedded pointers, as in Torsten's report that
> was faulting on the 'domain->ops->unmap' test.
> 
> Fix this by releasing the IRQ domain only after all related IRQs have
> been deactivated.
> 
> Fixes: 24d28e4f1271 ("Input: synaptics-rmi4 - convert irq distribution to irq_domain")
> Reported-by: Torsten Hilbrich <torsten.hilbrich@secunet.com>
> Signed-off-by: Mathias Krause <minipli@grsecurity.net>

Applied, thank you.

-- 
Dmitry