Received-SPF: pass (google.com: domain of linux-kernel+bounces-96449-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 7 Mar 2024 21:23:56 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Kassey Li <quic_yingangl@quicinc.com>
Cc: <mhiramat@kernel.org>, <mathieu.desnoyers@efficios.com>,
 <linux-kernel@vger.kernel.org>, <linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] workqueue: add function in event of
 workqueue_activate_work
Message-ID: <20240307212356.2e4d77d7@gandalf.local.home>
In-Reply-To: <20240308021818.2306176-1-quic_yingangl@quicinc.com>
References: <20240308021818.2306176-1-quic_yingangl@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Fri, 8 Mar 2024 10:18:18 +0800
Kassey Li <quic_yingangl@quicinc.com> wrote:

> The trace event "workqueue_activate_work" only print work struct.
> However, function is the region of interest in a full sequence of work.
> Current workqueue_activate_work trace event output:
>=20
>     workqueue_activate_work: work struct ffffff88b4a0f450
>=20
> With this change, workqueue_activate_work will print the function name,
> align with workqueue_queue_work/execute_start/execute_end event.
>=20
>     workqueue_activate_work: work struct ffffff80413a78b8 function=3Dvmst=
at_update
>=20
> Signed-off-by: Kassey Li <quic_yingangl@quicinc.com>
> ---
> Changelog:
> v1: https://lore.kernel.org/all/20240308010929.1955339-1-quic_yingangl@qu=
icinc.com/
> v1->v2:
> - do not follow checkpatch in TRACE_EVENT() macros
> - add sample "workqueue_activate_work: work struct ffffff80413a78b8 funct=
ion=3Dvmstat_update"

=46rom a tracing POV,

Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve

> ---
>  include/trace/events/workqueue.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/include/trace/events/workqueue.h b/include/trace/events/work=
queue.h
> index 262d52021c23..6ef5b7254070 100644
> --- a/include/trace/events/workqueue.h
> +++ b/include/trace/events/workqueue.h
> @@ -64,13 +64,15 @@ TRACE_EVENT(workqueue_activate_work,
> =20
>  	TP_STRUCT__entry(
>  		__field( void *,	work	)
> +		__field( void *,	function)
>  	),
> =20
>  	TP_fast_assign(
>  		__entry->work		=3D work;
> +		__entry->function	=3D work->func;
>  	),
> =20
> -	TP_printk("work struct %p", __entry->work)
> +	TP_printk("work struct %p function=3D%ps ", __entry->work, __entry->fun=
ction)
>  );
> =20
>  /**