Received-SPF: pass (google.com: domain of linux-kernel+bounces-96482-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Xu Yang <xu.yang_2@nxp.com>
To: Frank Li <frank.li@nxp.com>
CC: "will@kernel.org" <will@kernel.org>, "mark.rutland@arm.com"
	<mark.rutland@arm.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>, "shawnguo@kernel.org"
	<shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com"
	<festevam@gmail.com>, "john.g.garry@oracle.com" <john.g.garry@oracle.com>,
	"jolsa@kernel.org" <jolsa@kernel.org>, "namhyung@kernel.org"
	<namhyung@kernel.org>, "irogers@google.com" <irogers@google.com>,
	"mike.leach@linaro.org" <mike.leach@linaro.org>, "peterz@infradead.org"
	<peterz@infradead.org>, "mingo@redhat.com" <mingo@redhat.com>,
	"acme@kernel.org" <acme@kernel.org>, "alexander.shishkin@linux.intel.com"
	<alexander.shishkin@linux.intel.com>, "adrian.hunter@intel.com"
	<adrian.hunter@intel.com>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "linux-perf-users@vger.kernel.org"
	<linux-perf-users@vger.kernel.org>, "imx@lists.linux.dev"
	<imx@lists.linux.dev>
Subject: RE: [PATCH v6 2/7] perf: imx_perf: add macro definitions for parsing
 config attr
Thread-Topic: [PATCH v6 2/7] perf: imx_perf: add macro definitions for parsing
 config attr
Thread-Index: AQHacHXeU0pTCoFFP0+C3lSU2gJvhbEse/UAgAC2VxA=
Date: Fri, 8 Mar 2024 03:36:05 +0000
Message-ID:
 <DU2PR04MB882259EC13676F32F24EB58B8C272@DU2PR04MB8822.eurprd04.prod.outlook.com>
References: <20240307095730.3792680-1-xu.yang_2@nxp.com>
 <20240307095730.3792680-2-xu.yang_2@nxp.com>
 <ZenudMDnq9bGzKbI@lizhi-Precision-Tower-5810>
In-Reply-To: <ZenudMDnq9bGzKbI@lizhi-Precision-Tower-5810>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?S4wZgdYViKJaFT+KpY+KSN/nCFqYGSbIUuE3xP5Wk0zdcK90ugoi/mXQ8Hjj?=
 =?us-ascii?Q?XU9ftjcZQWyf+RttrhaTcSVPBXUkjw1o8qHMpALAfcwarM0+FcyPsvQ6Y/rI?=
 =?us-ascii?Q?ttWUREmpdaAMc+3Qa3Q7ERuh6RwPJ31egXX8P2LKMro5g8PbMfioIaBlaQsn?=
 =?us-ascii?Q?P2Ut61q23maowTgJrvloC9zkPJzbFHWE9PpJ2fGlgKnDtkBoz/QpDZJXW+Qp?=
 =?us-ascii?Q?46neqltFXRwVdJeNSjqSHPO3vM7hzu7z621B4LVCicoYrdk+gMh1Z+1utJHn?=
 =?us-ascii?Q?zNDWDk/eXoJrktSK3KGZirCWKfUieaERDy0jB+5SkWDqkv8Qr7EtUcHtQCZN?=
 =?us-ascii?Q?CMVPDuQfas6PWFM56G0ntOa3iwKZ+U2RXF5VRbPtEdFw6KEeyef8Mz3x87OC?=
 =?us-ascii?Q?YRxIftv646vIPR+zSXbHONTdDnrRDm/Ve7WxwcLiJrnQwAyINTLTbgQR5UMz?=
 =?us-ascii?Q?o46VRT5IJwxmBHFDJa5Q8EUwK7/fLm1PJJcorcsP3hp6XHnsfvY5+kRP+2dK?=
 =?us-ascii?Q?145i0u1cujzxRKJRRe3e5LqRjFHpBUjX5bYO3b07FxfvbS7pn6P7m3637JPX?=
 =?us-ascii?Q?Ev72ApwZ7/NwpgiBuBnsog/EgXA7MyDDm6Fl8nzUjFK2c+uXXbJMKR7H36BJ?=
 =?us-ascii?Q?CuAZQ9Z/l4nLolBVih9+e3HolhjosMCCtK+EhW1rL31lrot3GyMdVTtUJA5u?=
 =?us-ascii?Q?Mii3O7U1VaVWQBo/mJDWt/5ocmettUPaja+PlvRHudp6eEBPdHnUPQ3ElJMP?=
 =?us-ascii?Q?ab9uO9Yb3wqf5VEb3LJ/4dlxLqDH5+HRrFJcs13R64gDxyYy5vwTXkPzJO8w?=
 =?us-ascii?Q?MZ76OaC+8L0+Pj0IfFpqYRl1/QhU+Po/jietyCLwPfe6BMv5bEY/BD0JmAnT?=
 =?us-ascii?Q?cMiTBPrrXalDbEsMzaUYyCoYxN5d/qJ5vTOslks8xMhcX+KxANWrHDZxkeQ9?=
 =?us-ascii?Q?5CIHDb6KsJ2FxhKfl4u/Ltdx7/LiMAU/ianagWXaW+6WiR2khWB8EKJvQc93?=
 =?us-ascii?Q?PNXzD6qyCeATAqLTcWF8G0Bq3BdFK9dGTBvbOrOOw7tAKuLIFME9ABey9vSt?=
 =?us-ascii?Q?Oi1ioYohgcwd7J6GGlDcqjcw2o7eCRGbUJd03If+lAQqk3GZrfYF95i+Zmj4?=
 =?us-ascii?Q?mFA+rY1xcio27sBU38FAXkMMJppjGNXxz515pM3TXvklH6BpvwyWQcHebT3m?=
 =?us-ascii?Q?/I2CbwQM7aOdHeKpr9uY+C6qQmxPo3uVFQrLcsM2wHz8lYkSCDA0oLFw/cJu?=
 =?us-ascii?Q?eceT+KH4QRKB6SPzLSJph0t5MQ6XCGdgRAj3BSkSajZ1Ob3LWGr37mYHmquK?=
 =?us-ascii?Q?qPZbjflLQaKeOjhWgk2UHZFqeJPyjqt5b5FF1gvWHK1Iz4ngNsDc+E025kb5?=
 =?us-ascii?Q?wvaUWtG+3khPDQJWAoapEe8MTN2BYAmHYb9TK880vNYSyfdxixAWMN5CPz2J?=
 =?us-ascii?Q?yM9j1xHQH/vQt5lbYypys02fpNVa4D9QUXHniaCuwR5aiMeMH1xibsBMT+qe?=
 =?us-ascii?Q?rdwZ60Cyly4lwk32UpdOYZwwSoHqa1VwNWs0VZLGpOiZxczSEyeiqKD5nGuO?=
 =?us-ascii?Q?rmFe84cS2XiYGuGvkaA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6014148-4fd4-4431-c004-08dc3f20e279
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2024 03:36:05.0458
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7cLuolk6gPVxe//6BXHBdbM6lQ3h38ZVtroim8GNrHUvuQpndz+fIhr65rYdmhWxOtLG774UhvT8sOSxGtFbeQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8552

>=20
> On Thu, Mar 07, 2024 at 05:57:25PM +0800, Xu Yang wrote:
> > The user can set event and counter in cmdline and the driver need to pa=
rse
> > it using 'config' attr value. This will add macro definitions to avoid
> > hard-code in driver.
> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> >
> > ---
> > Changes in v4:
> >  - new patch
> > Changes in v5:
> >  - move this patch earlier
> > Changes in v6:
> >  - no changes
> > ---
> >  drivers/perf/fsl_imx9_ddr_perf.c | 15 +++++++++++----
> >  1 file changed, 11 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_d=
dr_perf.c
> > index 9685645bfe04..d1c566e661d8 100644
> > --- a/drivers/perf/fsl_imx9_ddr_perf.c
> > +++ b/drivers/perf/fsl_imx9_ddr_perf.c
> > @@ -42,6 +42,11 @@
> >  #define NUM_COUNTERS		11
> >  #define CYCLES_COUNTER		0
> >
> > +#define CONFIG_EVENT_MASK	0x00FF
> > +#define CONFIG_EVENT_OFFSET	0
>=20
> Needn't need OFFSET if use FIELD_*

Okay, I will use FIELD_*.

>=20
> > +#define CONFIG_COUNTER_MASK	0xFF00
> > +#define CONFIG_COUNTER_OFFSET	8
>=20
> The same
>=20
> > +
> >  #define to_ddr_pmu(p)		container_of(p, struct ddr_pmu, pmu)
> >
> >  #define DDR_PERF_DEV_NAME	"imx9_ddr"
> > @@ -339,8 +344,10 @@ static void ddr_perf_counter_local_config(struct d=
dr_pmu *pmu, int config,
> >  				    int counter, bool enable)
> >  {
> >  	u32 ctrl_a;
> > +	int event;
> >
> >  	ctrl_a =3D readl_relaxed(pmu->base + PMLCA(counter));
> > +	event =3D (config & CONFIG_EVENT_MASK) >> CONFIG_EVENT_OFFSET;
>=20
> FIELD_GET(CONFIG_EVENT_MASK, config);
>=20
> same below all code about config.

Okay.

Thanks,
Xu Yang

>=20
> >
> >  	if (enable) {
> >  		ctrl_a |=3D PMLCA_FC;
> > @@ -352,7 +359,7 @@ static void ddr_perf_counter_local_config(struct dd=
r_pmu *pmu, int config,
> >  		ctrl_a &=3D ~PMLCA_FC;
> >  		ctrl_a |=3D PMLCA_CE;
> >  		ctrl_a &=3D ~FIELD_PREP(PMLCA_EVENT, 0x7F);
> > -		ctrl_a |=3D FIELD_PREP(PMLCA_EVENT, (config & 0x000000FF));
> > +		ctrl_a |=3D FIELD_PREP(PMLCA_EVENT, event);
> >  		writel(ctrl_a, pmu->base + PMLCA(counter));
> >  	} else {
> >  		/* Freeze counter. */
> > @@ -366,8 +373,8 @@ static void ddr_perf_monitor_config(struct ddr_pmu =
*pmu, int cfg, int cfg1, int
> >  	u32 pmcfg1, pmcfg2;
> >  	int event, counter;
> >
> > -	event =3D cfg & 0x000000FF;
> > -	counter =3D (cfg & 0x0000FF00) >> 8;
> > +	event =3D (cfg & CONFIG_EVENT_MASK) >> CONFIG_EVENT_OFFSET;
> > +	counter =3D (cfg & CONFIG_COUNTER_MASK) >> CONFIG_COUNTER_OFFSET;
> >
> >  	pmcfg1 =3D readl_relaxed(pmu->base + PMCFG1);
> >
> > @@ -469,7 +476,7 @@ static int ddr_perf_event_add(struct perf_event *ev=
ent, int flags)
> >  	int cfg2 =3D event->attr.config2;
> >  	int counter;
> >
> > -	counter =3D (cfg & 0x0000FF00) >> 8;
> > +	counter =3D (cfg & CONFIG_COUNTER_MASK) >> CONFIG_COUNTER_OFFSET;
> >
> >  	pmu->events[counter] =3D event;
> >  	pmu->active_events++;
> > --
> > 2.34.1
> >