Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp319875lqc; Thu, 7 Mar 2024 20:24:20 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXDg63rHGk8qaOHSuJqECUEXIpe8RBV7XF0l5b20N9F73CpYqLprJef66TiarhGvX8ZTogLpU277T7GCbivHPdrCS3xklo1y56aQel2Wg== X-Google-Smtp-Source: AGHT+IHnyTNUE2aFMrBBDXcWBa3VHQnffMQpWOq0Jh046w6waS/xcmloL7pyfQbnpzsZfgkGJwIq X-Received: by 2002:a25:848c:0:b0:dbe:9509:141c with SMTP id v12-20020a25848c000000b00dbe9509141cmr17832240ybk.30.1709871860737; Thu, 07 Mar 2024 20:24:20 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709871860; cv=pass; d=google.com; s=arc-20160816; b=S2Oxdw9guJCDR9RxEiyDTf6zMmdhiXCfWeEZfYRTDhWtciL6o7Wh857qgDnVndlSNt v3n74sdCBOOGjE2Ue57itd7kgB53iqUReWcQU/1aAhLEktsy1Yg8Y0Ehh8I8XzrFrcqi gwhKZAJ1eYtICKDXM4cFifTPPr30EvjaKUk/tFHlMgKfevX977GLgmQRA97Xo0UMfTBn ek4zpBgT34Sx8lMoFQdIPSKTK2wGcxK4/UJtXYeeCESdVWqW9XoZDi9fBbyIrOiXgGsC ZSSOTtCAgMns/1qwP22GTGQCgsBGfu0uKiD1al7W+4WEUeCevhTLW1opz5HhCRP5RSHu 46WA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=SgY7adjaSlyF2TlLePIJxaoOS3gYkwcgjk88e0yZi+c=; fh=zjBJbHYBKcP3cfvtw4o95kIsYhTMk/2Uah1LaN+zT8A=; b=OUpDQzf5hYxM5vYJVCIM5uHjra6sTtiolH/jeKNpoA8iD8hMD1FYllCTikMw9/+aVy 3LQyVbhGyQLv4loiockFki/oOdqC883I4fZKWYRlm+JRqfauEKibk2dLnivdoQLMPqOB tRWRyW6PB6mdv3PyUZy2clwvFSkaSsIWtJGMptMOusCyQJbMnKS4T82cCxvtDLtLTBqa s7zZKhVcqNGajAVF7iC7ntGHsbvzJt0wzTB6Dnwog5ToWk/K1UK+b5a5U470Qql+4h+x f63874mW0tBhWf80aIRvJTFbx0xL9m4DIghTtgKlGKnVPF/gQZT2MiL4FG6BXQWe/xiw EhKQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FGHrFJjO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-96501-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96501-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id w15-20020ac857cf000000b0042e224098e6si12739233qta.467.2024.03.07.20.24.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 20:24:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-96501-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FGHrFJjO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-96501-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96501-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 72CF01C21060 for ; Fri, 8 Mar 2024 04:24:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A265A2D04F; Fri, 8 Mar 2024 04:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FGHrFJjO" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9FE72C6B6; Fri, 8 Mar 2024 04:24:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709871852; cv=none; b=A0e/fCevvI4nFHLag50kJGOuanZE5A6lsqlSC1HE2MM2Pm0NwS1JAXDcXxR4s1pze4Us7vpKvEuAHaEeDxQwe5uc12zvUKW2KLkvL9Z8BPwZ5nlWSYR6tmvAekUxUyfN81+TWhKOpC9OrerOjZ+FXvYerf1v6UiCj8g7WDE23XE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709871852; c=relaxed/simple; bh=BGBLixuXPGuuA+n3MUis9zLgUWGUfR0TjhRnP9RUYyA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aAh0EhWGV4///tYqtYgdiMWi9FXmJ2rojgJs59Ctt6FauJ2zM+pSHgaJG9BU5iZrbgzylQCGls756/FbUDI8hkm+3BVDPVBsLZgEfsJPqHIzX4dYSKNVg4gyqowQcgY4qW3VhQ7HakXfErqa2kqMwbnnUvLPS2LPN4+Vjkghe9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FGHrFJjO; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4CA7C433C7; Fri, 8 Mar 2024 04:24:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709871852; bh=BGBLixuXPGuuA+n3MUis9zLgUWGUfR0TjhRnP9RUYyA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FGHrFJjOdLNAVPlVV2y72PZHt3Zdq4NO6a+2+jAPscXe8XtPmN7Tw5MpgAwOpfnIs I0WUyIL5s1vqJaI0IX0Ki8W6r8zuEby3COUU1JpXiKWJaF95D/irATYgjmIIuebnUk RdorUU4amsEI8+zINNVQZ0VogYecAyLAkxiT2NSMv+EK97eBBx7qk4plSZotGlcRuE QMjS28xC/h7VJcLhked9kTMwFyrqXfWM/AC/oCbULkfXCD/KXxL370woS29Y5YOYf2 w0HOiVvaibuTBsPk+i/iAwk5Cak0nZIRub8G4aTliPs++t3bSwIHhT50zGU6OgzYpl i9TuBjrxV3FlQ== Date: Thu, 7 Mar 2024 20:24:10 -0800 From: Jakub Kicinski To: Oleksij Rempel Cc: "David S. Miller" , Andrew Lunn , Eric Dumazet , Florian Fainelli , Paolo Abeni , Vladimir Oltean , Woojung Huh , Arun Ramadoss , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com Subject: Re: [PATCH net v1 1/1] net: dsa: microchip: make sure drive strength configuration is not lost by soft reset Message-ID: <20240307202410.65595460@kernel.org> In-Reply-To: <20240304135612.814404-1-o.rempel@pengutronix.de> References: <20240304135612.814404-1-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 4 Mar 2024 14:56:12 +0100 Oleksij Rempel wrote: > This driver has two separate reset sequence in different places: > - gpio/HW reset on start of ksz_switch_register() > - SW reset on start of ksz_setup() > > The second one will overwrite drive strength configuration made in the > ksz_switch_register(). > > To fix it, move ksz_parse_drive_strength() from ksz_switch_register() to > ksz_setup(). > > Fixes: d67d7247f641 ("net: dsa: microchip: Add drive strength configuration") > Signed-off-by: Oleksij Rempel Applied, thanks!