Received-SPF: pass (google.com: domain of linux-kernel+bounces-96546-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Sai Krishna Gajula <saikrishnag@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
CC: "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com"
	<edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri
 Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Subbaraya Sundeep Bhatta
	<sbhatta@marvell.com>
Subject: Re: [net-next PATCH v2] octeontx2-pf: Reset MAC stats during probe
Thread-Topic: [net-next PATCH v2] octeontx2-pf: Reset MAC stats during probe
Thread-Index: AQHacR8yKrGa4MnfIU24yGWkdxB9Xw==
Date: Fri, 8 Mar 2024 06:09:36 +0000
Message-ID: 
 <BY3PR18MB470736FBC23588BE63656D50A0272@BY3PR18MB4707.namprd18.prod.outlook.com>
References: <20240305082707.213332-1-saikrishnag@marvell.com>
 <20240307204725.4dddcc9d@kernel.org>
In-Reply-To: <20240307204725.4dddcc9d@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?dNrhgE7m+plqBd8WWefrVu0CvVehf9q8E1BBrMVOj1LAFUiuGVpEaeJMOUm3?=
 =?us-ascii?Q?mj6oAyWnX9dmmgUnwbq320HjK+nLde7SLFZApjxcYF2Uc75MuEJgEqkIrNUS?=
 =?us-ascii?Q?bR+AquZWJu3seVU6cDrFu/zkpMGFAUTnKgqhJCFO/f23WA9BJACLoirvwO44?=
 =?us-ascii?Q?DrC2YVXE/VTVjmKyQt8jo9UR/gzXSAfR0YAVaj+ridupWmdljxludUmZNHo5?=
 =?us-ascii?Q?M7H2/ar7gZHu0m3JxkAU7XyQD3RvqOQKL0qS/0WGmQRt1AfA85n9DNcND8pQ?=
 =?us-ascii?Q?+lK0Bl1wJXVmkio+Jkem1GM7IgByoRNdC4Jt4+83YBdrEtWg/RVUbVNJ7n2h?=
 =?us-ascii?Q?O3dP+cU2peL8Lr3V9ZzkIMZrLQDGxj63gy3gL6qpaUkOUa6/KkLfI7yzEh5+?=
 =?us-ascii?Q?uViQnpLXytbpxyDfuWTH6aMCR3YZsBKqQe5m16GI2dSDiAPXrvDeMka+EJ2V?=
 =?us-ascii?Q?G9FJFv7TFE/Pwib8+LRJ4Rysp1fkxzdmud9KVYK7lQHcHHsa5cPI4AqhJg+n?=
 =?us-ascii?Q?o5eUDiyt8KNXbov7vyU2rilnaorzRlwHWzAwyqizZFkNYrW+aXHcsrRw6PgI?=
 =?us-ascii?Q?EgHHrmYIDWZUE5wgrP8ee65hSUDMtA6UcE9uxNRfWlp0F2LiACjnqxicL0cT?=
 =?us-ascii?Q?J32YJY7ntO23Hx8CWoI11Rselw/UoWc1q6Jsi4aLmsMsh2ChIMdZ8SsrzWns?=
 =?us-ascii?Q?j0r0D3H8a7UAA9P+jx3jLmwf2Vhpg5mikAV6jFLJ6EOW/1j60yMX5pgt5Le2?=
 =?us-ascii?Q?LxuWxVSbi8K1ELKpAIzssq+b53H7O6IMH13PA1xTsCrCIshphluhmB5tCZjK?=
 =?us-ascii?Q?cqK/TrHLklvxzBqJo42uoICnJ/PFxPoB7qB/zei2lSRbhsmQwoKl0XTz/kUm?=
 =?us-ascii?Q?S02LJH3MgNqIpD63kIWmUGHk1MJPpcobCEeLlTWW1EGv/YlwC+6gjTS66Ym9?=
 =?us-ascii?Q?6NrEcG+iTApU3AfTJRJczMuRlYoUibeHPbR0LSmRUJ3GpBeq07vQf3KeyOzP?=
 =?us-ascii?Q?dP895775WAJZbsx62TJwFj/jsBg3epDKJ6AlTmHViEM0HF4XayWlWwZpZhX1?=
 =?us-ascii?Q?gKdQ0v9jsfqtw0GT65zkVt3pzFXlgCQukMMS4ll89VOJ4MLhAm76ZKNCEwF+?=
 =?us-ascii?Q?p8aH7cuy87u6Y+xe69BBnv6Bcy/N7H3VzlmMyVx+KPPBCZ27WWHOh2aLyGJF?=
 =?us-ascii?Q?RG4tdTtn9clzPZpkT6XrUMk+lnsQJ0shBvCfGgdEy2NmEcccK3KmlnVig+M/?=
 =?us-ascii?Q?fApCALfTkV0FNFgO5ckZ/aana7fx53raHeo8EvD3D++inHQZsQKxsXfUIM+l?=
 =?us-ascii?Q?b0DbSyuaxuvfeAGbAKXGyoS5iHpLIrYAhfc6+SeibVunme6T2EwbdJl3HM0n?=
 =?us-ascii?Q?nohDfALGZdVW5wJLzg4B0wdrRma9ZDHCbdkZ3Mx+iAT8c/0SF7e8VrOfWlMs?=
 =?us-ascii?Q?4ybliY9oZqqfUeLXMSconKzMOJKz2I/XUAKifHECfj+8zD4CbXfRrvMRdEYM?=
 =?us-ascii?Q?vN1g5eOfrW1FXO4UP8RqsL4ltQIBFjZyZ4d4jBem5sXg/W6V1yxgsl6taLI1?=
 =?us-ascii?Q?w8i6Z7dEP320PrEx+9ynP6m3g1svniwFQx757CV8?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4707.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ec77cb5b-13a2-4c2c-2533-08dc3f365510
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2024 06:09:36.7164
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: eLnzZVKlBUhZvxzQBU/JsPVYDQDP2yT8vOZPOOzmDmC5bFVvPjZGd5mEPjmjCslNz+2cfwDnUqW4m/M4yThTBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR18MB5891
X-Proofpoint-GUID: 0sZj_jbExxvolHwAUKUSrNbU1u8nI-Fe
X-Proofpoint-ORIG-GUID: 0sZj_jbExxvolHwAUKUSrNbU1u8nI-Fe
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-08_04,2024-03-06_01,2023-05-22_02


> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Friday, March 8, 2024 10:17 AM
> To: Sai Krishna Gajula <saikrishnag@marvell.com>
> Cc: davem@davemloft.net; edumazet@google.com; pabeni@redhat.com;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri Gouth=
am
> <sgoutham@marvell.com>; Geethasowjanya Akula <gakula@marvell.com>;
> Hariprasad Kelam <hkelam@marvell.com>; Subbaraya Sundeep Bhatta
> <sbhatta@marvell.com>
> Subject: Re: [net-next PATCH v2] octeontx2-pf: Reset MAC stats
> during probe
>=20
> On Tue, 5 Mar 2024 13:57:07 +0530 Sai Krishna wrote:
> > +int otx2_reset_mac_stats(struct otx2_nic *pfvf);
> >
> >  /* RVU block related APIs */
> >  int otx2_attach_npa_nix(struct otx2_nic *pfvf); diff --git
> > a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> > b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> > index e5fe67e73865..a91f5b7e84c6 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> > @@ -1124,6 +1124,24 @@ static int otx2_cgx_config_linkevents(struct
> otx2_nic *pf, bool enable)
> >  	return err;
> >  }
> >
> > +int otx2_reset_mac_stats(struct otx2_nic *pfvf) {
> > +	struct msg_req *req;
> > +	int err;
> > +
> > +	mutex_lock(&pfvf->mbox.lock);
> > +	req =3D otx2_mbox_alloc_msg_cgx_stats_rst(&pfvf->mbox);
> > +	if (!req) {
> > +		mutex_unlock(&pfvf->mbox.lock);
> > +		return -ENOMEM;
> > +	}
> > +
> > +	err =3D otx2_sync_mbox_msg(&pfvf->mbox);
> > +	mutex_unlock(&pfvf->mbox.lock);
> > +	return err;
> > +}
> > +EXPORT_SYMBOL(otx2_reset_mac_stats);
>=20
> Why the export? I see only one call to this function and it's right below=
.

Ack, Will remove this export and submit patch V3

>=20
> >  static int otx2_cgx_config_loopback(struct otx2_nic *pf, bool enable)
> > {
> >  	struct msg_req *msg;
> > @@ -3048,6 +3066,9 @@ static int otx2_probe(struct pci_dev *pdev,
> > const struct pci_device_id *id)
> >
> >  	otx2_qos_init(pf, qos_txqs);
> >
> > +	/* reset CGX/RPM MAC stats */
> > +	otx2_reset_mac_stats(pf);
> > +