Received-SPF: pass (google.com: domain of linux-kernel+bounces-96580-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240207054701.616094-1-lulu@redhat.com> <20240207054701.616094-5-lulu@redhat.com>
 <CACGkMEuVnib2-m_J-wQuNny_1QZFaxi6OmDxHkFCC=Z-TY_qTQ@mail.gmail.com>
In-Reply-To: <CACGkMEuVnib2-m_J-wQuNny_1QZFaxi6OmDxHkFCC=Z-TY_qTQ@mail.gmail.com>
From: Cindy Lu <lulu@redhat.com>
Date: Fri, 8 Mar 2024 15:27:07 +0800
Message-ID: <CACLfguWPpM1PNB6NP8r7ZUk9tk2b=CAJaCX3hRCaFCFNnoC3Pg@mail.gmail.com>
Subject: Re: [PATCH v4 4/5] vduse: Add file operation for mmap
To: Jason Wang <jasowang@redhat.com>
Cc: mst@redhat.com, xieyongji@bytedance.com, linux-kernel@vger.kernel.org, 
	maxime.coquelin@redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 8, 2024 at 2:08=E2=80=AFPM Jason Wang <jasowang@redhat.com> wro=
te:
>
> On Wed, Feb 7, 2024 at 1:47=E2=80=AFPM Cindy Lu <lulu@redhat.com> wrote:
> >
> > Add the operation for mmap, This function  will be used by the user spa=
ce
> > application to map the pages to the user space.
> >
> > Signed-off-by: Cindy Lu <lulu@redhat.com>
> > ---
> >  drivers/vdpa/vdpa_user/vduse_dev.c | 57 ++++++++++++++++++++++++++++++
> >  1 file changed, 57 insertions(+)
> >
> > diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_use=
r/vduse_dev.c
> > index 2da659d5f4a8..083fe0047677 100644
> > --- a/drivers/vdpa/vdpa_user/vduse_dev.c
> > +++ b/drivers/vdpa/vdpa_user/vduse_dev.c
> > @@ -1465,6 +1465,61 @@ static struct vduse_dev *vduse_dev_get_from_mino=
r(int minor)
> >         return dev;
> >  }
> >
> > +static vm_fault_t vduse_vm_fault(struct vm_fault *vmf)
> > +{
> > +       struct vduse_dev *dev =3D vmf->vma->vm_file->private_data;
> > +       struct vm_area_struct *vma =3D vmf->vma;
> > +       u16 index =3D vma->vm_pgoff;
> > +       struct vduse_virtqueue *vq;
> > +       unsigned long vaddr;
> > +
> > +       /* index 1+vq_number page reserved for virtqueue state*/
>
> This comment seem wrong?
>
> THanks
>
sure,will fix this
thanks
cindy
>
> > +       vq =3D dev->vqs[index];
> > +       vaddr =3D vq->vdpa_reconnect_vaddr;
> > +       if (remap_pfn_range(vma, vmf->address & PAGE_MASK,
> > +                           PFN_DOWN(virt_to_phys((void *)vaddr)), PAGE=
_SIZE,
> > +                           vma->vm_page_prot))
> > +               return VM_FAULT_SIGBUS;
> > +       return VM_FAULT_NOPAGE;
> > +}
> > +
> > +static const struct vm_operations_struct vduse_vm_ops =3D {
> > +       .fault =3D vduse_vm_fault,
> > +};
> > +
> > +static int vduse_dev_mmap(struct file *file, struct vm_area_struct *vm=
a)
> > +{
> > +       struct vduse_dev *dev =3D file->private_data;
> > +       unsigned long vaddr =3D 0;
> > +       unsigned long index =3D vma->vm_pgoff;
> > +       struct vduse_virtqueue *vq;
> > +
> > +       if (vma->vm_end - vma->vm_start !=3D PAGE_SIZE)
> > +               return -EINVAL;
> > +       if ((vma->vm_flags & VM_SHARED) =3D=3D 0)
> > +               return -EINVAL;
> > +
> > +       if (index > dev->vq_num)
> > +               return -EINVAL;
> > +
> > +       vq =3D dev->vqs[index];
> > +       vaddr =3D vq->vdpa_reconnect_vaddr;
> > +       if (vaddr =3D=3D 0)
> > +               return -EOPNOTSUPP;
> > +
> > +       if (virt_to_phys((void *)vaddr) & (PAGE_SIZE - 1))
> > +               return -EINVAL;
> > +
> > +       /* Check if the Userspace App mapped the correct size */
> > +       if (vma->vm_end - vma->vm_start !=3D PAGE_SIZE)
> > +               return -EOPNOTSUPP;
> > +
> > +       vm_flags_set(vma, VM_DONTEXPAND);
> > +       vma->vm_ops =3D &vduse_vm_ops;
> > +
> > +       return 0;
> > +}
> > +
> >  static int vduse_dev_open(struct inode *inode, struct file *file)
> >  {
> >         int ret;
> > @@ -1497,6 +1552,8 @@ static const struct file_operations vduse_dev_fop=
s =3D {
> >         .unlocked_ioctl =3D vduse_dev_ioctl,
> >         .compat_ioctl   =3D compat_ptr_ioctl,
> >         .llseek         =3D noop_llseek,
> > +       .mmap           =3D vduse_dev_mmap,
> > +
> >  };
> >
> >  static ssize_t irq_cb_affinity_show(struct vduse_virtqueue *vq, char *=
buf)
> > --
> > 2.43.0
> >
>