Received-SPF: pass (google.com: domain of linux-kernel+bounces-96608-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <cce858b3-cd8c-4b11-9564-d3c38eb8d536@suse.cz>
Date: Fri, 8 Mar 2024 08:53:35 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] mm,page_owner: Drop unnecesary check
Content-Language: en-US
To: Oscar Salvador <osalvador@suse.de>,
 Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
 Michal Hocko <mhocko@suse.com>, Marco Elver <elver@google.com>,
 Andrey Konovalov <andreyknvl@gmail.com>,
 Alexander Potapenko <glider@google.com>
References: <20240306123217.29774-1-osalvador@suse.de>
 <20240306123217.29774-3-osalvador@suse.de>
From: Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <20240306123217.29774-3-osalvador@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 3/6/24 13:32, Oscar Salvador wrote:
> stackdepot only saves stack_records which size is greather than 0,
> so we cannot possibly have empty stack_records.
> Drop the check.
> 
> Signed-off-by: Oscar Salvador <osalvador@suse.de>

Reviewed-by: Vlastimil Babka <vbabka@suse.cz>---
>  mm/page_owner.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/page_owner.c b/mm/page_owner.c
> index 7163a1c44ccf..e7139952ffd9 100644
> --- a/mm/page_owner.c
> +++ b/mm/page_owner.c
> @@ -865,8 +865,7 @@ static int stack_print(struct seq_file *m, void *v)
>  	entries = stack_record->entries;
>  	stack_count = refcount_read(&stack_record->count) - 1;
>  
> -	if (!nr_entries || nr_entries < 0 || stack_count < 1 ||
> -	    stack_count < page_owner_stack_threshold)
> +	if (stack_count < 1 || stack_count < page_owner_stack_threshold)
>  		return 0;
>  
>  	for (i = 0; i < nr_entries; i++)