Received-SPF: pass (google.com: domain of linux-kernel+bounces-96611-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 8 Mar 2024 08:56:20 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, 
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v1 0/5] w1: gpio: A set of cleanups
Message-ID: <spc5otfv7s2wtunhbxdorm5bh5snvfbggoaqghowrxm2osbeoz@b2dsqa3amvtg>
References: <20240307143644.3787260-1-andriy.shevchenko@linux.intel.com>
 <vsaqquulifmpk5fanl4i67nzag5huyibzy5lfr2jdsgk2dv7t3@5i4opts7npsj>
 <ZenuzMtybS4CzwHv@smile.fi.intel.com>
 <46qzdowo2om2bbuokiksah27x4qok7hffiefwsj4bihz2xg62y@hxrag6h55zw7>
 <Zen_7fDQghq6GJ_s@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="djpsrzmcypk6c5jq"
Content-Disposition: inline
In-Reply-To: <Zen_7fDQghq6GJ_s@smile.fi.intel.com>


--djpsrzmcypk6c5jq
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Andy,

On Thu, Mar 07, 2024 at 07:57:01PM +0200, Andy Shevchenko wrote:
> On Thu, Mar 07, 2024 at 06:12:46PM +0100, Uwe Kleine-K=F6nig wrote:
> > On Thu, Mar 07, 2024 at 06:43:56PM +0200, Andy Shevchenko wrote:
> > > On Thu, Mar 07, 2024 at 05:38:54PM +0100, Uwe Kleine-K=F6nig wrote:
>=20
> ...
>=20
> > > > I wonder about your choice of recipients. I would have added Krzysz=
tof
> > > > to To and me at most to Cc:.
> > >=20
> > > It's automatically generated using get_maintainers.pl.
> > > See details in the source of the script [1] I'm using.
> > >=20
> > > [1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maint=
ainer.sh
> >=20
> > Getting something wrong automatically isn't an excuse for getting it
> > wrong :-)
>=20
> I'm not sure why you think it's wrong. You worked on the code lately and =
Git
> heuristics considered that over threshold of 67%.

When I send a patch I send it "to" the maintainers, because it's them
who I want an action from. This also matches the semantic of M: in
MAINTAINERS which requests to use these contaces in "To:".

> > That scripts has:
> >=20
> > to=3D$(git show -$count "$COMMIT" | scripts/get_maintainer.pl $OPTS --n=
o-m --no-r)
> > cc=3D$(git show -$count "$COMMIT" | scripts/get_maintainer.pl $OPTS --n=
o-l)
> >=20
> > I recommend to swap the values for to and cc here to make sure you have
> > the maintainer in $to and the relevant lists in $cc.

Thinking again, this is wrong. I'd recommend:

	to=3D$(git show -$count "$COMMIT" | scripts/get_maintainer.pl $OPTS --no-r=
 --no-l)
	cc=3D$(git show -$count "$COMMIT" | scripts/get_maintainer.pl $OPTS --no-m)

> Btw, you are the first one for the entire life cycle of that script (3 ye=
ars?)
> who complains about such details... So, patches are welcome! :-)

I won't do more than the above hint here.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--djpsrzmcypk6c5jq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmXqxKMACgkQj4D7WH0S
/k74SggAsufoZoLLydlPozRRoUjVIvHER/jsy1iw/q11jz+zCHg3t7LfeMLXO9UJ
CYJcjY8MFO01BldAV0qEhOa9SLZmjpDmUmryAgnAkw390rpeEgWYbVMbcdmUBZXZ
2FZ3vi9JMKcqvNsb+rxeYJONixMvUg22nBcPZbzkrfpJlqfJZQH+Dt+mJwbXQbHh
FOUhmWxVLkJQJYwjrEoN1NNe6IRYQO0hGT6pof53a9v8NbRILtRLovGQ+U+fT1BX
MdsYl2vZHRfYn5EC8+5dVGgfZrL/VtVaOT/gz0jXDQlgSpW+wLZCUaB4j/JA3WH/
kqeA3tCln6zzKZnyMK3rVuu0EclBIg==
=s+ms
-----END PGP SIGNATURE-----

--djpsrzmcypk6c5jq--