Received-SPF: pass (google.com: domain of linux-kernel+bounces-96668-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Yinjun Zhang <yinjun.zhang@corigine.com>
To: Duoming Zhou <duoming@zju.edu.cn>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>, oss-drivers
	<oss-drivers@corigine.com>, "christophe.jaillet@wanadoo.fr"
	<christophe.jaillet@wanadoo.fr>, "horms@kernel.org" <horms@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>, "edumazet@google.com"
	<edumazet@google.com>, "davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>, Louis Peens <louis.peens@corigine.com>
Subject: RE: [PATCH] nfp: flower: handle acti_netdevs allocation failure
Thread-Topic: [PATCH] nfp: flower: handle acti_netdevs allocation failure
Thread-Index: AQHacJbnGqenCY0PeEmlsd7MLWD/0bEthN5w
Date: Fri, 8 Mar 2024 08:39:37 +0000
Message-ID:
 <DM6PR13MB3705982C783811A22D1692F1FC272@DM6PR13MB3705.namprd13.prod.outlook.com>
References: <20240307135335.19306-1-duoming@zju.edu.cn>
In-Reply-To: <20240307135335.19306-1-duoming@zju.edu.cn>
Accept-Language: en-US, zh-CN
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?wDkWNABCWpReQ2pBan8hwaRvJTFxvkRsaxfnjlmqq/y4Rh72mM2DYlDv20EZ?=
 =?us-ascii?Q?N8K79eBtQKrKLk5njEM92+cnwVYtQWqBtd1IUjtaoqcQEcSp+XpjccFuC7EU?=
 =?us-ascii?Q?7MqzN2UX5eP77Fwr/2TrB5lltJpV/cLJeSCWnjwlc2NdJOABaDFQcLfRYlom?=
 =?us-ascii?Q?HPWYcuWyXXIoQW5HX1y++/G+0vFLSyd+D8qSuMSrddX6NTKq0P2LAMBFUn+E?=
 =?us-ascii?Q?txBDFBuzAwF8i5iT3GOOjioSs4ZO7txhBZBG+R05T35h/KC9NYToCGa/A+Ve?=
 =?us-ascii?Q?p5Nfny5vrKsA4+qLlEXA9cTGTSeZY7M4strch+X52IqkIgX1k6EIfvrVhgtm?=
 =?us-ascii?Q?0c5qAKxbmgbH2WbqLC8b5CYBOl4m4xKaHnBshkOFtuBnKWZjEXYfiRgZjkUt?=
 =?us-ascii?Q?l7RRnO/rjMpmlFF0Q7ZrngVrEPKlsiLmAHfWuV1/u1rF61vZQbDA/SGdLMW+?=
 =?us-ascii?Q?5f60kDDHSq+zXAycQmgopXXsC2UMHZr7qwK4Oq46D/NwX0XpBtezpQtRxdIf?=
 =?us-ascii?Q?ItJhXMT+a1OEp0Xy8McFkE0S5lAemIx8fxinsKfA0dRfWOUS7ixKha+1j9GG?=
 =?us-ascii?Q?WoB4551NyjTBCEHW3ZYYap8NUsHG4XcmSWvtJVi3uhIee4E4HM3BuaWFXKWT?=
 =?us-ascii?Q?OMI79iPeHsbRvBOG81GLLf64/N+/WQcZKSFpeXPN955/EL5gNIgjuU854czr?=
 =?us-ascii?Q?hrY/kbfjjUb7aoma4fet88mp3C8vWHvNjVHa+q5QE5kz/OAXkIuJpBWbvDpQ?=
 =?us-ascii?Q?O6tBhUC+RfePZUDxxBqhBNe54eJXCXWUAqtXvhOKob+KEGTtwi4BKUrj5sIx?=
 =?us-ascii?Q?/fDz5m/qdCwjuO/zZ2vbnigbSo+2YlTHmGZs6YMpcbs9kzVQYhRa2DT18TsQ?=
 =?us-ascii?Q?UajFNRNBGbMEsz1M8KGaX2cIkBQ6FCFP9n8f53OaJjpG1A88BqGvuHlLrpd4?=
 =?us-ascii?Q?pb8+09lXOVeYt0P2cZW1QmXIPR3mPq00Hqus9PvhX5l15R3r0+AsLSsKXnlb?=
 =?us-ascii?Q?wEHEqZAnjQ32I7b6y2aop4RDVjI4jit98KwC/+rdBdVpwzQvPYJV4WHrIojU?=
 =?us-ascii?Q?AIZhF29CiQC5dut4HrbF9BAGqND68mLQGcBpSgU5HvfRuZooH7yYzobu2c7u?=
 =?us-ascii?Q?dovUzO1bqdZCAejNbqNzgEmt60zGiOQWojE2Xiym4r12hirCgXT7kpCo0ExQ?=
 =?us-ascii?Q?lURC4LIKW5WLdSQQBmz/BmR5cJ3q+fK6WTf/W7/OVMHbhTWhMVG0cwVTWRKI?=
 =?us-ascii?Q?mkhLcgFahFknwT1L7UMpdYuGebrVrx3QTWNmcS8BYflxJ7SgU+Jk94ZbTvTx?=
 =?us-ascii?Q?r02HYGGD9eJvtSa1Vk+KgyuSmDQUq81Mnz1Sseu7bMK2qDLdyzsrrobAHz4O?=
 =?us-ascii?Q?T3T+7HcxyZRfCiLLMpVeGHwEiz54BEEcCGcqj4fVnfTP9ScIkP4BN/FtH3i2?=
 =?us-ascii?Q?C2N7KPuRbUblTxSSFkKfyY7fRGUwJzh/OmZRgEdY6wTUtw18a6E7w4Aksz7w?=
 =?us-ascii?Q?ExRH07Kd/tSy6Lhx/Mr+ga11vKtXGDc/xnQoCH1r9zF3tl8ahsMEALKp1w0H?=
 =?us-ascii?Q?C/BxnogOZAiX0tUCI2ICwa8pjoEobg2dve+KWLMt?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR13MB3705.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 244d81de-6d99-41d0-72ec-08dc3f4b4a2e
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2024 08:39:37.8847
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QO8qzthJNOM5gVXA7TglStqQyW5nD3ct0GiBXKuslpI8RZAwuFNnrDjoOQxlEklAuQvOSUqMUr4WF0+C6g/ZrX1bcyuqTggx2rg7IhB/oBY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR13MB6384

On Thursday, March 7, 2024 9:54 PM, Duoming Zhou wrote:
<...>
>=20
>                 acti_netdevs =3D kmalloc_array(entry->slave_cnt,
>                                              sizeof(*acti_netdevs), GFP_K=
ERNEL);
> +               if (!acti_netdevs) {
> +                       nfp_flower_cmsg_warn(priv->app,
> +                                            "memory allocate failed\n");
> +                       schedule_delayed_work(&lag->work,
> +                                             NFP_FL_LAG_DELAY);
> +                       continue;
> +               }

It reminds me that this issue was reported and tried to fix in
https://lore.kernel.org/netdev/ZVsFBACC05VrrCfw@LouisNoVo/T/#t
However there's no followed v2 to address the review comments.
Based on that discussion, we don't need warn "allocate failed" locally.

>=20
>                 /* Include sanity check in the loop. It may be that a bon=
d has
>                  * changed between processing the last notification and t=
he
> --
> 2.17.1