Received-SPF: pass (google.com: domain of linux-kernel+bounces-96704-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Iskander Amara <iskander.amara@theobroma-systems.com>
To: robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org,
	heiko@sntech.de,
	vahe.grigoryan@theobroma-systems.com,
	angelogioacchino.delregno@collabora.com,
	dsimic@manjaro.org,
	alexander.stein@ew.tq-group.com,
	devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: quentin.schulz@theobroma-systems.com,
	Iskander Amara <iskander.amara@theobroma-systems.com>
Subject: [PATCH 1/2] arm64: dts: rockchip: enable internal pull-up for Q7_THRM# on RK3399 Puma
Date: Fri,  8 Mar 2024 09:52:42 +0100
Message-Id: <20240308085243.69903-1-iskander.amara@theobroma-systems.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?S4HFU4L9Vhb/vSLMORdg+2MibbRqpQqfU0v8YNuPSRH6d/dfFjj4I4xbTWXh?=
 =?us-ascii?Q?zlULN4blQEiupzFh7FAGMxuZFyjOJz5VU3O3DrHGFnVOMmV7tttxyl1Jeoxd?=
 =?us-ascii?Q?139SccfYUUZtYZMtRQSNKfKytzaiSiHySCGzjM5Vehd833nFZFvWaPy2vlPu?=
 =?us-ascii?Q?9tldYkHtgCliEECN9GP5lXM0x6vkOd81eJu8S5rmMMCJVIFesD32xTHfnGyS?=
 =?us-ascii?Q?cc+eeHqqyYfMRWWZomzWH7UlqWnE0upzgoB4HC4O/n/C8SLpx6eYB5of9nd+?=
 =?us-ascii?Q?L1Q5GWYjBjp1eu0yktNu5QxXSC8eG903DoXolRQnsVRDa1Eio90ksxqWw8pc?=
 =?us-ascii?Q?ucw4C/pWR0TW9e1fCTIHLEIYPoBFBZQIwAUNZ+vIRZhlCtH8HXb60v5slnIm?=
 =?us-ascii?Q?yEhjikOa8vtenGw5ImaaojVoaYAqqzIAKgGIqrnlvzkFQpdXW2FUc2ap2xF5?=
 =?us-ascii?Q?jrBCXNPjah3kccfmut+5Jd5FcjC+TmfvhrN3iVTkttFyX7Mxkofh1VlLmiVG?=
 =?us-ascii?Q?iE2M9cjKz0L3hUQTSdraVWkjofw96Qa4Sl6zhKRe0o5RxoaLp5h0hnaUDClu?=
 =?us-ascii?Q?bAiZHWK8VQs6zLHQo7STmFcOFQeKDEr0/JLsKpn+a6yZ9qAU/HsSf6wOqp1W?=
 =?us-ascii?Q?jomuxbNmICHkgGxy5NUDiL7Xv0htGV2XJw2ZJSocQ/++Tvvx+naiQkVEP9GJ?=
 =?us-ascii?Q?RfRAfKOU1tKl7aBalVyG0GdyhZuLXvco2IxP9VADc7JtnIQiOLtf/bX439Hv?=
 =?us-ascii?Q?svxDaYVUpVAB5RnmbMc4oCMQBvEpege93Qezf34KPdC4mtEJL5jMNmGR8GcX?=
 =?us-ascii?Q?KD6GS8DbikZVD5U9SqritBA/Se8T6ECiIsi2OtxWYoeqxeJXDbCS+ycC+AKh?=
 =?us-ascii?Q?LfzuZ2GSRrT+i0TaT48JDDCUa3EuEAsH/TqMXGQ6UJY4PRG6iC2Ywlo6eVa9?=
 =?us-ascii?Q?9N5mW4UuEWp8/8o5laSGUf7E2k19uHfcLERiYoQO410aN7k9+bNj7Yn8ALcF?=
 =?us-ascii?Q?sooPRUOYtbt52nymSFw4ggEI+xA4J/NrWghTDwgxXJvLtHMsSU9twac3Hn5p?=
 =?us-ascii?Q?/hogrXz+PWjWxwTJCzpooacW/xKb2I21eTW+d8W+tQacmUXEOeEx27mp/7z4?=
 =?us-ascii?Q?5DIf37OiKQmcDhjYJnpf0nz4ovLQrYFfJ2IplztDpZ89F6hqiwKlH19YC4ST?=
 =?us-ascii?Q?L8WaREajkbrNru0tU+d30Cx4gwba7deHh/BCnvbieoFmwMiI/eh5JT9tICJS?=
 =?us-ascii?Q?CcNVuMZV2MJVe6A9SSykBttq8MR2QKCFQnoLpY9O3WfZ1Xe9Ya6dWwZ5TYvT?=
 =?us-ascii?Q?GwINBLuj0egnn7T0M0PFTkuqN0+klab0r64fOzADGrQBDb+CwbvZ+PsrR/op?=
 =?us-ascii?Q?mV/jcD812LchqxStPGZ1/6sxg2VXJrCg67DvQ5lpqtZMWk6pMX7gERcKP2I8?=
 =?us-ascii?Q?tedsK6+1fZetivKQDLj8yGuZDj/88IAxdKLPf4+CnqfzVAqkNT66UdBLuvkf?=
 =?us-ascii?Q?ehvO+cS4t+Of1NnTg/fFzUDu/70AAUPBlYVTdxFKfj0WoWIsBoEvtsYqQEDj?=
 =?us-ascii?Q?GgtRmTM5C4Oz3QZ7k52RWcxXOskZJ0HQ4/2J4xG7ZrMrk3xBtC6V0alaIDb5?=
 =?us-ascii?Q?qgRqUKfVuUpQZrufKJEtwSs=3D?=
X-OriginatorOrg: theobroma-systems.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a6eafe44-e913-466a-d600-08dc3f4d23dc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB6013.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 08:52:52.7657
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SbmtaglKtPrxbH2xd3UdNtYofWlWGGGaoX3iv4NILeBSN3ZNKdl4Ao0pLK1M4ziTR3LhYrnfP+6k24xMb7W2/PgQztn/Qgwpr7qWRKVBLEMiRhM96gRUyaqgC4Rd7ujn
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7131

Q7_THRM# pin is connected to a diode on the module which is used
as a level shifter, and the pin have a pull-down enabled by
default. We need to configure it to internal pull-up, other-
wise whenever the pin is configured as INPUT and we try to
control it externally the value will always remain zero.

Signed-off-by: Iskander Amara <iskander.amara@theobroma-systems.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi
index c08e69391c01..06f3e97af7cd 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi
@@ -426,6 +426,16 @@ &pwm2 {
 };
 
 &pinctrl {
+	pinctrl-names = "default";
+	pinctrl-0 = <&q7_thermal_pin>;
+
+	gpios {
+		q7_thermal_pin: q7-thermal-pin {
+			rockchip,pins =
+				<0 RK_PA3 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+	};
+
 	i2c8 {
 		i2c8_xfer_a: i2c8-xfer {
 			rockchip,pins =
-- 
2.34.1