Received-SPF: pass (google.com: domain of linux-kernel+bounces-96710-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Fri, 8 Mar 2024 10:56:30 +0200 (EET)
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
cc: corentin.chary@gmail.com, luke@ljones.dev, 
    Hans de Goede <hdegoede@redhat.com>, platform-driver-x86@vger.kernel.org, 
    LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: asus-wmi: Consider device is absent when
 the read is ~0
In-Reply-To: <20240308053255.224496-1-kai.heng.feng@canonical.com>
Message-ID: <2186f344-a3dc-33f2-388a-55f91f31f775@linux.intel.com>
References: <20240308053255.224496-1-kai.heng.feng@canonical.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-796059183-1709888190=:1046"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-796059183-1709888190=:1046
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Fri, 8 Mar 2024, Kai-Heng Feng wrote:

> AAEON PICO-TGU4 board doesn't have any LED but there are bogus LED
> controls under /sys/class/leds:
> $ ls /sys/class/leds
> asus::kbd_backlight asus::lightbar  platform::micmute
>=20
> The reason is that the ~0 read from asus_wmi_get_devstate() is treated
> as a valid state, in truth it means the device is absent.
>=20
> So filter out ~0 read to prevent bogus LED controls being created.
>=20
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

--=20
 i.

--8323328-796059183-1709888190=:1046--