Received-SPF: pass (google.com: domain of linux-kernel+bounces-96720-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <efd45d3a-9f8d-4a37-af80-3ed2392cbc7d@amd.com>
Date: Fri, 8 Mar 2024 10:01:23 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] phy: xilinx: Convert to platform remove callback
 returning void
Content-Language: en-US
To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Vinod Koul <vkoul@kernel.org>, Kishon Vijay Abraham I <kishon@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
 linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
References: <57a3338a1cec683ac84d48e00dbf197e15ee5481.1709886922.git.u.kleine-koenig@pengutronix.de>
From: Michal Simek <michal.simek@amd.com>
Autocrypt: addr=michal.simek@amd.com; keydata=
 xsFNBFFuvDEBEAC9Amu3nk79+J+4xBOuM5XmDmljuukOc6mKB5bBYOa4SrWJZTjeGRf52VMc
 howHe8Y9nSbG92obZMqsdt+d/hmRu3fgwRYiiU97YJjUkCN5paHXyBb+3IdrLNGt8I7C9RMy
 svSoH4WcApYNqvB3rcMtJIna+HUhx8xOk+XCfyKJDnrSuKgx0Svj446qgM5fe7RyFOlGX/wF
 Ae63Hs0RkFo3I/+hLLJP6kwPnOEo3lkvzm3FMMy0D9VxT9e6Y3afe1UTQuhkg8PbABxhowzj
 SEnl0ICoqpBqqROV/w1fOlPrm4WSNlZJunYV4gTEustZf8j9FWncn3QzRhnQOSuzTPFbsbH5
 WVxwDvgHLRTmBuMw1sqvCc7CofjsD1XM9bP3HOBwCxKaTyOxbPJh3D4AdD1u+cF/lj9Fj255
 Es9aATHPvoDQmOzyyRNTQzupN8UtZ+/tB4mhgxWzorpbdItaSXWgdDPDtssJIC+d5+hskys8
 B3jbv86lyM+4jh2URpnL1gqOPwnaf1zm/7sqoN3r64cml94q68jfY4lNTwjA/SnaS1DE9XXa
 XQlkhHgjSLyRjjsMsz+2A4otRLrBbumEUtSMlPfhTi8xUsj9ZfPIUz3fji8vmxZG/Da6jx/c
 a0UQdFFCL4Ay/EMSoGbQouzhC69OQLWNH3rMQbBvrRbiMJbEZwARAQABzSlNaWNoYWwgU2lt
 ZWsgKEFNRCkgPG1pY2hhbC5zaW1la0BhbWQuY29tPsLBlAQTAQgAPgIbAwULCQgHAgYVCgkI
 CwIEFgIDAQIeAQIXgBYhBGc1DJv1zO6bU2Q1ajd8fyH+PR+RBQJkK9VOBQkWf4AXAAoJEDd8
 fyH+PR+ROzEP/1IFM7J4Y58SKuvdWDddIvc7JXcal5DpUtMdpuV+ZiHSOgBQRqvwH4CVBK7p
 ktDCWQAoWCg0KhdGyBjfyVVpm+Gw4DkZovcvMGUlvY5p5w8XxTE5Xx+cj/iDnj83+gy+0Oyz
 VFU9pew9rnT5YjSRFNOmL2dsorxoT1DWuasDUyitGy9iBegj7vtyAsvEObbGiFcKYSjvurkm
 MaJ/AwuJehZouKVfWPY/i4UNsDVbQP6iwO8jgPy3pwjt4ztZrl3qs1gV1F4Zrak1k6qoDP5h
 19Q5XBVtq4VSS4uLKjofVxrw0J+sHHeTNa3Qgk9nXJEvH2s2JpX82an7U6ccJSdNLYbogQAS
 BW60bxq6hWEY/afbT+tepEsXepa0y04NjFccFsbECQ4DA3cdA34sFGupUy5h5la/eEf3/8Kd
 BYcDd+aoxWliMVmL3DudM0Fuj9Hqt7JJAaA0Kt3pwJYwzecl/noK7kFhWiKcJULXEbi3Yf/Y
 pwCf691kBfrbbP9uDmgm4ZbWIT5WUptt3ziYOWx9SSvaZP5MExlXF4z+/KfZAeJBpZ95Gwm+
 FD8WKYjJChMtTfd1VjC4oyFLDUMTvYq77ABkPeKB/WmiAoqMbGx+xQWxW113wZikDy+6WoCS
 MPXfgMPWpkIUnvTIpF+m1Nyerqf71fiA1W8l0oFmtCF5oTMkzsFNBFFuvDEBEACXqiX5h4IA
 03fJOwh+82aQWeHVAEDpjDzK5hSSJZDE55KP8br1FZrgrjvQ9Ma7thSu1mbr+ydeIqoO1/iM
 fZA+DDPpvo6kscjep11bNhVa0JpHhwnMfHNTSHDMq9OXL9ZZpku/+OXtapISzIH336p4ZUUB
 5asad8Ux70g4gmI92eLWBzFFdlyR4g1Vis511Nn481lsDO9LZhKyWelbif7FKKv4p3FRPSbB
 vEgh71V3NDCPlJJoiHiYaS8IN3uasV/S1+cxVbwz2WcUEZCpeHcY2qsQAEqp4GM7PF2G6gtz
 IOBUMk7fjku1mzlx4zP7uj87LGJTOAxQUJ1HHlx3Li+xu2oF9Vv101/fsCmptAAUMo7KiJgP
 Lu8TsP1migoOoSbGUMR0jQpUcKF2L2jaNVS6updvNjbRmFojK2y6A/Bc6WAKhtdv8/e0/Zby
 iVA7/EN5phZ1GugMJxOLHJ1eqw7DQ5CHcSQ5bOx0Yjmhg4PT6pbW3mB1w+ClAnxhAbyMsfBn
 XxvvcjWIPnBVlB2Z0YH/gizMDdM0Sa/HIz+q7JR7XkGL4MYeAM15m6O7hkCJcoFV7LMzkNKk
 OiCZ3E0JYDsMXvmh3S4EVWAG+buA+9beElCmXDcXPI4PinMPqpwmLNcEhPVMQfvAYRqQp2fg
 1vTEyK58Ms+0a9L1k5MvvbFg9QARAQABwsF8BBgBCAAmAhsMFiEEZzUMm/XM7ptTZDVqN3x/
 If49H5EFAmQr1YsFCRZ/gFoACgkQN3x/If49H5H6BQ//TqDpfCh7Fa5v227mDISwU1VgOPFK
 eo/+4fF/KNtAtU/VYmBrwT/N6clBxjJYY1i60ekFfAEsCb+vAr1W9geYYpuA+lgR3/BOkHlJ
 eHf4Ez3D71GnqROIXsObFSFfZWGEgBtHBZ694hKwFmIVCg+lqeMV9nPQKlvfx2n+/lDkspGi
 epDwFUdfJLHOYxFZMQsFtKJX4fBiY85/U4X2xSp02DxQZj/N2lc9OFrKmFJHXJi9vQCkJdIj
 S6nuJlvWj/MZKud5QhlfZQsixT9wCeOa6Vgcd4vCzZuptx8gY9FDgb27RQxh/b1ZHalO1h3z
 kXyouA6Kf54Tv6ab7M/fhNqznnmSvWvQ4EWeh8gddpzHKk8ixw9INBWkGXzqSPOztlJbFiQ3
 YPi6o9Pw/IxdQJ9UZ8eCjvIMpXb4q9cZpRLT/BkD4ttpNxma1CUVljkF4DuGydxbQNvJFBK8
 ywyA0qgv+Mu+4r/Z2iQzoOgE1SymrNSDyC7u0RzmSnyqaQnZ3uj7OzRkq0fMmMbbrIvQYDS/
 y7RkYPOpmElF2pwWI/SXKOgMUgigedGCl1QRUio7iifBmXHkRrTgNT0PWQmeGsWTmfRit2+i
 l2dpB2lxha72cQ6MTEmL65HaoeANhtfO1se2R9dej57g+urO9V2v/UglZG1wsyaP/vOrgs+3
 3i3l5DA=
In-Reply-To: <57a3338a1cec683ac84d48e00dbf197e15ee5481.1709886922.git.u.kleine-koenig@pengutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WG5oeitYbVM1WU5FQkF1VUlIODg3eGxNN3l2NEx6NVIxUG1lb1lxdExCUmhn?=
 =?utf-8?B?Y3lLUlAvVyttL0pKNEtrQmtCSTlwMCtMWmR5ODBOT3VXMytEdHJuWXdBcVhs?=
 =?utf-8?B?RkU2TGFTQy96SXVsK2RaSmVEQVJUUDlkaWhQMzZDSG1DbjFIRCtSZ3JFQ3Bk?=
 =?utf-8?B?SStDaEN2TUI4ZWU3MXpMK2FwN2h5UWNhLzhDNzVLYjM2OTNCVkZSdkZKZmhK?=
 =?utf-8?B?cEVHMUtJRWVUZktFUU9LTFdmRitOVkxWSXFVWEdNMXFZSFYxNHdmTzY5ZnVT?=
 =?utf-8?B?T2NyUHZGQ0ZSa0tJN044QzlzK2x2M2RobVpPMzNoZWhjTEFCUnRhWXZqbXJ0?=
 =?utf-8?B?ZG1hb1ZBZjJvbGVaS0Q1dldSc3J0KzBnTjhiVzg1RTR2dnk5ellrTTZUNnRF?=
 =?utf-8?B?azRKaWhneFBlc2h5eGRrdmo1b3FXRXd1OE15Z0h6bVlUbzJwL1FRdWwweVlN?=
 =?utf-8?B?MjFnamZaN2I4UXRvT2d4bm5HTjQzbHZPM3c0OXExSUJLd1dsWVF5a0l3TkVu?=
 =?utf-8?B?SHUrdDl5UG9SR1hFaDdZUVNxdlFHVHEyRldRaCtJVTNkSXd6Y2NyRXlYSTUy?=
 =?utf-8?B?dzNGWXdlUmdpM3RGV2RSK3NyZ2lycGRtdjNSVGlSb1BxQXA5RUkwRFR0NGRo?=
 =?utf-8?B?S1ZCblh6ZkE0RisvS0xGdVl2YjljVDdEalFjRHU0QXRFQXRSdWFDeFBFa09N?=
 =?utf-8?B?NXVoZEVGL2hHT0NoTFBhTVFVaXZoaXZrQ0ZtTEtqbkErN3QxWVZLQkZDaDVT?=
 =?utf-8?B?WGV2cDY2ZUNMYTdka0FlRmZycjNhdlpTdW5GTTdLSDVibGZWclFYejhYL1p4?=
 =?utf-8?B?b1paMi9MSDhuS2VGN2t1V0hLcHB5Qk9jS2c5U0tpeEFiZitydFFSYmpBN0NU?=
 =?utf-8?B?KzZpQVFmRExoSjlqYXFMcmo0aWpJVXRnaW9mcWc4WXk3ZG43MklBU0VJc0lQ?=
 =?utf-8?B?MEdoSmZWYVNZNnJjYTZpSEo2WW9ORXdqWlIwTUNUaWZEM2k4RXRybGxMMTJm?=
 =?utf-8?B?M3VpZ2c5WG55UkQyWXdtckpvUFQrTHJ5OE9nQ1BEUitTKzZTbXp1OS9JcVpS?=
 =?utf-8?B?ajRObC9wVXRoRGdMSXBEbmhGYjAwNTFzSjNBUlNuMHpHRzBsM1FGMTBnNWli?=
 =?utf-8?B?cGFoaExZbEtXcDV1SWtBVTVwL01jWUxwamgvQUdwck00V0VCZGx4VkdPd2p4?=
 =?utf-8?B?Ti9VamNXM3RyWDlWWkVQMy9ZRFVqcmtaTWtDVk8zVEllMCtPcVl0Yzg5eU83?=
 =?utf-8?B?QkFpVm5TczFoelZtRFpZQndtalg2VG1lMGJjeU9jbGRxb3VJcTNXQUNoR1ha?=
 =?utf-8?B?OFAzWVF0SW5xY095NHd3RytaTnA2UllMWlUvTHNXaWtCNGFqbXVUWFJ6cGFE?=
 =?utf-8?B?eUhLb3JJM3B4eWJjVHhJcDlpb0JkT2FYTXFnMGxRdDNCalZtMXBWaHVHWVUx?=
 =?utf-8?B?S1lBSSt6bzZUaDFLODI3M0tjSURVUmxUYVlUUXJDQmlRaEdLV3RhUFZVOEJn?=
 =?utf-8?B?aFFLTTZOUWJXMis1RHFUOG5RQ0kwSXR5VVNhODFUZmtGTVl5Snh3V3FQdEx3?=
 =?utf-8?B?REQ4ZkdGa1puaHRMQWQ0d0VzR24rTXVqb3NyVHNzcStFKzJyQzcwU3dseVE1?=
 =?utf-8?B?TXlLcWRLdElGQUp3VGtGeTl5NUtRazNTWUtQNnpEL0c0WVRuV0ZLT3lkMGhF?=
 =?utf-8?B?THVSckVoRUZwais1RTdtbFoyNEUzRm9PY1hZOXg2UWRpWEw4L3ZxL3FkRUJH?=
 =?utf-8?B?Undud2t4T3hqaVUzZ0VVMXhSei9pV0hsYitzN09UNDEwQVQzOS81ZGdvSXVr?=
 =?utf-8?B?eU9pQTdSQ1d0UnVtTExlNjRqUi9TUHJQRFQxTkllelJRdWtJaFUyaEh6VGVk?=
 =?utf-8?B?SVljcmdBQjZjdXZQR0Q4WXVoaTQxZDAvVDJ2NWljSncwNjVnZGk3UXZrN1k0?=
 =?utf-8?B?VXNlbE9tMEdEclZkNHNJdmxVUWxCaFRzVTZkSmNYWksvMlk2d0M4bHhsczRW?=
 =?utf-8?B?MWhLa3BNWFRLOWhqTis3a2FIbXQzMlBSc1lmMHFraTg4Q3NBejA4WmswM0R4?=
 =?utf-8?B?SWEwM3B3eGV4bG52QUxlNTRnUHU4Z0dpcEhZZUV4VGtqMCs5QXNXZC9xcnBY?=
 =?utf-8?Q?3FTxm0bOBe/tKAusJ2yLQc36D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6b9531e-84b5-4bea-9dea-08dc3f4e5bcf
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8109.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 09:01:36.2746
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gC4A5NGxiHAgb62k6FGb2Vafq7AfMN+h43G5Deb3US67UBcCJBPE2++U0v/pYTQH
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7614


On 3/8/24 09:51, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>   drivers/phy/xilinx/phy-zynqmp.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqmp.c
> index f72c5257d712..dc8319bda43d 100644
> --- a/drivers/phy/xilinx/phy-zynqmp.c
> +++ b/drivers/phy/xilinx/phy-zynqmp.c
> @@ -995,15 +995,13 @@ static int xpsgtr_probe(struct platform_device *pdev)
>   	return 0;
>   }
>   
> -static int xpsgtr_remove(struct platform_device *pdev)
> +static void xpsgtr_remove(struct platform_device *pdev)
>   {
>   	struct xpsgtr_dev *gtr_dev = platform_get_drvdata(pdev);
>   
>   	pm_runtime_disable(gtr_dev->dev);
>   	pm_runtime_put_noidle(gtr_dev->dev);
>   	pm_runtime_set_suspended(gtr_dev->dev);
> -
> -	return 0;
>   }
>   
>   static const struct of_device_id xpsgtr_of_match[] = {
> @@ -1015,7 +1013,7 @@ MODULE_DEVICE_TABLE(of, xpsgtr_of_match);
>   
>   static struct platform_driver xpsgtr_driver = {
>   	.probe = xpsgtr_probe,
> -	.remove	= xpsgtr_remove,
> +	.remove_new = xpsgtr_remove,
>   	.driver = {
>   		.name = "xilinx-psgtr",
>   		.of_match_table	= xpsgtr_of_match,
> 
> base-commit: 8ffc8b1bbd505e27e2c8439d326b6059c906c9dd

Acked-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal