Received-SPF: pass (google.com: domain of linux-kernel+bounces-96727-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <ab7c8dde-c914-4e07-a95a-126976917416@amd.com>
Date: Fri, 8 Mar 2024 10:09:34 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/2] drm/amdgpu: add vm fault information to
 devcoredump
Content-Language: en-US
To: Sunil Khatri <sunil.khatri@amd.com>,
 Alex Deucher <alexander.deucher@amd.com>,
 Shashank Sharma <shashank.sharma@amd.com>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
 linux-kernel@vger.kernel.org, Mukul Joshi <mukul.joshi@amd.com>,
 Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
References: <20240307205054.3904657-1-sunil.khatri@amd.com>
 <20240307205054.3904657-3-sunil.khatri@amd.com>
From: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
In-Reply-To: <20240307205054.3904657-3-sunil.khatri@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dUpjaGdUaDI5dTFZMWxHdXRZMnFMZ1YvUlhNNHBYUlBqMjg0R0JlNzEwNEww?=
 =?utf-8?B?YkVHcWVyQ3VTaUpHYmJvVDl4cyt4MDVpNnlUeTVGRGNURThIVEhSMUt6dHpK?=
 =?utf-8?B?L0FmSVNORnVQS1RkakZoakFrVi9uTDdIMTN5amVab3R2R2I5b1l2Y3YrNHhv?=
 =?utf-8?B?RndibzEwSXJGR3pESkg4SWo3bVFiY2FRaGdYWXloTnlESWEvN2c3UW5zblkz?=
 =?utf-8?B?aW02YlFFRUI1enNrdEx0NHZheTk5aWVYM25uNXJ2SXU1K0prem1BTU9DdEtl?=
 =?utf-8?B?eHN2R1Q2bUswaFhYdWVVK2tLelpHditCY0ZjUUg4ejYvOW5XSVdjTTd5c2Y0?=
 =?utf-8?B?NFhxSEdXMUpTNkNjeHkyS0RwOVFlL0NjS3oycmNPY05sMmRVaTlTMHlEU0hE?=
 =?utf-8?B?ZTU3dFd2VUFpalpETEZZMVA5dWhYU0xDVTNwU1F3RXIxU3ppNW40aXByWU5P?=
 =?utf-8?B?TlQzcW9INkJBODIzaTdQWjlGd3JreTVzL2lQbHYzcnhRR0swZ1QwRXNjelNU?=
 =?utf-8?B?UXV0ZkFrbTU0RlM1NVRaTnR6TVJnc080Mm9qeml1TUFiVGpiQ2Fva29rNTA3?=
 =?utf-8?B?Vm1ZMzNXYnYyVE9TcnR3WDJNTTVySWJ4WEkwbVFSMmxMRFVncVhjMWdUN1Bn?=
 =?utf-8?B?UVkrNHZTZGFRMEZrNXpTcXFGSGIremdubzJLdHcxMFlRZlhIU3B6Q2hwbVRp?=
 =?utf-8?B?Um81dWNEdndEeVFKYVUzbU9CREp5V253bkxzM25zNmk4dGpzdFkwWmNva2pn?=
 =?utf-8?B?dEpOOG9GdWN3cWFlbC9WYkpwQW1uaFhHN0F6c1FMcnZYSEs2QzRkYkVjeHJk?=
 =?utf-8?B?VWpVaGhmS2ZoeU5Fa09JdVpySWZtbmx6dFllRG12eU84SEo4a0phK0VFUkdP?=
 =?utf-8?B?MVJuaGdUMUNvajluSWV5U1JVYjQ0Y25aTUcyRXZVUEdxU0NKY3ZjeWhnbnd2?=
 =?utf-8?B?NjBBTzlBblFyVVlwc3RkNU05bGJCZlNHbVJTeGt2MEZadmNKRE1jYTdqbElZ?=
 =?utf-8?B?dlY4SzIvVXJPQWFOM3VZUFNMY1VMeXpTSFdxR25TZDNSMStjZUtmc1FuL3g0?=
 =?utf-8?B?Skt5dEhPY2ZlT203ZHJBa0ZTUGRxanJoMVh6WEo0VWNlRUZYNUpSNkFZTVdy?=
 =?utf-8?B?cFBvdWcxY2htb1NCclJHSFR2K1c4a1NTSTlFRWIxblZmVmFGZ2pEcnhjQVVP?=
 =?utf-8?B?YmZzdFJpMlloMWI0WDVlZjJ0SWlKZjd0RTJVRi8xM0laVk5lZDFFbFRrTXBT?=
 =?utf-8?B?NUkyNnVRZHVZNnlMdW5pMzJEaitrenpJZ1d0bnZha0kwK2pzZ1JxMm9pR1JM?=
 =?utf-8?B?SHBjc04vV0puSjBjaUs1bkoyd0F2MDdSbzBlL01INmpZSjZDTVUzNEEvZmg4?=
 =?utf-8?B?dmJmbXgzZXhoQkJlM1lJajluMFhVZFhiL01aanRxOGgrMmtabEczcnNvZlhj?=
 =?utf-8?B?M0ZYWldBcjNxNHEwd2JFSzBYSDJ1UUhCSlJ6NFBMam1scTFKalNuQW1BUXNS?=
 =?utf-8?B?NVdVTHVmUEJXMXliclByNzFRalFlN1F5SDNPQy9XZElIaFZTOU8xVzN3WHhz?=
 =?utf-8?B?NXNjSDd3TjhqZk1JdllkUHRsUXRXejM1REQxMmY1TXhkQ2JpSm5wZU81WVFY?=
 =?utf-8?B?azZwV3NpNGhqUnRsVHljWTM3R3lEU0tLU2xPenhHZ0tpVTlkWFZzY0o1NDcy?=
 =?utf-8?B?c0dsQm56T2NFUExHTENJc0l3UHFwWkpJVTh0ZHhYNzNmSkd0WnM3WGcvb0Vm?=
 =?utf-8?B?OHY3UWlqV2o2T1J0YzdhcTY5azc0eGpvTGgrK05aQzJPYmRGTzZINUtodTFW?=
 =?utf-8?B?QXV1cWh6M1pGL1hCVUVjN3VKbC9mc1NvbEJXQjM2YkZSVDFaV282Y29BZTAy?=
 =?utf-8?B?ZFpoSjdhNnN0NXl0ODhCa2ZhSFZ5U09LaW9hdHdvM3RaUEJDN2dLZXdCS29E?=
 =?utf-8?B?ZUhWUThqTXd2cE50QThLbW9nOWdscGVnV29MU1N5QlVKaW5kSjdRMWhFVVlJ?=
 =?utf-8?B?QlFubSt0ZHQ0Z254cmZiTkxjM1F6dlFBSk1oQjRMU3NiT3NPbEdVN09JaUVW?=
 =?utf-8?B?enJrNlZSUnpMc2ZKTk43Y1UxbzJhb0c4ZUQ3dWhpTXplQTUxOWlBN28wT0Qr?=
 =?utf-8?Q?g0wBRaCCARAZz4KDRG1RmSy8R?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f0c8874-5f29-4e46-84f0-08dc3f4f7c69
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5685.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 09:09:40.3511
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oEfB4/Jb/jG5kOdF79+w9vaoW/9943os9NYmSLh+c07M5doKTQcT1CyInlFEemwH
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6100

Am 07.03.24 um 21:50 schrieb Sunil Khatri:
> Add page fault information to the devcoredump.
>
> Output of devcoredump:
> **** AMDGPU Device Coredump ****
> version: 1
> kernel: 6.7.0-amd-staging-drm-next
> module: amdgpu
> time: 29.725011811
> process_name: soft_recovery_p PID: 1720
>
> Ring timed out details
> IP Type: 0 Ring Name: gfx_0.0.0
>
> [gfxhub] Page fault observed
> Faulty page starting at address: 0x0000000000000000
> Protection fault status register: 0x301031
>
> VRAM is lost due to GPU reset!
>
> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 14 +++++++++++++-
>   1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
> index 147100c27c2d..8794a3c21176 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
> @@ -203,8 +203,20 @@ amdgpu_devcoredump_read(char *buffer, loff_t offset, size_t count,
>   			   coredump->ring->name);
>   	}
>   
> +	if (coredump->adev) {
> +		struct amdgpu_vm_fault_info *fault_info =
> +			&coredump->adev->vm_manager.fault_info;
> +
> +		drm_printf(&p, "\n[%s] Page fault observed\n",
> +			   fault_info->vmhub ? "mmhub" : "gfxhub");
> +		drm_printf(&p, "Faulty page starting at address: 0x%016llx\n",
> +			   fault_info->addr);
> +		drm_printf(&p, "Protection fault status register: 0x%x\n",
> +			   fault_info->status);
> +	}
> +
>   	if (coredump->reset_vram_lost)
> -		drm_printf(&p, "VRAM is lost due to GPU reset!\n");
> +		drm_printf(&p, "\nVRAM is lost due to GPU reset!\n");

Why this additional new line?

Apart from that looks really good to me.

Regards,
Christian.

>   	if (coredump->adev->reset_info.num_regs) {
>   		drm_printf(&p, "AMDGPU register dumps:\nOffset:     Value:\n");
>