Received-SPF: pass (google.com: domain of linux-kernel+bounces-96741-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <ffc940bf-b9df-4731-a34d-f725a6d6d7f1@theobroma-systems.com>
Date: Fri, 8 Mar 2024 10:25:43 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] arm64: dts: rockchip: enable internal pull-up for
 Q7_THRM# on RK3399 Puma
Content-Language: en-US
To: Iskander Amara <iskander.amara@theobroma-systems.com>,
 robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
 heiko@sntech.de, vahe.grigoryan@theobroma-systems.com,
 angelogioacchino.delregno@collabora.com, dsimic@manjaro.org,
 alexander.stein@ew.tq-group.com, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org,
 linux-kernel@vger.kernel.org
References: <20240308085243.69903-1-iskander.amara@theobroma-systems.com>
From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
In-Reply-To: <20240308085243.69903-1-iskander.amara@theobroma-systems.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RHVDc3Y3SVVvVEphbTFKTm1QcFp0UEwrWFlhelhvU2dHckJrSHlHQ3FhU29D?=
 =?utf-8?B?Z0dPY3V1Q2tJYk9SRjRvZ2phai9NYUVIM1JrVmRxMndTalpsRTZnSUpmZGN0?=
 =?utf-8?B?RVl5WStRUmMvVVlIM2crdVZvcG1Kblh2dUlaOE84Qm90NXM1N0cyelMxWmR2?=
 =?utf-8?B?UnB4VURSdGlhTHBvcDdSR3dVUGtYVXBIb3lObWdzMjkweWtldEl0OVhHM09U?=
 =?utf-8?B?QkUrQkh5MDB0Rk1Ib1dPUFFRQ3lEcjUxWVJzblNrM0Nkejh6cDVnRDlnNmo2?=
 =?utf-8?B?aWttM0pmOU13T0dFZm9KRW5BTWhwdlYyZkhCOXVDei85clA5NkhEZktGMzZN?=
 =?utf-8?B?K2daRWtvZlhlaUVTekV0YXB1Q1NuMDVmdkhlZ2NiVk5SL0tPeWVWQkVHeXg0?=
 =?utf-8?B?TUZkNVhndHhPZzVaMmQwR1pVNVc3TFFIL1d1M2xUSVo0cjF2cDl0am1RTjY0?=
 =?utf-8?B?Y3ZPeURkeDliM1dTKzRhWmVha1QvNUtISDllSlBkNmVYcTRScFlXUnV6OXUw?=
 =?utf-8?B?SjBJU3lEL1dqOHd5NUU0SzI2ci9qaWhHRFFBL2pqcXhmaE1uck9sTTB3U3pT?=
 =?utf-8?B?RFF0dEFWRHBIQUFJNnVmcFhVQ3oxcEVLLzZTVUZrWFNGcWVLaUZwRWp4OVdO?=
 =?utf-8?B?dXNyR21lcGJ5OGU3OG4xME80VEJtNGJEYnBLWGYxeE9NdjhxVDc3TE9UWnJh?=
 =?utf-8?B?a3hqQktNMmJUN2hySHRGbTliTlUwbzR2R2Q2N0pEVllML21EVDBmU3lUM1gx?=
 =?utf-8?B?T1lnMmV5WUoyaVg3c3U2VmplSVJFWlJaY0hXT25zdmVFak5MVzNUTFF5R0RU?=
 =?utf-8?B?bUVFUXFXUXJhYlhTV3ZDd1YxR1RPajlBaUdBQnU5NHRtNG1uOThLUEdneWcr?=
 =?utf-8?B?bkp6Y2VjVWhuQVI4ZnBCZ1M3V0kyMmNENzQveEVjRS9NZXNySFVSeUxRalY2?=
 =?utf-8?B?TmZlNXpVc0x2UU10OWRpQjJMWlJjOE4wVHU4TTlEWkphY3EwN1JMb2x2eG51?=
 =?utf-8?B?eDZqK29tSnk2dnl1M0JkdGo2L3J4TlJPeGQ2NlBsUnp4Um9Bb0lVL0R6TGUr?=
 =?utf-8?B?aHFZd2tGMFpjS2VSM0xEQXp3MEJGci90eHJnd2xDbnpjQUFFVVhtbyt3VzVC?=
 =?utf-8?B?YlNTMkNOazlyZ2R3NFhpZU12eUtNdVdqRmpkVU8rVHVCMDhReVlmM1NjdVlR?=
 =?utf-8?B?QkMxV0FSK0xwLzk2bEFXVmpPUFlsa1RMTnA0MDdEYzdaN2ZxM0hsSlNvOGpD?=
 =?utf-8?B?cW11UFZYaWorNEZJd2M2V2FrWFpMZklxNS9jM3RpN091UnFCRjlKZXlIdGUr?=
 =?utf-8?B?YWJZVHlUK0VQVXg2d2ZQZVYzd3c0L0w1L3dzaVZxV251VUdXdi8wUlJ4OWFR?=
 =?utf-8?B?cTczbFFReDhpaHF6MkFKSUF0bmlMSW9MMVM2ekN2YndwamJycHEwcnVyWHFY?=
 =?utf-8?B?VnU2UFlDR1ZWbzFUbmtJdjBhOWpHL2pPV1FOOXJxUjhoZFRic25BUmJaS1pv?=
 =?utf-8?B?Qi91L3VoRUZkMGsweDV0VWppUlZhWW5ub3R6aGx4enBZWDQwV0hmOW9RNkg1?=
 =?utf-8?B?bmNBa29GR3lmZG1aYWFBWmNENVpneWw1Wk9ueFlIeFRib0RIcEtWKytLWGpo?=
 =?utf-8?B?ZEg1NGx0eTMzbUFXdnlmUHZiaXk5VDlJWGU3d2tWeHl0SXlEc0NqOHVyYnRF?=
 =?utf-8?B?bmJSd1NTcHpOTWFLRk5qMlhHS0k0aERubC9TVjMwV3VjMXEzb3hJSXY1OHMr?=
 =?utf-8?B?T0NsYjJNUDhMUEZXYTY2SHlRWENjSXBnTWh0WHZUZkRUQkV0ZDNKdEc0T21E?=
 =?utf-8?B?Q3dqUkxIN3F2d3ovcHBaQ2dLQ09NOUYySko1dEdwSkxGbXl2SW4xNE5WVndz?=
 =?utf-8?B?azkxR0RFMUo0RmhoT0xucjNZby9ZdjJoa21ML01aRitUYm9GeW9NYUVFM01w?=
 =?utf-8?B?R1I1R2NTRWNEYkZyM3ZGY3FKeUlNNmE4Zm5XcVA3d0hOaG0zMDRmbnY4RVdX?=
 =?utf-8?B?bDlIcFFod2F1UmQvTGhEb09qeURoOEpMZENFRkpvWE9YWnF4OHUrOUpEMC9S?=
 =?utf-8?B?aitDN2ZlOVlRUUZMNlJzdS9UR0tRZklzbHJaMFdkQktNRHNNZlRxZGhITzds?=
 =?utf-8?B?VldzTUZqaUptV2E4OEFhK2ZnaUY5dE9waVgzdHBiUmRVcVZSTjJOakxJMm1K?=
 =?utf-8?Q?m4PI2HUjbZgOgf7/m/9I8d4=3D?=
X-OriginatorOrg: theobroma-systems.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eb3df95f-e8c6-4c88-5413-08dc3f51bbe1
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8536.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 09:25:45.8285
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U/gbvv0778EGIfZxSPpNfRLVtFKxdcuYoAKP0x0S2QeeAojQrPW8XguKnTfGQ16kd5CHIhG9BV/I9IhiK9ZH8wekSpoVQxU+HFDMw8YKHeUBG0VFsy7p4vU1a9ED8jzq
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9279

Hi Iskander,

On 3/8/24 09:52, Iskander Amara wrote:
> Q7_THRM# pin is connected to a diode on the module which is used
> as a level shifter, and the pin have a pull-down enabled by
> default. We need to configure it to internal pull-up, other-
> wise whenever the pin is configured as INPUT and we try to
> control it externally the value will always remain zero.
> 
> Signed-off-by: Iskander Amara <iskander.amara@theobroma-systems.com>

For the whole series:

Reviewed-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>

@Heiko I think this may match the criteria for stable backports?

Thanks,
Quentin