Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp429818lqc; Fri, 8 Mar 2024 01:30:08 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVJ19Nosve11IJpaIbWh379hVBVh9xr5bri/09FFO858L51Pv3wvOgnJJCIk/ARGNM6ZrdrtSAu4SJ1yks7VPxyL7+ICmsohN5tTfrAqg== X-Google-Smtp-Source: AGHT+IHmlMZ46GNpdiyCmJ4AGRPnK/z4g6FSEQkPxb0SwFM4dvM8mapfd3kMZaBuEGzIVcG8+M3I X-Received: by 2002:a17:906:a896:b0:a45:bcac:7794 with SMTP id ha22-20020a170906a89600b00a45bcac7794mr4823022ejb.28.1709890207774; Fri, 08 Mar 2024 01:30:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709890207; cv=pass; d=google.com; s=arc-20160816; b=RYzi1NE7vNMdoWjATx3Qr9VwcQ41LhCmPvY9XD8vK61Fu6yU+oYl34B+lF7K4dY7FH b2YJN3hH7Bm41jcAbNubzhn7pGj88jpcQzdEcHTiPwP3ZdhRt+MffJ25y17+OSWW/e6d 2/z5HOEOD+5wBg1W4Ff0qjayWcJ8JmbshBs6q8osfhEUsPe4QDGYLb15w8Sae54v6BAS /qYqCz5r8KLmJCqsqhxjlCverkWmHx/YDSeVsbrTQ44+RTurtwth8qob2hYc97EBae3c +vdgKD7XpYpYt1JgEER3uDUERTYl/SgmtNlT7/He1b+hQr9kV2XoopiGXtXG7qrCEEdX spPw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:to:from; bh=786vdokxTRB7TIzU3GEVcMj1xNGQkjpS6CAsEOD9jyU=; fh=TGKsJl4ymozxb7PHh3ImZdOkp9jKMcBik1vB6eRjEFo=; b=pDy8E6Cu+7riWRxHZenxLJfXlVGoARt/ZW44cPSD/lAGxVQ3NahYFIHnf0+igGXS28 GWSmUfj3XH+yaGL3Ud/vHp/qin373Pqk2wGrpWDWKRkvtnZ8V6KoF3GyjbSTnQKKWX0U d1XlGpzgnBf4jEb548qGBQ06Ti7pa4tNUnfSTVt3BzpbYUWVspHZMxtmBYVyGVdCrzaY B7Q+yxNvwg6SWOnF6RcEeAIgAtmkaW4Ena7qi2WjrxqLQ0ZtN0Owt61WHEtRAK31+Uyt NyQgqs3G87zw6A3GWel6OGcmIth7M3HNTtLgWjy6EH2ZhocyhA+recl4MXbL6rp/MkqP HdCA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=sntech.de dmarc=pass fromdomain=sntech.de); spf=pass (google.com: domain of linux-kernel+bounces-96746-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96746-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=sntech.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id b2-20020a17090630c200b00a45e160325bsi844939ejb.523.2024.03.08.01.30.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 01:30:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-96746-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=sntech.de dmarc=pass fromdomain=sntech.de); spf=pass (google.com: domain of linux-kernel+bounces-96746-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96746-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=sntech.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6924C1F23AF7 for ; Fri, 8 Mar 2024 09:30:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7BB01535A8; Fri, 8 Mar 2024 09:29:56 +0000 (UTC) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96B16535A0; Fri, 8 Mar 2024 09:29:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709890196; cv=none; b=tvH1TyAHsWKReHnnVSaXYzTh/EerCXFyggkr1oB2Yy9BFQ0nOtaXjSVqfw2Xn0GOTDMDEzKVU+mCdxvkMs5xhuLM3RWcaBz8F/fU1bdFZ7/bJQlU7sIL0efLt5y4NRmvQ7k9iAd8lhyTbeOV86h8LcBAHLKfxqe4Tw8lr3qLZVU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709890196; c=relaxed/simple; bh=786vdokxTRB7TIzU3GEVcMj1xNGQkjpS6CAsEOD9jyU=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FpRX5/AaBVmvguSzk5H3OnjMDNTMQ0W+y7MT7y0AbZ1uF/LGx4mBy35DJ2u9dIFmpjcYfrjKouWcewVNP87hN7jfdmps8TZ7LXbvsiptxL1kwtziHloCfR0WTZlLpX4PNTG+YKvPYF7o2AEhnXTAgnEDu6v0MTun6RuNntsQwUA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Received: from i53875a9e.versanet.de ([83.135.90.158] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1riWXu-0006Te-Rf; Fri, 08 Mar 2024 10:29:42 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Iskander Amara , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, vahe.grigoryan@theobroma-systems.com, angelogioacchino.delregno@collabora.com, dsimic@manjaro.org, alexander.stein@ew.tq-group.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Quentin Schulz Subject: Re: [PATCH 1/2] arm64: dts: rockchip: enable internal pull-up for Q7_THRM# on RK3399 Puma Date: Fri, 08 Mar 2024 10:29:41 +0100 Message-ID: <24965019.EfDdHjke4D@diego> In-Reply-To: References: <20240308085243.69903-1-iskander.amara@theobroma-systems.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Am Freitag, 8. M=E4rz 2024, 10:25:43 CET schrieb Quentin Schulz: > Hi Iskander, >=20 > On 3/8/24 09:52, Iskander Amara wrote: > > Q7_THRM# pin is connected to a diode on the module which is used > > as a level shifter, and the pin have a pull-down enabled by > > default. We need to configure it to internal pull-up, other- > > wise whenever the pin is configured as INPUT and we try to > > control it externally the value will always remain zero. > >=20 > > Signed-off-by: Iskander Amara >=20 > For the whole series: >=20 > Reviewed-by: Quentin Schulz >=20 > @Heiko I think this may match the criteria for stable backports? at least patch1 does ... it definitly should have a Fixes tag though.