Received-SPF: pass (google.com: domain of linux-kernel+bounces-96750-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <43d84aa9-ce0f-406e-82ac-2a691264ee23@theobroma-systems.com>
Date: Fri, 8 Mar 2024 10:33:51 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] arm64: dts: rockchip: enable internal pull-up for
 Q7_THRM# on RK3399 Puma
Content-Language: en-US
To: =?UTF-8?Q?Heiko_St=C3=BCbner?= <heiko@sntech.de>,
 Iskander Amara <iskander.amara@theobroma-systems.com>, robh+dt@kernel.org,
 krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
 vahe.grigoryan@theobroma-systems.com,
 angelogioacchino.delregno@collabora.com, dsimic@manjaro.org,
 alexander.stein@ew.tq-group.com, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org,
 linux-kernel@vger.kernel.org
References: <20240308085243.69903-1-iskander.amara@theobroma-systems.com>
 <ffc940bf-b9df-4731-a34d-f725a6d6d7f1@theobroma-systems.com>
 <24965019.EfDdHjke4D@diego>
From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
In-Reply-To: <24965019.EfDdHjke4D@diego>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Wlo3NldQUHFIMkJQUExjVmZBRlMzd1pIZDFNdFl6MmdrbTBIZWYxWHBDYlE4?=
 =?utf-8?B?a1NkSHo1VTZtUW82YktVRVZKK2c3d1IvMzU3L0JVaW8vNEFBaDFwVWNKRGg5?=
 =?utf-8?B?dldweER6Y2RwMlhpVHhQVFU1OE9HRzJSL3FrZWpzcVdmNXhoKzgrdHdHTFBZ?=
 =?utf-8?B?MkJDcjJtMFY0UWRZRFZvRHFyV1IzOVJ1SGlBWGljZytZYXluZWFnbWo1cVJy?=
 =?utf-8?B?RlQ5QTAxRTRKK1NoOVpXWmRCc21KczhHSFFBZXBFYXVkdnIwNWh2YVY2eHdP?=
 =?utf-8?B?SlR0Sysva3dBdWhFK0xjNnI4YjV5WmF0aFhrSW5sdVNXclVMNjJicE9CUW1J?=
 =?utf-8?B?K3Z0R2o0T0NqTjlFV0tHMWxZaVNZUTJEOUlDcHkrRE9TczgwMTJ4OUJiREU3?=
 =?utf-8?B?eTdCUno0Y1EwWGQ1L1F0RVZ1aXk4UkcwZUFEeU9UeUsvT3VhSWY3eTg4dXha?=
 =?utf-8?B?SkcwUllYYWxmTE9TVSs2WEM3SEtLNEZOSERja1N6dUpoWGEyaUluNGdEOWJz?=
 =?utf-8?B?eTc4OXlKeElJeW91ZEhzdW1VZ3NtUkhmSldaTTZYdXRDNGVTT0huc1VnUVVZ?=
 =?utf-8?B?ZU9qNnhRaExZSTYxS2NMTUZSNmZmSzlOZWZBWnlHU2JBWUY1eHdGbEVVQjl0?=
 =?utf-8?B?d0o4Skx2Z3pubWw4dmZTUmpIbHdkSDRPYWRjRjNJcU5KUzlyRHhubERBVU9Q?=
 =?utf-8?B?TS94ano5YVpHUERSRXdpNSt3ak1rT3pzaXAwMUQxb0xZY3VTeEE5cnlBZCt5?=
 =?utf-8?B?M3U4S3BTa1ZtZnUrc1VSbHpPa0RNTXFmUHhTaEwyb1JhZVdtaXk2ZHdpOUdY?=
 =?utf-8?B?S3d2V0VCbXBzRXRXQWNUYkNzTzRpdk9FN3hRZCtPMGJBQmJFbW5QM2pHanJP?=
 =?utf-8?B?Q0txMXBnNEF1S1RYQ1h0ZXZEUjRZUmZNRjNwNWs1dXFPVlhWYzV1TDJFQit2?=
 =?utf-8?B?N3NwbnBmaEtkYnlCZyt1MVFURHNSMXV6aGlDTmxzWkhMbFF5QjFTOE9ncEVz?=
 =?utf-8?B?SWVLTjAwSlV0UEpMQ1FrcXJtTlZScFlJVmZCaDFRUStqQzVTM3pVWi9PK2sz?=
 =?utf-8?B?RGJuNW5lNkhXTEVqemNIOUJRaERnbnFaQndEVGFMTFRlaTJrK1VHMUovNmdW?=
 =?utf-8?B?WCtlak85eEczQytvei9yRkFTRUNZM1poakxpSkhadEdTc0hHUEdybWxHcDZs?=
 =?utf-8?B?WWx4dmY0S2wzRWxISk05dUNKampvTnhiN0w5bFRINUNHU0VIZWhZbXVwVG9a?=
 =?utf-8?B?dE43SzEvV3RkRE5OSFA0MVFtSkZkQktPNkF5WDN4QkFrbGhPdlFTVU5qQldx?=
 =?utf-8?B?R1Ard2ZLeHZQU2VrZGN4T0p6STVGaGU3bW4yUnNvR3Q4MlRwTXY5TEtLVnJN?=
 =?utf-8?B?NncrbnJHbUgrRlhaNzh2K1J0RWtmM04raElXYWdNYlZLUENZQnR1S3FhWldG?=
 =?utf-8?B?RVF5c1J0bFVVZXpERGhndEtQMVZZV3hSd1k4bUcyUndnUGdBRjhYZGxUcjlT?=
 =?utf-8?B?REJDV2VpaGFpNFFIdnZTZ2FUQkNSeVpzb3NzR1pvNVpFeGlFeFBlZHBPa1BH?=
 =?utf-8?B?SFlmRmtmMXM3MmR1b0xLSEMvaXRLMlpkUmpyekFIcCtialNZRUFCLy9aY0xO?=
 =?utf-8?B?NHpBKzFPeFBsTVVoMHRNNVhzdmVqb1laaWtMZCs1VGIyNVJTZjk2VHg2NGtD?=
 =?utf-8?B?cDFBYmU5QWRqYVAyd3IzZEE0TlZxaGdmYVhXTnZOOVZheW94MS92bWZ2UEFn?=
 =?utf-8?B?YzlGdnIxYkVFQ0V3c1ZoMnplTTkycVQ4Q3huSzNQWWc5eUhrdW55N0theTN3?=
 =?utf-8?B?ZWhvcWp3UE9LTDBrWU5BL241Lzh5STdSMU9BTkhUVHJnUEJhbHh6cDV1a1dD?=
 =?utf-8?B?Mk1sVHBQSmFaTEM1bW5BOW9KZkJjaEI3bzh4UGpJUVd1ZUdnZllTTDVZc2t5?=
 =?utf-8?B?Z21jL3B0N2VNTGcrMmdRbzdJczR1ajk1RDIwTS81a1RoRVAxTjlqRUtPRU03?=
 =?utf-8?B?UTFVOVBYOVM5S3k2cmNSTVFpUDRsaG1VWHAwN1VybXBhR1phMVpPS3RMQXFt?=
 =?utf-8?B?MGpYWVhEUW42aHIza2lOMFhXeG5MUTNHcHp2RmxtTktmMFhRaWJIVHEzZDl5?=
 =?utf-8?B?YWpPNWFIcmRBSllMd1BhUWxGZVZSdE5KOGI0L2lBdmNManNyNjRDNXQvcHBK?=
 =?utf-8?Q?aP2cvF8DBjY0zzpJj4H+SxM=3D?=
X-OriginatorOrg: theobroma-systems.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 39206822-6515-4cf3-4fdc-08dc3f52de82
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8536.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 09:33:53.4560
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SVO7ws8qfr0OYy65VfkCoiJQD2bDhgVTyQO9j7D/tJUvo+kUX99AglL+9MsR5gv3rpQV+yrtbOiRba/4u/44/CupoxVwOcffDgGkATGFBhBeWVp809y8PCODeT0PfeXs
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6951

Hi Heiko,

On 3/8/24 10:29, Heiko Stübner wrote:
> Am Freitag, 8. März 2024, 10:25:43 CET schrieb Quentin Schulz:
>> Hi Iskander,
>>
>> On 3/8/24 09:52, Iskander Amara wrote:
>>> Q7_THRM# pin is connected to a diode on the module which is used
>>> as a level shifter, and the pin have a pull-down enabled by
>>> default. We need to configure it to internal pull-up, other-
>>> wise whenever the pin is configured as INPUT and we try to
>>> control it externally the value will always remain zero.
>>>
>>> Signed-off-by: Iskander Amara <iskander.amara@theobroma-systems.com>
>>
>> For the whole series:
>>
>> Reviewed-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>>
>> @Heiko I think this may match the criteria for stable backports?
> 
> at least patch1 does ... it definitly should have a Fixes tag though.
> 
> 

Fixes: 2c66fc34e945 ("arm64: dts: rockchip: add RK3399-Q7 (Puma) SoM")

I assume, since this issue existed since the introducing commit.

Cheers,
Quentin