Received-SPF: pass (google.com: domain of linux-kernel+bounces-96755-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <447cb805-9ad0-4e08-8038-45e3cb8c81fe@huawei.com>
Date: Fri, 8 Mar 2024 17:38:14 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
CC: <shaojijie@huawei.com>, "shenjian15@huawei.com" <shenjian15@huawei.com>,
	"wangjie125@huawei.com" <wangjie125@huawei.com>, "liuyonglong@huawei.com"
	<liuyonglong@huawei.com>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net 6/8] net: hns3: fix reset timeout under full functions
 and queues
To: Sunil Kovvuri Goutham <sgoutham@marvell.com>, "yisen.zhuang@huawei.com"
	<yisen.zhuang@huawei.com>, "salil.mehta@huawei.com" <salil.mehta@huawei.com>,
	"davem@davemloft.net" <davem@davemloft.net>, "edumazet@google.com"
	<edumazet@google.com>, "kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>
References: <20240307010115.3054770-1-shaojijie@huawei.com>
 <20240307010115.3054770-7-shaojijie@huawei.com>
 <BY3PR18MB4737FA1796C8BC8180296BE8C6202@BY3PR18MB4737.namprd18.prod.outlook.com>
From: Jijie Shao <shaojijie@huawei.com>
In-Reply-To: <BY3PR18MB4737FA1796C8BC8180296BE8C6202@BY3PR18MB4737.namprd18.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


on 2024/3/7 19:24, Sunil Kovvuri Goutham wrote:
>> In order to avoid the above extreme situations, the driver extends the reset
>> timeout to 1 second.
>>
> Reviewed-by: Sunil Goutham <sgoutham@marvell.com>
>
> But one observation, loop of udelay(1) for 1sec seems a lot, probably better to use usleep_range().

but this is protected by splock, so cannot use usleep_range().