Received-SPF: pass (google.com: domain of linux-kernel+bounces-96787-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date: Fri, 8 Mar 2024 10:59:56 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux-kernel@vger.kernel.org, Shrikanth Hegde <sshegde@linux.ibm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Valentin Schneider <vschneid@redhat.com>
Subject: Re: [PATCH 3/9] sched/balancing: Change 'enum cpu_idle_type' to have
 more natural definitions
Message-ID: <ZerhnPHeBSgd+XOk@gmail.com>
References: <20240304094831.3639338-1-mingo@kernel.org>
 <20240304094831.3639338-4-mingo@kernel.org>
 <CAKfTPtCu=_ys+FFTqKfZbu9f_yD69fN7L3nETykEK3y9TW3BmQ@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKfTPtCu=_ys+FFTqKfZbu9f_yD69fN7L3nETykEK3y9TW3BmQ@mail.gmail.com>


* Vincent Guittot <vincent.guittot@linaro.org> wrote:

> On Mon, 4 Mar 2024 at 10:48, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > The cpu_idle_type enum has the confusingly inverted property
> > that 'not idle' is 1, and 'idle' is '0'.
> >
> > This resulted in a number of unnecessary complications in the code.
> >
> > Reverse the order, remove the CPU_NOT_IDLE type, and convert
> > all code to a natural boolean form.
> >
> > It's much more readable:
> >
> >   -       enum cpu_idle_type idle = this_rq->idle_balance ?
> >   -                                               CPU_IDLE : CPU_NOT_IDLE;
> >   -
> >   +       enum cpu_idle_type idle = this_rq->idle_balance;
> >
> >   --------------------------------
> >
> >   -       if (env->idle == CPU_NOT_IDLE || !busiest->sum_nr_running)
> >   +       if (!env->idle || !busiest->sum_nr_running)
> >
> >   --------------------------------
> >
> > And gets rid of the double negation in these usages:
> >
> >   -               if (env->idle != CPU_NOT_IDLE && env->src_rq->nr_running <= 1)
> >   +               if (env->idle && env->src_rq->nr_running <= 1)
> >
> > Furthermore, this makes code much more obvious where there's
> > differentiation between CPU_IDLE and CPU_NEWLY_IDLE.
> >
> > Signed-off-by: Ingo Molnar <mingo@kernel.org>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Vincent Guittot <vincent.guittot@linaro.org>
> > Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
> > Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > Cc: Valentin Schneider <vschneid@redhat.com>
> > ---
> >  include/linux/sched/idle.h |  3 +--
> >  kernel/sched/fair.c        | 27 ++++++++++++---------------
> >  2 files changed, 13 insertions(+), 17 deletions(-)
> >
> > diff --git a/include/linux/sched/idle.h b/include/linux/sched/idle.h
> > index 478084f9105e..4a6423700ffc 100644
> > --- a/include/linux/sched/idle.h
> > +++ b/include/linux/sched/idle.h
> > @@ -5,8 +5,7 @@
> >  #include <linux/sched.h>
> >
> >  enum cpu_idle_type {
> > -       CPU_IDLE,
> > -       CPU_NOT_IDLE,
> 
> Could be set CPU_NOT_IDLE = 0  to help keeping in mind that 0 means
> cpu is not idle even if we don't use it ?

Yeah, makes sense. I've added back __CPU_NOT_IDLE = 0 (with the underscore 
to make sure some pending patch isn't accidentally relying on something it 
shouldn't), and added your Reviewed-by.

Thanks,

	Ingo