Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp449214lqc; Fri, 8 Mar 2024 02:10:39 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVNemEvMAdkFDvZS2dMx6j302j0qaaGwl0ADa/WkvQLREGlZdsTpCbKnZQkIqRYfPkjw0CZ/DDezIruQ0JwGbL8loXOgQWs2zgZQdz0rQ== X-Google-Smtp-Source: AGHT+IHn6UJtGEV45ue8TuluNt1Na3g5mCSe4tmieYkZ9nB02rWs/GM9PojDN+If9ii4aW8Jryrj X-Received: by 2002:ac8:570a:0:b0:42e:ecc6:868d with SMTP id 10-20020ac8570a000000b0042eecc6868dmr11843584qtw.34.1709892638915; Fri, 08 Mar 2024 02:10:38 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709892638; cv=pass; d=google.com; s=arc-20160816; b=toyyOjqCwjvPx9iLZnSMfe6Jk7TZMtpPO76HGXtAFQ6QVWwoylr6jdTh/it5Pp/O3h iP551tBa/WdEmMO31Y0QMfgpgvHRBPgAshy0x5lP8bqQOwAgolJ6x5iHURJ+BpV7wx6b xka5zuBNQmAvufi3IWEmfY1Tg93GaJNntwg0Ap+tNlvc7HojXMPD8DMZepah+bwRE1pm LGsG6YgbTJ63Pg4j77jn2ILGx6PQBK6VgDefd3i09ebK5YeTavZxYtPYXRlPCa1rx+rW 1J1XP9P7tkjCEay2duPZDs46NGOwmvqDfl+qXD4AY7kfsL5xQyw1Rsnuj5l0905S/RCl y5+A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=kEPi9l0paj8vXp3fsprExWAI6oq2Z5N23BuUY2eA4Uw=; fh=qi4kBeskBymI5w6NsMzc1dDuT1ws3vjEt5D3JlipxIk=; b=WOFL7WfNcyPKO1ytx0U4m3vMbSWSZlFZZAA0YMkJGFRm1cj9i5/WMwt4Qiv78VOYcL Oz7ahPTRATAT/QioHIuYr0dqRvnBwh1MExY6e8i1SiQw0niv7//TZ3C+KVI/pzhMKWFn bOM6mUa8yZw3rcOgcMk3PWvgQyiM+WU1uyIh4B3hAeSLJcOK1QumzlAO4X3kNqTzUjoo nAsQVT1LMiirX54/pPJCAbv3f1N+NnFAUfFn277y/juH6HQdw955noGWw1AHXwxTsKTZ 1xVuU80+lc32HzWUPRLjqAnc/nHtZq5VnXt8ZugnvJPpK3i25x1P+OdqWGixZbwZQYxd CRpg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f3Uphj2T; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-96797-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96797-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id z21-20020ac87f95000000b0042eeec63ef0si11752542qtj.316.2024.03.08.02.10.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 02:10:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-96797-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f3Uphj2T; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-96797-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96797-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A32F61C218B8 for ; Fri, 8 Mar 2024 10:10:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 18F1A53E3C; Fri, 8 Mar 2024 10:09:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="f3Uphj2T" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 396015381E; Fri, 8 Mar 2024 10:09:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709892597; cv=none; b=b6poUQkiesOaJxcz+QFqHmGfLhG/vMuhglIgrj+3N24ANHZV2MVcdGarNKllCGG8t20sT8nYHvD8PmH/BmkEHn1/U+ZfcySRl5uwAMvwuCF3UxA/IBIq2Ls8cDl+5uYo0MLQWu6068s1yUn2PUGSgjX746OzRdcctBAwPAQ+uUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709892597; c=relaxed/simple; bh=rI1oFIFEK1FcWmr4toRcEN4YoV5f3o2/ZWrSKqQ+k1A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ocz7r3uCZl17v+Qm2CZ3Lc9ya/7YZ0p/rCRVWatwiTX0RIqD2H+8WQNIHVp0+9whnGCCohi7R31ZdCD294dNmHu+YRE2sTaFOzvQSMa2pc5hTdOzQSPrdoNcqJIaJKb+vPXZdk+AYX0OUaCqnwUJwpCESRSPZLooCj8irdOCUzw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=f3Uphj2T; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94C93C43394; Fri, 8 Mar 2024 10:09:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709892596; bh=rI1oFIFEK1FcWmr4toRcEN4YoV5f3o2/ZWrSKqQ+k1A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f3Uphj2T+qfSXuqP1faGyiiiMXqmDxdhEMjbvjZ5sRNqTqQH+5IbXgc+8oa2UeLkr dCisi43O9Qyvo1v8lAst+FylMVSlnZj39JQiLucE1H7yK2IpJL5KXXds/XbdxwkO1j 2ujnYfHDxmDlNg/Kk8pnQjxunlQz4nTqpsCwAwDQlM4G0e9miG5nL7320w6Ho8Z/FM H/goKrGY1jPFnWR8PNIfC/tEb0t7oX6DFc67YWiuWRgiBd3l820RX88T3Pn3/EMmn7 DcMxIpoTI2xJw6pGRb6T+j70zLK9B6V9ByAMqbqN5V1IRjh7S/LR8sZUgZu99nMrpK TG/I3BrYADa2A== Date: Fri, 8 Mar 2024 11:09:50 +0100 From: Niklas Cassel To: Igor Pylypiv Cc: Damien Le Moal , John Garry , Jason Yan , "James E.J. Bottomley" , "Martin K. Petersen" , Jack Wang , Hannes Reinecke , Xiang Chen , Artur Paszkiewicz , Bart Van Assche , TJ Adams , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 5/7] scsi: hisi_sas: Add libsas SATA sysfs attributes group Message-ID: References: <20240307214418.3812290-1-ipylypiv@google.com> <20240307214418.3812290-6-ipylypiv@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240307214418.3812290-6-ipylypiv@google.com> On Thu, Mar 07, 2024 at 01:44:16PM -0800, Igor Pylypiv wrote: > The added sysfs attributes group enables the configuration of NCQ Priority > feature for HBAs that rely on libsas to manage SATA devices. > > Omitted hisi_sas_v1_hw.c because v1 HW doesn't support SATA. > > Reviewed-by: John Garry > Reviewed-by: Damien Le Moal > Reviewed-by: Jason Yan > Reviewed-by: Hannes Reinecke > Signed-off-by: Igor Pylypiv > --- Reviewed-by: Niklas Cassel