Received-SPF: pass (google.com: domain of linux-kernel+bounces-96801-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date: Fri, 8 Mar 2024 11:11:51 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux-kernel@vger.kernel.org, Shrikanth Hegde <sshegde@linux.ibm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Valentin Schneider <vschneid@redhat.com>
Subject: Re: [PATCH 5/9] sched/balancing: Fix comments (trying to) refer to
 NOHZ_BALANCE_KICK
Message-ID: <ZerkZ/4wpjLrYtvD@gmail.com>
References: <20240304094831.3639338-1-mingo@kernel.org>
 <20240304094831.3639338-6-mingo@kernel.org>
 <CAKfTPtCNmnsLL+OwyYjn+DysbXUyjqAdsWXr1Q6pGBybdkhYGw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKfTPtCNmnsLL+OwyYjn+DysbXUyjqAdsWXr1Q6pGBybdkhYGw@mail.gmail.com>


* Vincent Guittot <vincent.guittot@linaro.org> wrote:

> On Mon, 4 Mar 2024 at 10:48, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > Fix two typos:
> >
> >  - There's no such thing as 'nohz_balancing_kick', the
> >    flag is named 'BALANCE' and is capitalized:  NOHZ_BALANCE_KICK.
> >
> >  - Likewise there's no such thing as a 'pending nohz_balance_kick'
> >    either, the NOHZ_BALANCE_KICK flag is all upper-case.
> >
> > Signed-off-by: Ingo Molnar <mingo@kernel.org>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Vincent Guittot <vincent.guittot@linaro.org>
> > Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
> > Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > Cc: Valentin Schneider <vschneid@redhat.com>
> > ---
> >  kernel/sched/fair.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> > index 934ace69eb30..4c46bffb6a7a 100644
> > --- a/kernel/sched/fair.c
> > +++ b/kernel/sched/fair.c
> > @@ -12410,14 +12410,14 @@ static int newidle_balance(struct rq *this_rq, struct rq_flags *rf)
> >
> >  /*
> >   * run_rebalance_domains is triggered when needed from the scheduler tick.
> > - * Also triggered for nohz idle balancing (with nohz_balancing_kick set).
> 
> I think it should be nohz_balancer_kick() instead of nohz_balancing_kick
> 
> 
> > + * Also triggered for NOHZ idle balancing (with NOHZ_BALANCE_KICK set).
> 
> In fact, this can be triggered even without NOHZ_BALANCE_KICK. Any of
> the below can trigger this
>   - NOHZ_BALANCE_KICK
>   - NOHZ_STATS_KICK
>   - NOHZ_NEXT_KICK

Yeah, indeed any of the flags in NOHZ_KICK_MASK can trigger nohz_csd and 
indirect the balancing softirq - so I changed the text to:

  /*                      
   * This softirq may be triggered from the scheduler tick, or by
   * any of the flags in NOHZ_KICK_MASK: NOHZ_BALANCE_KICK,
   * NOHZ_STATS_KICK or NOHZ_NEXT_KICK.
   */
  static __latent_entropy void run_rebalance_domains(struct softirq_action *h)

Thanks,

	Ingo