Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp468183lqc; Fri, 8 Mar 2024 02:58:56 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUD6D7Wy3iKodrxdah8W5AkRakgOFRPpxlVsF9B4dLW5DIKn85pbnWTlpa+0NL3E9UIvtnqMAfflepN8hVgzCBfUAIfs8KkSUSfUZXVpQ== X-Google-Smtp-Source: AGHT+IEO7w5366JRbykvZHJBdXfMTwhnFTqSIB0PIL5ddoeaeN1I14Can93apeF3ZwMo8YwGnwBc X-Received: by 2002:a17:906:19d3:b0:a45:c706:b239 with SMTP id h19-20020a17090619d300b00a45c706b239mr4095717ejd.32.1709895536607; Fri, 08 Mar 2024 02:58:56 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709895536; cv=pass; d=google.com; s=arc-20160816; b=JcH3G3TqlV0u42A0WRWSJTwlsqEFkbip80eAVpq1HHuJxbQ/7Mhe+RX4836se3e8F4 YIaF4RT0qzPn8Bb3Szud6xhf2Id5lPEWYeM2wRDpgCS+1yvUSEULHIue6UjkIUVO+a/G /vAm5F9IytHw3RpU2ibSWHUDZ0+G+CVFbIa+CCq2g+Z9lGsftawG9JfeEQfIC0B91DmE zabkP3/FDENBvDYOCCtX+2Z1o0LIL7Xoy3HHhHTvAPYNUWCV0glS3JDQN+2kqcQrZmfi pUuS+PwHPyjL2/qj4pdVbqNhhEHtMqr0jb2P+iy7AVEryyH5Hhy4Ec6rzFxjpcTxKuc5 bxrQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=PcnQrF5xYcn5uA2BgCDjMiJSTjBuh0mLxYEyK2hOjDE=; fh=2zoHt2+dS25BfDKfy0ILiJbVo9ZZNmcxu5c1EmHUtqA=; b=N+uYs53G9CW48EY6IAikXOEtuTWSEjBFKMU0iSLSVnPE9Tu3ZkAPWZ+WjB7/cK42cs Ci/wAc6CrHxuBiO2NNkkw6vDGSBWpF17uWmASRE0DeBt+rsJuUi9xFfXU++G+aeiuPn3 hEyh/9wc9PttoRtD+GsBMckl0NH0bscSBnU30J18F2bN7gcwdEkX8RAeQvGfuByXvJpw 3Px5VTOLMl74pqkFVnYPoLhCS+R4Js0Ffp9JTbOiHI8+wbhVG38rFTxKDm3bgO3IcM3H 7lPTmVxF3S/2UOukZYQoPXaC1dX56D76fJ+HZoKWL6NCN3xBhwEdYXtSajEfzwnZ0Jl2 7jQQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=L34vsXe5; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-96878-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96878-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id h8-20020a1709062dc800b00a446b9dc75bsi6928033eji.997.2024.03.08.02.58.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 02:58:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-96878-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=L34vsXe5; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-96878-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-96878-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 58B111F23C36 for ; Fri, 8 Mar 2024 10:58:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9FEE155C2B; Fri, 8 Mar 2024 10:58:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L34vsXe5" Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B79C55789 for ; Fri, 8 Mar 2024 10:58:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709895525; cv=none; b=sgEf8JEX2X1rb8D2ZcJRaG0yfWxUNqufU+pFf5IymN1Ev87S7EMbFOdHitcPXCUbnneeP3QvHDuq0NV3HwaRxHT/kzZqD2sMGp7OSySR02ipAdgf15puz5esNxU36FT7WvIn9oxQkxtxn1Uxfi7WXwShlyZfujvY62K8SzhQDTQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709895525; c=relaxed/simple; bh=NsBAMVV3UGnfxcnXbaurwKVQRZzPsLLq7CIVcfF+8yU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DUeallLaBThsgFSdrhXoMHaLI4DOglmWYldithUgc5rtSVWFJPM+dSE21rB2Ss1gh2CMXa+9KvoExa4kmnUtfcSGeksLMJK1dpbjQ4Oavh3Y/1TuyLYc5twEIXM/ti4g4pepD8Zg1Qz/MgMBrd/1FejtF0jxF+5oek2k0WrP8jQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=L34vsXe5; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-412f62ee005so14527595e9.2 for ; Fri, 08 Mar 2024 02:58:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709895522; x=1710500322; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PcnQrF5xYcn5uA2BgCDjMiJSTjBuh0mLxYEyK2hOjDE=; b=L34vsXe57OqqeHORbzp5GddKLk6UxjEWM0Cj5Uoq4ALouvlcEJpc3FWVFXmWbDpWuC XAkon/fFo0dB0SwnSLZ6DWmU0wXEjiP6nke3RQjQKQGR+rd7MIYEBrRur/nUHAldq1ix c1a8iQebCARs8Aux2Mqzk5cXjzRsannsxKgsZNvT8P8pwSUZutQNPTXRYQ5oluAmOeMH rup4DKsHYDb4FOa/UyvZHD0MM1XTbUF4poyHdcdwGqrXk+eOf8NeUEXlf08g7o9tdZn/ brel2RgjU3KIhm0cUBMrrKqnV6pSVycVt6YjXabQK3WQxYt4Vruh0Mm+CLS+wE72x7/v tk8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709895522; x=1710500322; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PcnQrF5xYcn5uA2BgCDjMiJSTjBuh0mLxYEyK2hOjDE=; b=aAOpZAWVHUWFmCOFioVhINIqZjVMErtZ0dCiLWwTKCqrERGhdHteHuXhT9LtBtVfhQ 88fOmf3oX5vtaVYlBmMrj7TAW7FHrPI6P8aH0IfXDk/U13bQAsHS/F1N6H98LOKPDxid jT6BwM4REWi03o2ruDVmKOGa79X/hmaLkXL7bxglh8jkWvgzThIFdgFF5pmq6S/vKlMd J1+HKMsdiGbwHkwxz/rvYPPFKHJ8n6puw6S8YZRVNZPdev2RxGHX1f3JyZIzTaoLUwu2 /4nuZUDsJ7FKsZwt+zkhRNE16wHKjG6tX5qytP3qWroQbDy3ZsB8hxAl4z9UONHbWJnY W8ig== X-Forwarded-Encrypted: i=1; AJvYcCXLHqLfreIpMmRJa+ESpkwbriNkVWVYTz2dsWFGf+ro53xXCLfqEjuiZCXwahIscjT2+eXOX3CpguhOpFQFTXUAYUGITznC+Txj4fIc X-Gm-Message-State: AOJu0Yw/q7kflrliIK8ZJoDk0qJ+/Q6Ln+9kRQ5/nK2to+etXBlBNCE7 vTy9aVwjBPb74ZgzBBAaMhNOfHPbnfPTvEFzB8nYnDi3XsW28cReMhpX4i99n9I= X-Received: by 2002:a05:600c:4689:b0:412:ca58:81ce with SMTP id p9-20020a05600c468900b00412ca5881cemr16061693wmo.13.1709895522479; Fri, 08 Mar 2024 02:58:42 -0800 (PST) Received: from [192.168.0.102] ([176.61.106.68]) by smtp.gmail.com with ESMTPSA id by1-20020a056000098100b0033e22341942sm20086822wrb.78.2024.03.08.02.58.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Mar 2024 02:58:42 -0800 (PST) Message-ID: Date: Fri, 8 Mar 2024 10:58:41 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] clk: qcom: Add camera clock controller driver for SM8150 Content-Language: en-US To: "Satya Priya Kakitapalli (Temp)" , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Abhishek Sahu , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Ajit Pandey , Imran Shaik , Taniya Das , Jagadeesh Kona References: <20240229-camcc-support-sm8150-v1-0-8c28c6c87990@quicinc.com> <20240229-camcc-support-sm8150-v1-4-8c28c6c87990@quicinc.com> <18567989-fb60-49ae-92e6-94e1bc2fa1c7@linaro.org> <83fd1995-a06e-b76a-d91b-de1c1a6ab0ea@quicinc.com> <4817a5b0-5407-4437-b94a-fc8a1bfcd25d@linaro.org> From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/03/2024 10:46, Satya Priya Kakitapalli (Temp) wrote: >> >> Not if you mark it critical >> > > Marking the clock as critical keeps the associated power domain > always-on which impacts power. For this reason we are not using > CLK_IS_CRITICAL and instead making them always on from probe. How does the clock do anything _useful_ if the power-domain gets switched off ? --- bod