Received-SPF: pass (google.com: domain of linux-kernel+bounces-96899-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 8 Mar 2024 12:08:13 +0100
From: Tommaso Merciai <tomm.merciai@gmail.com>
To: Umang Jain <umang.jain@ideasonboard.com>
Cc: linux-media@vger.kernel.org,
	Alexander Shiyan <eagle.alexander923@gmail.com>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	open list <linux-kernel@vger.kernel.org>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH v2 4/6] media: imx335: Use integer values for size
 registers
Message-ID: <ZerxncwhQLgm3PMP@tom-HP-ZBook-Fury-15-G7-Mobile-Workstation>
References: <20240308083312.90279-1-umang.jain@ideasonboard.com>
 <20240308083312.90279-5-umang.jain@ideasonboard.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240308083312.90279-5-umang.jain@ideasonboard.com>

Hi Umang,

On Fri, Mar 08, 2024 at 02:03:10PM +0530, Umang Jain wrote:
> Consider integer values for registers that are related to various
> sizes in the register map. This helps in improving the overall
> readability.
> 
> No functional changes intended in this patch.
> 
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
>  drivers/media/i2c/imx335.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
> index ec27035586f3..3c593538f727 100644
> --- a/drivers/media/i2c/imx335.c
> +++ b/drivers/media/i2c/imx335.c
> @@ -250,12 +250,12 @@ static const struct cci_reg_sequence mode_2592x1940_regs[] = {
>  	{IMX335_REG_MODE_SELECT, 0x01},
>  	{IMX335_REG_MASTER_MODE, 0x00},
>  	{IMX335_REG_WINMODE, 0x04},
> -	{IMX335_REG_HTRIMMING_START, 0x0180},
> -	{IMX335_REG_HNUM, 0x0a20},
> -	{IMX335_REG_Y_OUT_SIZE, 0x0794},
> -	{IMX335_REG_AREA3_ST_ADR_1, 0x00b0},
> -	{IMX335_REG_AREA3_WIDTH_1, 0x0f58},
> -	{IMX335_REG_OPB_SIZE_V, 0x00},
> +	{IMX335_REG_HTRIMMING_START, 384},
> +	{IMX335_REG_HNUM, 2592},
> +	{IMX335_REG_Y_OUT_SIZE, 1940},
> +	{IMX335_REG_AREA3_ST_ADR_1, 176},
> +	{IMX335_REG_AREA3_WIDTH_1, 3928},
> +	{IMX335_REG_OPB_SIZE_V, 0},
>  	{IMX335_REG_XVS_XHS_DRV, 0x00},
>  	{CCI_REG8(0x3288), 0x21}, /* undocumented */
>  	{CCI_REG8(0x328a), 0x02}, /* undocumented */

Looks good to me.
Reviwed-by: Tommaso Merciai <tomm.merciai@gmail.com>

Thanks & Regards,
Tommaso

> -- 
> 2.43.0
> 
>