Received-SPF: pass (google.com: domain of linux-kernel+bounces-96928-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date: Fri, 8 Mar 2024 12:25:23 +0100
From: Ingo Molnar <mingo@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Shrikanth Hegde <sshegde@linux.ibm.com>,
	Valentin Schneider <vschneid@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH -v1 00/13] sched/balancing: Standardize the naming of
 scheduler load-balancing functions
Message-ID: <Zer1o5bhkiq1cxaj@gmail.com>
References: <20240308111819.1101550-1-mingo@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240308111819.1101550-1-mingo@kernel.org>


* Ingo Molnar <mingo@kernel.org> wrote:

> Over the years we've grown a colorful zoo of scheduler
> load-balancing function names - both following random,
> idiosyncratic patterns, and gaining historic misnomers
> that are not accurate anymore.
> 
> We have 'newidle_balance()' to rebalance newly idle tasks,
> but 'balance_domains()' to rebalance domains. We have
> a find_idlest_cpu() function whose purpose is not to find
> the idlest CPU anymore, and a find_busiest_queue() function
> whose purpose is not to find the busiest runqueue anymore.
> 
> Fix most of the misnomers and organize the functions along the
> sched_balance_*() namespace:
> 
>   scheduler_tick()		=> sched_tick()
>   run_rebalance_domains()	=> sched_balance_softirq()
>   trigger_load_balance()	=> sched_balance_trigger()
>   rebalance_domains()		=> sched_balance_domains()
>   load_balance()		=> sched_balance_rq()
>   newidle_balance()		=> sched_balance_newidle()
>   find_busiest_queue()	=> sched_balance_find_src_rq()
>   find_busiest_group()	=> sched_balance_find_src_group()
>   find_idlest_group_cpu()	=> sched_balance_find_dst_group_cpu()
>   find_idlest_group()		=> sched_balance_find_dst_group()
>   find_idlest_cpu()		=> sched_balance_find_dst_cpu()
>   update_blocked_averages()	=> sched_balance_update_blocked_averages()

Forgot to mention that this series is on top of the scheduler tree 
(tip:sched/core) plus my other pending queue:

   https://lore.kernel.org/r/20240308105901.1096078-1-mingo@kernel.org

Thanks,

	Ingo