Received-SPF: pass (google.com: domain of linux-kernel+bounces-96935-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <4234830f-a029-4025-a137-3caaba6a23d1@amd.com>
Date: Fri, 8 Mar 2024 12:28:17 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] drm/amdgpu: add vm fault information to devcoredump
Content-Language: en-US
To: Sunil Khatri <sunil.khatri@amd.com>,
 Alex Deucher <alexander.deucher@amd.com>,
 Shashank Sharma <shashank.sharma@amd.com>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
 linux-kernel@vger.kernel.org, Mukul Joshi <mukul.joshi@amd.com>,
 Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
References: <20240308103130.4124796-1-sunil.khatri@amd.com>
From: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
In-Reply-To: <20240308103130.4124796-1-sunil.khatri@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TnJNcHBuKzlkeUg4Smgya1pUVjNQV1BqeVc5Qm9BeG9HcWhXb0s5RnZtVDZl?=
 =?utf-8?B?ZE9YTy9mRmZsc3ljVVlObkwyZ2NpK1E5NWhWS3VJclMzK0xsZFN1VWV6Z3Rk?=
 =?utf-8?B?VUNJUlZUNTNGVDd5a2F2UzRSM3NqZEc1Vi9rL2hlS1NISkx1OTkwU1dmbHZs?=
 =?utf-8?B?Zi96S0JXOWRHVjRNRDVSa1Nwelhna3p3NVlnUXZBd1ZLQzVUalhEQS9QUFRy?=
 =?utf-8?B?TC9URHUyKzdZWTViQ2xxV3J4SXIwd0MzYUVOTGsrWGZoM0NTYlJmM3FucGYr?=
 =?utf-8?B?cGhlU0h2Nzl0WlltcklnMlRUR285QnJpR2J6YUkrNG1ERkY4eW9SWEtzcldF?=
 =?utf-8?B?WHZ4ckx5ZENzT3JTbTgwdXNLTkpkS1hKMUpGZ1pEeEthT25pN3JHMmtDRDBG?=
 =?utf-8?B?NTN2ZmZGZEs4bEhEQW5KdDRQNXlLMU5IOTRWU000ZDBhOFdOY29BQmR4S01G?=
 =?utf-8?B?eVJkQXNsNXN6MVR3cm5jeE5JUWdCelVFd21md09Ody9SdlVaaStzRUttZVdx?=
 =?utf-8?B?dFhIRUdMTitqT0QvWlUyYWxYa045Um1tTFRWeDYvZXV4bG5wNTlCVHhGYW5N?=
 =?utf-8?B?WXk5cU1xcXd5cXVUMEhHNFZ3OHlORnp3TnU2ZThLVVNWMmpIaHd1U1JraXkz?=
 =?utf-8?B?ZGEyaWJpU1M1b0UxYVZpd1VXaHY4R3psSEovTXByUU5KZW8zSm9xelFkSzll?=
 =?utf-8?B?U04rS3V5aU8rUHJodXdWOUZMQ1pSSE1ZQ2NRWEtiU1A0TDJibktWWlhzNWty?=
 =?utf-8?B?VFdHTVNXZGRiOXIxSVRNQjNIMVBLUUxML3dtQ2VFR04rdklwbWlSQzVzNnI0?=
 =?utf-8?B?MDJwdjZaT3BlQnlvVU5RK0VCMEswVHdjaWlzZ0VxOWU4b1FQbU1WcGJROFY5?=
 =?utf-8?B?NElzK0JJZCs5bk1rVXl4UENYZUZUN2FIOW5veUNqam5CQ2dUNUdLbFkrd1ZH?=
 =?utf-8?B?RkpjRlN3SHE3Z0lhY1JLM3h4WmJRNUwwOWhtTFFvdFZNZ1ZDSVBiZThnZmpK?=
 =?utf-8?B?T3Z4cGpmV1NCOEpPd0luNzZZdVI5TXp3NHdsSTVLVm1rQ2VnRWFPMWlWUkk0?=
 =?utf-8?B?cERFMVFERTQ5bE9EalZqUEpaUm9ubW5WMnhtNUZTUk0yRVpHOFN2MTRUZHBs?=
 =?utf-8?B?SzNCUjlWWFUyL0l5Q2hQaC9hbXRvVWgzVTNkaVRNSjRmMTBTTndMdnU4Nm84?=
 =?utf-8?B?cmdHb3ZpR0RLaDJpSnpVQnQ2RTNkaXdwck03dks0RGhVVEl1bXVoMmJES2lr?=
 =?utf-8?B?cTRDcURhMlJscWlzVklHY2ZsSjJ2RXpFUU5TMGo1eHQ1cmU0eWEzVGpzM2oz?=
 =?utf-8?B?eWhsZWVwbUNvY1RqZ1BFOXFBaDZKS3ZpOWxXNUJVbjRxSTU2dXNKRktBT2VK?=
 =?utf-8?B?VlhwUm1rSEg4bzFQeXltVzhzRTBsUTMyUzBtZk16RkVjaEt3Q0tvSytTaUdH?=
 =?utf-8?B?RkVHL2xlcUFGdkhGV0NncGpDZWRxN2UvaGt4OGloaTdlZFI1NFFtcWt5cDNF?=
 =?utf-8?B?d3BaaWpWSnRqSDVYTWpiWFlkSWhpTkY1ZmNkUEZmQ3I1L2kzdmI5MmZBbTFE?=
 =?utf-8?B?L0g5eWZCanZJZUo4WDcwUzBWVndJa1h3dVpaQyttdk5vR0pFV2tWYkZ3ZHE0?=
 =?utf-8?B?eXBFd0d1Y2h1ZjRlTG5sRE13Wm1aSzJpWWRDWWlGM1k1REZPUHZNVkd0eWFE?=
 =?utf-8?B?KzFjczJCQWFWTy9UU241dW9qY3RlNzRyR3F5RGdLOSt4Z2VNdUh2UGJSRHdI?=
 =?utf-8?B?MG90SCt2TkRLdzhaeDJVNCtMY21DK1dsUHVmc1h4cTJESFFsZ3ZNR3pkSEN6?=
 =?utf-8?B?SVVnOW1LNFlZKzVubXI4b2hSQ0xwWDlCTWJUbnJ5ZVUzR0ZyQVUrV09BTnM0?=
 =?utf-8?B?MHNWV0x3OGYvVjNvaHlDWXowSUYxVExkMlVjd2NoNmlobGNhTFNjV01OUFY1?=
 =?utf-8?B?ZFA5MWVHMCtsSlBDUVJGUGlsdXlwRCsrbmtzTm50NENmZmtwWVdBQmtWVHRU?=
 =?utf-8?B?NGZ0RStYM3VGQWMzb0JTenhNRHhoQ3YvTGo2V24vVWlvNE0wRXlSanUvcHlo?=
 =?utf-8?B?U01KWkIvUjhUSHJmUWhGeG14Sy80Mnp5UEd6VlN5WXdxUnRJdll4NWRPQlFF?=
 =?utf-8?Q?C/leOsEHpZimTkTJ+WwgRZq2V?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb375513-5748-4301-b906-08dc3f62dd0b
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5685.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 11:28:22.9334
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: REjDAdVbLAFcArZkO2Ubt7YOmJCuxaf1Tfh2ULNY9cWDf0HBvSRNlhqmD0ucQT8G
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7305

Am 08.03.24 um 11:31 schrieb Sunil Khatri:
> Add page fault information to the devcoredump.
>
> Output of devcoredump:
> **** AMDGPU Device Coredump ****
> version: 1
> kernel: 6.7.0-amd-staging-drm-next
> module: amdgpu
> time: 29.725011811
> process_name: soft_recovery_p PID: 1720
>
> Ring timed out details
> IP Type: 0 Ring Name: gfx_0.0.0
>
> [gfxhub] Page fault observed
> Faulty page starting at address: 0x0000000000000000
> Protection fault status register: 0x301031
>
> VRAM is lost due to GPU reset!
>
> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
> index 147100c27c2d..6d059f853adc 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
> @@ -203,6 +203,18 @@ amdgpu_devcoredump_read(char *buffer, loff_t offset, size_t count,
>   			   coredump->ring->name);
>   	}
>   
> +	if (coredump->adev) {
> +		struct amdgpu_vm_fault_info *fault_info =
> +			&coredump->adev->vm_manager.fault_info;
> +
> +		drm_printf(&p, "\n[%s] Page fault observed\n",
> +			   fault_info->vmhub ? "mmhub" : "gfxhub");
> +		drm_printf(&p, "Faulty page starting at address: 0x%016llx\n",
> +			   fault_info->addr);
> +		drm_printf(&p, "Protection fault status register: 0x%x\n\n",
> +			   fault_info->status);
> +	}
> +
>   	if (coredump->reset_vram_lost)
>   		drm_printf(&p, "VRAM is lost due to GPU reset!\n");
>   	if (coredump->adev->reset_info.num_regs) {