Received-SPF: pass (google.com: domain of linux-kernel+bounces-97001-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 8 Mar 2024 13:27:33 +0100
From: Andi Shyti <andi.shyti@kernel.org>
To: =?utf-8?B?VGjDqW8=?= Lebrun <theo.lebrun@bootlin.com>
Cc: Linus Walleij <linus.walleij@linaro.org>, 
	Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
	Conor Dooley <conor+dt@kernel.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, 
	Gregory Clement <gregory.clement@bootlin.com>, Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>, 
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Tawfik Bayouk <tawfik.bayouk@mobileye.com>
Subject: Re: [PATCH v3 03/11] i2c: nomadik: simplify IRQ masking logic
Message-ID: <3f7zpl4yu5gsojmfhdrbieev3gatfcgag5tnmgmrv3u46y4pny@tamjf6cq5g3v>
References: <20240306-mbly-i2c-v3-0-605f866aa4ec@bootlin.com>
 <20240306-mbly-i2c-v3-3-605f866aa4ec@bootlin.com>
 <422szb2dtgnq56xznfqsqtqs3dai2jipnntrp6yb2og353whs7@g4ia5ynnmqu6>
 <CZO8SUELNP4R.230VKX59UIHC8@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CZO8SUELNP4R.230VKX59UIHC8@bootlin.com>

Hi Theo,

On Fri, Mar 08, 2024 at 09:57:39AM +0100, Th?o Lebrun wrote:
> Hello,
> 
> On Fri Mar 8, 2024 at 12:01 AM CET, Andi Shyti wrote:
> > Hi Theo,
> >
> > On Wed, Mar 06, 2024 at 06:59:23PM +0100, Th?o Lebrun wrote:
> > > IRQ_MASK and I2C_CLEAR_ALL_INTS both mask available interrupts. IRQ_MASK
> > > removes top options (bits 29-31). I2C_CLEAR_ALL_INTS removes reserved
> > > options including top bits. Keep the latter.
> > > 
> > > 31  29  27  25  23  21  19  17  15  13  11  09  07  05  03  01
> > >   30  28  26  24  22  20  18  16  14  12  10  08  06  04  02  00
> > > --- IRQ_MASK: --------------------------------------------------
> > >       1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
> > > 0 0 0
> > > --- I2C_CLEAR_ALL_INTS: ----------------------------------------
> > >       1     1 1       1 1 1 1 1                   1 1 1 1 1 1 1
> > > 0 0 0   0 0     0 0 0           0 0 0 0 0 0 0 0 0
> > > 
> > > Notice I2C_CLEAR_ALL_INTS is more restrictive than IRQ_MASK.
> > > 
> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > > Signed-off-by: Th?o Lebrun <theo.lebrun@bootlin.com>
> >
> > You did answer my question in v2, thanks, Theo!
> 
> Oops my mailer syntax is telling me that the lines starting with '---'
> might cause issue as it might mark the end of commit messages. I'll fix
> that in next revision. If it gets applied before that it should be
> checked that part of the message doesn't get lost.

mmhhh... right! No need to resend, if nothing else is needed from
the series, please paste the commit message here and I will fix
it.

Andi