Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp522905lqc; Fri, 8 Mar 2024 04:53:15 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX8bwjsx8ngwPxVq/tkJEfGe9IhNwrd9FiBH8npc41tbC0IFTbxmwe4XOIKBHKswcmQBnfe3DqJiI7Os28PDmyMk4yCIjFhoXI0zr5JXQ== X-Google-Smtp-Source: AGHT+IH1SUPb64ifFVJieNq2ePiiiNBUgnJDRL5TFS7my69J09ynR08dojyhZ8+QX7qe7Y2O43Az X-Received: by 2002:a05:6a00:10c6:b0:6e6:4f3b:fd9f with SMTP id d6-20020a056a0010c600b006e64f3bfd9fmr8579647pfu.24.1709902395387; Fri, 08 Mar 2024 04:53:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709902395; cv=pass; d=google.com; s=arc-20160816; b=aSl0hYhHG7Q/Uim9d2spJcOTGOdKy3H5wRBvhUoKxNpw5lDdfEC+lcG3IBPCY4bWnA ozKW8ybKj6ylALWB4Uz+InREupshTR6mUrglGqKXNwrjZ9q/bbc6MFDqk0SLhm0UDuna CpV3yKus6uzaybPdQTIVZOO6xV01jRjTu9IRXkqXa6yOVS59Z7p82UghAxquS4Ug4Yz7 31+NivJuO8ICLc6A6Oo0UoxChK203P8VpXBWjEa++i82OWtNfbahW1gmy6YgcDNZLYbw q3otDTowsAr6EPOjLkMORdS2gW13EyLId/kTjkz51I86z/7VF6NISjTHNSIPl7e0P4g0 HhlA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from; bh=WOtbobgGeL2QuK/oVcrVHdd0ZrlOswqQfefop7cTTHQ=; fh=rTsj5RmERjj27sEgozrxw9HFgE0Arx8Z0LoJK8x5SA8=; b=NUPbcdg9eWbId7AYaeE6VOxohyDSlH548d2PPL60WwDChUXIabuFl+0MgekUc860mu otr2EPDSbcF59BAaiim9qMxAlyvBTUQIZE7hyQv2LhF2Ho7bdqaJIsg297ZZo53RcTyW 3OU9JsuY+H47UvM5P5z3aW0JnEBKA5CMiyxUAgLhGsHn/TqhO+P6O3pAsQFnqgYLv/9d L0BnWDuupnyo81+bSO7BoMCFhHLGN9+G8Zm/Pc2/HK56gAff1c3qcmG4CfTBVwhIIbmp eX8cmzVtAIIyugDpdXzIvVh5nwdkUtDg0K1S4g+TBX8tHWyYOGXuZN1talTz9jIAVzwB w95Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=0leil.net); spf=pass (google.com: domain of linux-kernel+bounces-97030-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97030-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id z9-20020a63e549000000b005dc4ec48cb5si15889889pgj.641.2024.03.08.04.53.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 04:53:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-97030-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=0leil.net); spf=pass (google.com: domain of linux-kernel+bounces-97030-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97030-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0C356281DDE for ; Fri, 8 Mar 2024 12:53:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 016733BBD4; Fri, 8 Mar 2024 12:52:29 +0000 (UTC) Received: from smtp-bc09.mail.infomaniak.ch (smtp-bc09.mail.infomaniak.ch [45.157.188.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DB2E1B812 for ; Fri, 8 Mar 2024 12:52:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.157.188.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709902348; cv=none; b=p/HT3PCeVg+gg0hTfmK/X/vDnK/kQHyoj6A3cDRvmg1o5N6vkG6exM3Pn84QISR3TwLI9omFJRAWrQ5Ujc662dMoINRFS9HRTRso7tRFUNMQjGmUx369FgMNt80c0c12xbTvN+XhCpfkkAJVfh3RaBitWW5AXKhm6kYss8/F0R0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709902348; c=relaxed/simple; bh=aqrD/Cge+/rUwjlnDV5JnmAzZubCbxI3etTc0cf5Xyk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cNi4vj5/FnUMPM3HaxMroUd19wFM6Cue1EroImVpN5T3eWcyq3lNe/ZeSFK9fannJOY9C5vawqhJ3zRH9fjNQtCquIzf7BT70MwfThCusjbvaOjACGXa9X4Ruo9lUW3NSk9xS/YB5J5EFsJHiMWvpcgLIz9UxnkCo00YBCC66EE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0leil.net; spf=pass smtp.mailfrom=0leil.net; arc=none smtp.client-ip=45.157.188.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0leil.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=0leil.net Received: from smtp-3-0001.mail.infomaniak.ch (smtp-3-0001.mail.infomaniak.ch [10.4.36.108]) by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4TrmKD6D1tzmYw; Fri, 8 Mar 2024 13:52:16 +0100 (CET) Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4TrmKD1rMbzMppDS; Fri, 8 Mar 2024 13:52:16 +0100 (CET) From: Quentin Schulz Date: Fri, 08 Mar 2024 13:52:09 +0100 Subject: [PATCH 2/3] arm64: dts: rockchip: enable internal pull-up on PCIE_WAKE# for RK3399 Puma Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240308-puma-diode-pu-v1-2-2b38457bcdc0@theobroma-systems.com> References: <20240308-puma-diode-pu-v1-0-2b38457bcdc0@theobroma-systems.com> In-Reply-To: <20240308-puma-diode-pu-v1-0-2b38457bcdc0@theobroma-systems.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Klaus Goger , Quentin Schulz , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Quentin Schulz X-Mailer: b4 0.13.0 X-Infomaniak-Routing: alpha From: Quentin Schulz The PCIE_WAKE# has a diode used as a level-shifter, and is used as an input pin. The SoC default for this pin is a pull-up, which is correct but the pinconf in the introducing commit missed that, so let's fix this oversight. Fixes: 60fd9f72ce8a ("arm64: dts: rockchip: add Haikou baseboard with RK3399-Q7 SoM") Signed-off-by: Quentin Schulz --- arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi index a51ebb8f8b80f..2484ad2bd86fc 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi @@ -416,6 +416,11 @@ &io_domains { gpio1830-supply = <&vcc_1v8>; }; +&pcie_clkreqn_cpm { + rockchip,pins = + <2 RK_PD2 RK_FUNC_GPIO &pcfg_pull_up>; +}; + &pinctrl { pinctrl-names = "default"; pinctrl-0 = <&q7_thermal_pin>; -- 2.44.0