Received-SPF: pass (google.com: domain of linux-kernel+bounces-97117-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 8 Mar 2024 09:55:02 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux.dev, joro@8bytes.org,
	yi.l.liu@intel.com, kevin.tian@intel.com, nicolinc@nvidia.com,
	eric.auger@redhat.com, vasant.hegde@amd.com, jon.grimm@amd.com,
	santosh.shukla@amd.com, Dhaval.Giani@amd.com, pandoh@google.com,
	loganodell@google.com
Subject: Re: [RFCv2 PATCH 3/7] iommu/amd: Update PASID, GATS, and GLX feature
 related macros
Message-ID: <20240308135502.GK9179@nvidia.com>
References: <20240112000646.98001-1-suravee.suthikulpanit@amd.com>
 <20240112000646.98001-4-suravee.suthikulpanit@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240112000646.98001-4-suravee.suthikulpanit@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?+2ueiIlsQ1QODqPkmHtKfwTP2tuqx0qoGshSYGiq6DsD5O4gJVlZ9nlXbM7y?=
 =?us-ascii?Q?h+F91VsYd1Ni5VH8/lp+9QYYof9kYrQGbGCkZQntv1UIN33TL+oFvLgjqFIF?=
 =?us-ascii?Q?nl81eGq3mVessjdVjNGxko99bATaCjL0YIpRFsPzdUM5GH8zcGHLqml2PRzV?=
 =?us-ascii?Q?9fBZUNV/I3r3JvGHUG0uLaSgQKiMyC1n17p6qdONQIknwUZfQIJ6m+WbUb26?=
 =?us-ascii?Q?4Xe0zIR3P0vfg+OhFevsNZlIRDynUGxwtT6HOLwdWyO8eMV2KQXuKwxutN27?=
 =?us-ascii?Q?2T67+Wq8y07SrYLH2Geb7c+42qgmRJVUxFdGzVgkSxP7GHVAkHLFr2AjMh2/?=
 =?us-ascii?Q?Gc5PC42x/pNOUiiudzpnWZWZLK6Oyg4H1R6Sdn4e6eP9SOl2LoqBl1lp5MVa?=
 =?us-ascii?Q?orYOKbcDn+5fPLGCbZ84YVQ1Zo2IltsyNLngYZ8tUceUAIud6jZT7NnnV77u?=
 =?us-ascii?Q?IzFkWp3jJvXTn+CxWvoj7I/2I+ltzDGIKTc3AN86s0JHVFdtfKy3Y8bVjn2A?=
 =?us-ascii?Q?HGluxOjzjdGKgSLiAh2XeztLkAnWWjoUqo4+BEdDt+Nm8eVkyvzBgzGFoKTp?=
 =?us-ascii?Q?5AF1kcYf1dxNtWGvdtT3EQpRz7gs5DBg0g+hr2BHObIn+z2U2YsKhJnfUwEv?=
 =?us-ascii?Q?cd6oT39C/zpCt55fkyxnFXgUnZH2NU1sYrNBhfKcUwOXBaaC14/YF+hzlzfB?=
 =?us-ascii?Q?ZzfDFm5428Psa5hZXM/CZx8Cyo+T+BLMqjqEFzhQ1ehVD6Cp+sR4PeVd5rqu?=
 =?us-ascii?Q?U63PFIY7qa5PAfru1GIAwWtZDacQBtLh9HlejMhG0ikfdiy5BpvE31RY3zz4?=
 =?us-ascii?Q?mDmLtUEkBXMVKp6Q4ASaLcvzdDIkvrK+zQeVW0GG8OrMbA8cqmIRN2ysBhen?=
 =?us-ascii?Q?OkFVBnfhkmDNOHUj24BcPdsgKzdc3WEw2YZWTIdk0DEXislP4ncyXBTn212c?=
 =?us-ascii?Q?oIKqGTpWXJWUgpjasXTlyjXUZHfuR2WYuP+In3dPHvI6hqaynb298Ieo+/6C?=
 =?us-ascii?Q?gw8s1h4mAba932O1GHj4vJYYNwndkPMuGud2E/doKM05DbSQajhMAMoGzdbB?=
 =?us-ascii?Q?geyH3BSDTUFluomYZHPMoyDXjOmU2H/sX1ayiFjiInu5GuXQgjRdvvnJjwXu?=
 =?us-ascii?Q?dqNoVaNR3JPgOT0tQQgzvrcki8xIrRiUvozdV4XaBSEwqzD4mLp00+VQVvQ/?=
 =?us-ascii?Q?pR2j9X09MDmCL5qUnsYeS6f7yrsQ7KovROFQvryZT5qZCvgT5KeXaug7Cho4?=
 =?us-ascii?Q?DxyV2MZvfbxgBbFbGqTCS2R5u1RlGOj7QBLKaXRyEHu5NXCpS2oDAgTGKGzx?=
 =?us-ascii?Q?wQCTz2Zk2SzpnIB2nXERuaZqQ0cpHfVAMBps2h96IrKUM6bdfHzovQ3SBjZm?=
 =?us-ascii?Q?1wgw0j3R8x2nai4fbjDwfHYGMbXavbsDIyIbn2PTIPL2oG6bnH69vlBcYtCh?=
 =?us-ascii?Q?BLuFrI4X3KsYZkkZLClkctr0+F3SxNCFOhdnvZDXXCDqpv26WJ0+d6I6GWER?=
 =?us-ascii?Q?JF7APyZs7JqMHwBV3NZjPDzpLR0PjXqz12SL4gUsS77qwW9iaxyVrimxC1Fk?=
 =?us-ascii?Q?QktOFrAKvOKKXRKLrNw=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80c2ea7c-9dae-4f28-9e87-08dc3f775b4f
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 13:55:04.6369
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Qe0bDRLz7ceeYBCEsYIU+IC/HB492OXTwI6aApWOpciFEVAPaRQsqZLF+Pb9FIXF
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6893

On Thu, Jan 11, 2024 at 06:06:42PM -0600, Suravee Suthikulpanit wrote:
> diff --git a/drivers/iommu/amd/amd_iommu_types.h b/drivers/iommu/amd/amd_iommu_types.h
> index ff56c857f6ad..f8baa8d88832 100644
> --- a/drivers/iommu/amd/amd_iommu_types.h
> +++ b/drivers/iommu/amd/amd_iommu_types.h
> @@ -93,8 +93,6 @@
>  #define FEATURE_GA		BIT_ULL(7)
>  #define FEATURE_HE		BIT_ULL(8)
>  #define FEATURE_PC		BIT_ULL(9)
> -#define FEATURE_GATS_SHIFT	(12)
> -#define FEATURE_GATS_MASK	(3ULL)
>  #define FEATURE_GAM_VAPIC	BIT_ULL(21)
>  #define FEATURE_GIOSUP		BIT_ULL(48)
>  #define FEATURE_HASUP		BIT_ULL(49)
> @@ -102,11 +100,14 @@
>  #define FEATURE_HDSUP		BIT_ULL(52)
>  #define FEATURE_SNP		BIT_ULL(63)
>  
> -#define FEATURE_PASID_SHIFT	32
> -#define FEATURE_PASID_MASK	(0x1fULL << FEATURE_PASID_SHIFT)
> +#define FEATURE_GATS_SHIFT	12
> +#define FEATURE_GATS_MASK	(0x03ULL << FEATURE_GATS_SHIFT)
>  
> -#define FEATURE_GLXVAL_SHIFT	14
> -#define FEATURE_GLXVAL_MASK	(0x03ULL << FEATURE_GLXVAL_SHIFT)
> +#define FEATURE_GLX_SHIFT	14
> +#define FEATURE_GLX_MASK	(0x03ULL << FEATURE_GLX_SHIFT)
> +
> +#define FEATURE_PASMAX_SHIFT	32
> +#define FEATURE_PASMAX_MASK	(0x1FULL << FEATURE_PASMAX_SHIFT)

If you are touching these please convert them all over to GENMASK.
ie:

#define FEATURE_PASMAX GENMASK_ULL(36, 32)

pasmax = FIELD_GET(FEATURE_PASMAX, amd_iommu_efr)

Jason