Received-SPF: pass (google.com: domain of linux-kernel+bounces-97139-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 8 Mar 2024 14:06:13 +0000
From: Sudeep Holla <sudeep.holla@arm.com>
To: Sibi Sankar <quic_sibis@quicinc.com>
Cc: <cristian.marussi@arm.com>, <rafael@kernel.org>,
	<viresh.kumar@linaro.org>, <morten.rasmussen@arm.com>,
	<dietmar.eggemann@arm.com>, <lukasz.luba@arm.com>,
	<sboyd@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
	<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<quic_mdtipton@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
	<nm@ti.com>
Subject: Re: [PATCH V3 2/2] cpufreq: scmi: Enable boost support
Message-ID: <ZesbVW0dDd1i2F_F@bogus>
References: <20240308104410.385631-1-quic_sibis@quicinc.com>
 <20240308104410.385631-3-quic_sibis@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240308104410.385631-3-quic_sibis@quicinc.com>

On Fri, Mar 08, 2024 at 04:14:10PM +0530, Sibi Sankar wrote:
> The X1E80100 SoC hosts a number of cpu boost frequencies, so let's enable
> boost support if the freq_table has any opps marked as turbo in it.
>

I had asked if you could put the information about how and when the boost
frequencies are used, it would be useful for reference purposes when someone
attempts to use this feature. But it is not a blocker, just good to have
info.

Also I would not sure specific platform name, just refer as certain platforms
as it such information becomes stale soon.

Anyways apart for those nits on the commit message, this looks good.

Reviewed-by: <viresh.kumar@linaro.org>

I am assuming Viresh might take both these changes for via his tree. If not,
I can take it for v6.10 after v6.9-rc1

-- 
Regards,
Sudeep