Received-SPF: pass (google.com: domain of linux-kernel+bounces-97124-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 8 Mar 2024 09:58:59 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux.dev, joro@8bytes.org,
	yi.l.liu@intel.com, kevin.tian@intel.com, nicolinc@nvidia.com,
	eric.auger@redhat.com, vasant.hegde@amd.com, jon.grimm@amd.com,
	santosh.shukla@amd.com, Dhaval.Giani@amd.com, pandoh@google.com,
	loganodell@google.com
Subject: Re: [RFCv2 PATCH 5/7] iommufd: Introduce data struct for AMD nested
 domain allocation
Message-ID: <20240308135859.GM9179@nvidia.com>
References: <20240112000646.98001-1-suravee.suthikulpanit@amd.com>
 <20240112000646.98001-6-suravee.suthikulpanit@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240112000646.98001-6-suravee.suthikulpanit@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?L7NKDGUlDAJLRIK9+zK1pmf7qIqUJRavYhw+QPCco35s1oR5r4WImQzdv8jC?=
 =?us-ascii?Q?LF4BFcne9xmcZcbNktyZvFCasao5O9DiymcQz//H0RoJVPtPvVDzS/4OVz1J?=
 =?us-ascii?Q?73Oq4XlQqmme44alkeiI7lwldmYspoAzr6XK6GXAq7akUnxKvB+vXTxGKK2P?=
 =?us-ascii?Q?8/WR19HcmzwLYppGF6+21td5a4GItAI6uw9ZAGhytPGC9SuPM+5M/QPdADt/?=
 =?us-ascii?Q?xaFyHUO8gZ9qKtA3LSG/ixbkCv3ozF96o75znHjeG6LYYgeZVj5hRXChE1eY?=
 =?us-ascii?Q?BOfDjjOnWXgDP8F53bt6wJuNsENJBOAsNtMmKtnALs4luhS4R0IDcGyElUh4?=
 =?us-ascii?Q?2+wOjrN58S7GpBhW5EIxbSsBoTyfs3NKF8ze8Lx3GCpoPN0iLRI6DnpyoocX?=
 =?us-ascii?Q?kDx9LjNPkYY8dWxGSQ+STzn/Jy+sRyGZ0fo3oSXnZ24uZkgieKAREW/NaEP2?=
 =?us-ascii?Q?3e4xmagc8TVd4KmA7fQiWHzKYNtPd4nF9nHF/uSYrx4NF2ZN2V5ubi2lTZt6?=
 =?us-ascii?Q?6qD4rZdPaCWRdgVkW7d0yJD5Y7J4D6jU7eJV/vPS/8gYeP0lnNHwRvAAYxQh?=
 =?us-ascii?Q?nfrHzXsVeJ19ykOGxUISA49s2W1c8jLfh0nH70tfYIrxPvgi8dqVPvwPXCSd?=
 =?us-ascii?Q?U+aDKTLLC+bgmQoF4acVGLqd2EiDWQHnWKmSvtUGOXmBCJ8bHDP0q28d6+8B?=
 =?us-ascii?Q?c7nzobrGC9KFDzocA7Xsfue/jv844vzvVMCw8ptwcQVoNIFo2U4W7BGdnbGM?=
 =?us-ascii?Q?JtbhEbCXMdUvrH56zSBeiitl7oK89liQhMvfu3311JeYyXLqZ46CjTS7gL7v?=
 =?us-ascii?Q?gZR+YeEaSdc4PFaf4rrLHJz0LzI7x1vRwqMugmAJlKDEEwBMsX6e1DGQpg6U?=
 =?us-ascii?Q?wQbpLgziWFeACwY+QgIt2NyuLDoosv5FMIe50QKIyfJO1NWKum5RDyemKxRQ?=
 =?us-ascii?Q?4QoTZUVLWWyrFpX/tnd2SEaoIvBREqBnRC334OPohpBC3McJuBtTTPqxeGps?=
 =?us-ascii?Q?e2TAR/rRjUMTq//Yg/+IWKL4MaIR6XW8WxV9dJPDX7sFerCfkwci7DtE/aFZ?=
 =?us-ascii?Q?QayLDr+iXTMHW6NH3/VFQEptvlWxL6FXOswC5JU0KECcLqeSOYdnKdubdgz6?=
 =?us-ascii?Q?HoyUenc2H8NlgbxtzWcsX57TRMJxFC5erS6YcY7Wfz5EGlEEoG1HcOlS3b20?=
 =?us-ascii?Q?CRCBWGJG4N8nT4YNuIZM4oF6T57WhitcLKvoDY03aWhaR32zSUE+E3vJXGW9?=
 =?us-ascii?Q?ZgiE483owepcft5eXzxjWP9HSZkRogbRQUcao1EX8aQbtKIL1eRfequ9xhjV?=
 =?us-ascii?Q?fJrt1Qpsacz1I9J+kfiZnau9WBknjZUXzpRrDGD/HsGRg/CdUDwQILRsuTDU?=
 =?us-ascii?Q?btPUOcsjSWq+kfYwgf6STNMBiAYFhhiBxYIEx6rPxD/VWEd4d6EeRCu8jbx7?=
 =?us-ascii?Q?P8/v/4LSr8uKLdKPRPhykJ+vNS6cllYrcw1ur3CAtjczVHz6TeS/rFXhjKU/?=
 =?us-ascii?Q?Ah4AYQ351jtu/4eJyyF839RyZaoZ0s61n5DB1D09GUSKo7hupuqK8y2yLSBV?=
 =?us-ascii?Q?pJi4hKjOQ+lYaZLrmUw=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4260134a-71ea-485f-607c-08dc3f77e87d
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 13:59:01.5055
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CvdSyKlxqwyw+pO2G2gpSbeB7iyBL0RpqUk+QefzdL32xM3wVZX8pAhPqGBE6r0Q
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR12MB8566

On Thu, Jan 11, 2024 at 06:06:44PM -0600, Suravee Suthikulpanit wrote:
> Introduce IOMMU_HWPT_DATA_AMD_V2 data type for AMD IOMMU v2 page table,
> which is used for stage-1 in nested translation. The data structure
> contains information necessary for setting up the AMD HW-vIOMMU support.
> 
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> ---
>  include/uapi/linux/iommufd.h | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/include/uapi/linux/iommufd.h b/include/uapi/linux/iommufd.h
> index 9901b9f4abe2..b28ec5947571 100644
> --- a/include/uapi/linux/iommufd.h
> +++ b/include/uapi/linux/iommufd.h
> @@ -389,14 +389,39 @@ struct iommu_hwpt_vtd_s1 {
>  	__u32 __reserved;
>  };
>  
> +/**
> + * struct iommu_hwpt_amd_v2 - AMD IOMMU specific user-managed
> + *                            v2 I/O page table data
> + * @gcr3: GCR3 guest physical ddress
> + * @flags.glx: GCR3 table levels
> + * @flags.giov: GIOV mode
> + * @flags.guest_paging_mode: Guest v2 page table paging mode
> + * @flags.reserved : Must be 0
> + * @gdom_id: Guest domain ID
> + * @__reserved: Must be 0
> + */
> +struct iommu_hwpt_amd_v2 {
> +	__aligned_u64 gcr3;
> +	struct {
> +		__aligned_u64 glx  : 1,
> +			      giov : 1,
> +			      guest_paging_mode : 2,
> +			      reserved : 60;
> +	} flags;

IIRC you should not put bitfileds in UAPI headers..

I suggest this should just be something like:

__aligned_u64 dte[3];

And you actually just copy bits directly from the vDTE to the pDTE.

Jason