Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp596782lqc; Fri, 8 Mar 2024 06:43:54 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXsXFWxwD2wEpTICIKWcL4yuibnH09I/NuWD8BhM3/56SqM9ndGskloSeHCMbdoFmWQYsUpyUtlUQMMGj/w1gRola9zO6plaYXEfCCkUA== X-Google-Smtp-Source: AGHT+IFUAqQ4qqsSw8jHRscZW6sZDCQbD/NhnL792MpfI9yWggiSDr7vS7JTLZsNRyxVQ3IMTWct X-Received: by 2002:a9d:6a53:0:b0:6e4:ddb2:29fd with SMTP id h19-20020a9d6a53000000b006e4ddb229fdmr12433019otn.4.1709909034300; Fri, 08 Mar 2024 06:43:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709909034; cv=pass; d=google.com; s=arc-20160816; b=Kt4+ranece9XZ0rGA8GzKOdwEHni88Pn82eJwWTZ49O5hV3nAWm7dzkOpvkFybnybv omf17DiGIT9RY2uEU9jglxhXwe9iOv6Nu/AVe8cg+JLXdeIKRa1hQnWH5EdrL3LL5zrh tn4WVASn4aD1cCkHCtrrMTnSEMqFJcowLkrNCFKUJkIC+Bk4nZEEeoOLH16kIj7cpbC0 aJXxygzDm0WUaKDuRpRHdhmh/EBHPhYzlNdEo9HINbiM1BbQp8BmuENJpD4o48BfEwF5 ohhVbiZAiXCD5sDwSxMvVpjXhxjS91r+pXJfy7qjX9hnTaVrFiUhnT+ocG7oi7O4Lkm2 NYdw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=EwxiSaQ3mxim1g4ESG20w5W3vrSpmDdurPH4l285wYo=; fh=9Est92WQWZSTyK6kWmk4a6A0tKq9lkaWBHTJs4vPrlM=; b=sDOrye9HGx8ECnSj/bX2KfTk2ZOOllSp1HlGoRf9Bi3zLhRvaS0ZJJGPH794JsB11O YKRas9awx+d0BzL0ng4K6H7eOlGcBGYyAFbRYez89C0s9/WqA2+gv7J0cHU9TrLbiVc6 BGaxNgI7h4t1kaCU+t3iX4mODfVImJ8z72dBhYTzSRLhq+nK1MSExhrYUIA4VrW4EKp9 mggYxaWe6lv3dyfBbEbXFGp6knuTGXrer/BJA6tZrYOmG/QnPHkwLJyFzmnixCSATyPg M02yEFsJGetFvYSeOMCAIEX5s0qF6pJKx3+1t+aHg5Otc3JntlnjM5SVGnOCLCnZhjBU e+dw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-97173-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97173-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id r15-20020a632b0f000000b005e2b3b075cdsi16129179pgr.403.2024.03.08.06.43.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 06:43:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-97173-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-97173-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97173-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1E6E7281B59 for ; Fri, 8 Mar 2024 14:42:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 72A6F1865; Fri, 8 Mar 2024 14:42:15 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCB841370 for ; Fri, 8 Mar 2024 14:42:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709908935; cv=none; b=dzzZSrTmxU761TR+FMMp+HOB2mIhR44H+YQsqXSwjsXNdH2wJpZTWXx0iEj9U+AV5WpQoypDK2MaeDnUqrd94VPr8/h6fMmZVO5HSqC9fHlyaCus870TBsSjhRyINr5acdso7d61yFbUUhmGCvFVry5qr9uFuwMoqNBgidLboSY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709908935; c=relaxed/simple; bh=EwxiSaQ3mxim1g4ESG20w5W3vrSpmDdurPH4l285wYo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hGnl/sqV42HtajZ7/q6j58yhcy9gSaO6kOQ+oZEHTD8KXn1CKH+EFoI/r4dTLJ55NAK+nndc1p5De3xtGhZiKHD1PiSoaxaISfKI67uXKLUYWLs28R6f9rfJW8WHDsElQiVM6VLy6/js2rL62ReMLl718Wewph0OjxqicZv3JPQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 6BC4D68BEB; Fri, 8 Mar 2024 15:42:08 +0100 (CET) Date: Fri, 8 Mar 2024 15:42:08 +0100 From: Christoph Hellwig To: "brookxu.cn" Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] nvme: fix reconnection fail due to reserved tag allocation Message-ID: <20240308144208.GA9194@lst.de> References: <20240308015435.100968-1-brookxu.cn@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240308015435.100968-1-brookxu.cn@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) The fix looks good: Reviewed-by: Christoph Hellwig But given that's we consolidate to a single place each for setting up the tagsets for admin and I/O queues, what about just killing the symbolic name and moving the assignments and comments directly into the only users?