Received-SPF: pass (google.com: domain of linux-kernel+bounces-97178-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <c895887c-7b5d-4254-9a91-76fb31e661f1@grimberg.me>
Date: Fri, 8 Mar 2024 16:44:15 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] nvme: fix reconnection fail due to reserved tag
 allocation
Content-Language: he-IL, en-US
To: Christoph Hellwig <hch@lst.de>, "brookxu.cn" <brookxu.cn@gmail.com>
Cc: kbusch@kernel.org, axboe@kernel.dk, linux-nvme@lists.infradead.org,
 linux-kernel@vger.kernel.org
References: <20240308015435.100968-1-brookxu.cn@gmail.com>
 <20240308144208.GA9194@lst.de>
From: Sagi Grimberg <sagi@grimberg.me>
In-Reply-To: <20240308144208.GA9194@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 08/03/2024 16:42, Christoph Hellwig wrote:
> The fix looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> But given that's we consolidate to a single place each for setting
> up the tagsets for admin and I/O queues, what about just killing
> the symbolic name and moving the assignments and comments directly
> into the only users?
>

That works too